code review

Author: Aingeru

SQLServer2SQLite.Core/Builders/InsertBuilder.cs

@@ -1,62 +1,60 @@
 using Microsoft.Data.Sqlite;
 using SqlServer2SqLite.Core.Models;
 using SQLServer2SQLite.Core.Helpers;
-using System;
 using System.Collections.Generic;
 using System.Data;
 using System.Text;
 
-namespace SQLServer2SQLite.Core.Builders
+namespace SQLServer2SQLite.Core.Builders;
+
+public class InsertBuilder
 {
-    public class InsertBuilder
+    /// <summary>
+    /// Creates a command object needed to insert values into a specific SQLite table.
+    /// </summary>
+    /// <param name="tableSchema">The table schema object for the table.</param>
+    /// <returns>A command object with the required functionality.</returns>
+    // TODO test!
+    public static SqliteCommand BuildSQLiteInsert(TableSchema tableSchema)
     {
-        /// <summary>
-        /// Creates a command object needed to insert values into a specific SQLite table.
-        /// </summary>
-        /// <param name="tableSchema">The table schema object for the table.</param>
-        /// <returns>A command object with the required functionality.</returns>
-        // TODO test!
-        public static SqliteCommand BuildSQLiteInsert(TableSchema tableSchema)
-        {
-            SqliteCommand res = new SqliteCommand();
+        SqliteCommand res = new SqliteCommand();
 
-            StringBuilder sb = new StringBuilder();
-            sb.Append("INSERT INTO [" + tableSchema.TableName + "] (");
-            for (int i = 0; i < tableSchema.Columns.Count; i++)
-            {
-                sb.Append("[" + tableSchema.Columns[i].ColumnName + "]");
-                if (i < tableSchema.Columns.Count - 1)
-                    sb.Append(", ");
-            }
-            sb.Append(") VALUES (");
+        StringBuilder sb = new StringBuilder();
+        sb.Append("INSERT INTO [" + tableSchema.TableName + "] (");
+        for (int i = 0; i < tableSchema.Columns.Count; i++)
+        {
+            sb.Append("[" + tableSchema.Columns[i].ColumnName + "]");
+            if (i < tableSchema.Columns.Count - 1)
+                sb.Append(", ");
+        }
+        sb.Append(") VALUES (");
 
-            List<string> pnames = new List<string>();
-            for (int i = 0; i < tableSchema.Columns.Count; i++)
-            {
-                string pname =
-                    "@" + TextHelper.GetNormalizedName(tableSchema.Columns[i].ColumnName, pnames);
-                sb.Append(pname);
-                if (i < tableSchema.Columns.Count - 1)
-                    sb.Append(", ");
+        List<string> pnames = new List<string>();
+        for (int i = 0; i < tableSchema.Columns.Count; i++)
+        {
+            string pname =
+                "@" + TextHelper.GetNormalizedName(tableSchema.Columns[i].ColumnName, pnames);
+            sb.Append(pname);
+            if (i < tableSchema.Columns.Count - 1)
+                sb.Append(", ");
 
-                SqliteType dbType = ColumnSchema.GetSqLiteDbTypeOfColumn(
-                    tableSchema.Columns[i].ColumnType
-                );
-                SqliteParameter prm = new SqliteParameter(
-                    pname,
-                    dbType,
-                    1,
-                    tableSchema.Columns[i].ColumnName
-                );
-                res.Parameters.Add(prm);
+            SqliteType dbType = ColumnSchema.GetSqLiteDbTypeOfColumn(
+                tableSchema.Columns[i].ColumnType
+            );
+            SqliteParameter prm = new SqliteParameter(
+                pname,
+                dbType,
+                1,
+                tableSchema.Columns[i].ColumnName
+            );
+            res.Parameters.Add(prm);
 
-                // Remember the parameter name in order to avoid duplicates
-                pnames.Add(pname);
-            }
-            sb.Append(")");
-            res.CommandText = sb.ToString();
-            res.CommandType = CommandType.Text;
-            return res;
+            // Remember the parameter name in order to avoid duplicates
+            pnames.Add(pname);
         }
+        sb.Append(")");
+        res.CommandText = sb.ToString();
+        res.CommandType = CommandType.Text;
+        return res;
     }
 }