chore: Increase test coverage for transactions (#119)

Author: ciband

tests/configuration/test_network.py

@@ -3,6 +3,7 @@
 from crypto.configuration.network import get_network, set_custom_network, set_network
 from crypto.networks.devnet import Devnet
 from crypto.networks.mainnet import Mainnet
+from crypto.networks.testnet import Testnet
 
 
 def test_get_network():
@@ -11,9 +12,16 @@ def test_get_network():
 
 
 def test_set_network():
+    # test main net
     set_network(Mainnet)
     result = get_network()
     assert result['version'] == 23
+    assert result['wif'] == 170
+    # test test net
+    set_network(Testnet)
+    result = get_network()
+    assert result['version'] == 23
+    assert result['wif'] == 186
     set_network(Devnet)  # set back to devnet so other tests don't fail
 
 

tests/transactions/builder/test_delegate_registration.py

@@ -23,5 +23,28 @@ def test_delegate_registration_transaction():
     assert transaction_dict['type'] is TRANSACTION_DELEGATE_REGISTRATION
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 2500000000
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_delegate_registration_transaction_custom_fee():
+    """Test if a delegate registration transaction gets built with a custom fee
+    """
+    delegate_name = 'mr.delegate'
+
+    transaction = DelegateRegistration(delegate_name, 5)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['asset']['delegate']['username'] == delegate_name
+    assert transaction_dict['type'] is TRANSACTION_DELEGATE_REGISTRATION
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid

tests/transactions/builder/test_delegate_resignation.py

@@ -20,5 +20,25 @@ def test_delegate_resignation_transaction():
     assert transaction_dict['type'] is TRANSACTION_DELEGATE_RESIGNATION
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 2500000000
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_delegate_resignation_transaction_custom_fee():
+    """Test if delegate resignation transaction gets built with a custom fee
+    """
+    transaction = DelegateResignation(5)
+    transaction.set_nonce(1)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_DELEGATE_RESIGNATION
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid

tests/transactions/builder/test_htlc_claim.py

@@ -25,6 +25,33 @@ def test_htlc_claim_transaction():
     assert transaction_dict['type'] is TRANSACTION_HTLC_CLAIM
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 0
+    assert transaction_dict['asset']['claim']['lockTransactionId'] == '943c220691e711c39c79d437ce185748a0018940e1a4144293af9d05627d2eb4'
+    assert transaction_dict['asset']['claim']['unlockSecret'] == 'my secret that should be 32bytes'
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_htlc_claim_transaction_custom_fee():
+    """Test if timelock transaction gets built with a custom fee
+    """
+    lock_transaction_id = '943c220691e711c39c79d437ce185748a0018940e1a4144293af9d05627d2eb4'
+
+    # This should be the hashed secret used for HTLC Lock transaction
+    unlock_secret = 'my secret that should be 32bytes'
+
+    transaction = HtlcClaim(lock_transaction_id, unlock_secret, 5)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_HTLC_CLAIM
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
     assert transaction_dict['asset']['claim']['lockTransactionId'] == '943c220691e711c39c79d437ce185748a0018940e1a4144293af9d05627d2eb4'
     assert transaction_dict['asset']['claim']['unlockSecret'] == 'my secret that should be 32bytes'
 

tests/transactions/builder/test_htlc_lock.py

@@ -1,8 +1,9 @@
+import pytest
+
 from crypto.configuration.network import set_network
 from crypto.constants import TRANSACTION_HTLC_LOCK, TRANSACTION_TYPE_GROUP
 from crypto.networks.devnet import Devnet
 from crypto.transactions.builder.htlc_lock import HtlcLock
-import pytest
 
 set_network(Devnet)
 
@@ -69,6 +70,39 @@ def test_htlc_lock_transaction():
     assert transaction_dict['type'] is TRANSACTION_HTLC_LOCK
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 10000000
+    assert transaction_dict['asset']['lock']['secretHash'] == '0f128d401958b1b30ad0d10406f47f9489321017b4614e6cb993fc63913c5454'
+    assert transaction_dict['asset']['lock']['expiration']['type'] == 1
+    assert transaction_dict['asset']['lock']['expiration']['value'] == 1573455822
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_htlc_lock_transaction_custom_fee():
+    """Test if timelock transaction gets built with a custom fee
+    """
+    transaction = HtlcLock(
+      recipient_id='AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC',
+      amount=200000000,
+      secret_hash='0f128d401958b1b30ad0d10406f47f9489321017b4614e6cb993fc63913c5454',
+      expiration_type=1,
+      expiration_value=1573455822,
+      fee=5
+    )
+
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['recipientId'] == 'AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC'
+    assert transaction_dict['amount'] == 200000000
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_HTLC_LOCK
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
     assert transaction_dict['asset']['lock']['secretHash'] == '0f128d401958b1b30ad0d10406f47f9489321017b4614e6cb993fc63913c5454'
     assert transaction_dict['asset']['lock']['expiration']['type'] == 1
     assert transaction_dict['asset']['lock']['expiration']['value'] == 1573455822

tests/transactions/builder/test_htlc_refund.py

@@ -23,6 +23,31 @@ def test_timelock_refund_transaction():
     assert transaction_dict['type'] is TRANSACTION_HTLC_REFUND
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 0
+    assert transaction_dict['asset']['refund']['lockTransactionId'] == '943c220691e711c39c79d437ce185748a0018940e1a4144293af9d05627d2eb4'
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_timelock_refund_transaction_custom_fee():
+    """Test if timelock transaction gets built with custom fee
+    """
+    transaction = HtlcRefund(
+      lock_transaction_id='943c220691e711c39c79d437ce185748a0018940e1a4144293af9d05627d2eb4',
+      fee=5
+    )
+
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_HTLC_REFUND
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
     assert transaction_dict['asset']['refund']['lockTransactionId'] == '943c220691e711c39c79d437ce185748a0018940e1a4144293af9d05627d2eb4'
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid

tests/transactions/builder/test_ipfs.py

@@ -24,6 +24,29 @@ def test_ipfs_transaction():
     assert transaction_dict['type'] is TRANSACTION_IPFS
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 500000000
+    assert transaction_dict['asset']['ipfs'] == ipfs_id
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_ipfs_transaction_custom_fee():
+    """Test if ipfs transaction gets built with custom fee
+    """
+    ipfs_id = b58encode('hello')
+
+    transaction = IPFS(ipfs_id, 5)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_IPFS
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
     assert transaction_dict['asset']['ipfs'] == ipfs_id
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid

tests/transactions/builder/test_multi_payment.py

@@ -22,6 +22,32 @@ def test_multi_payment_transaction():
     assert transaction_dict['type'] is TRANSACTION_MULTI_PAYMENT
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 10000000
+    assert transaction_dict['asset']['payments'][0]['amount'] == 1
+    assert transaction_dict['asset']['payments'][0]['recipientId'] == 'AHXtmB84sTZ9Zd35h9Y1vfFvPE2Xzqj8ri'
+    assert transaction_dict['asset']['payments'][1]['amount'] == 2
+    assert transaction_dict['asset']['payments'][1]['recipientId'] == 'ATK14wxyYxbELq2b91bAfBY8Vmh9J6MDej'
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_multi_payment_transaction_custom_fee():
+    """Test if multi payment transaction gets built with a custom fee
+    """
+    transaction = MultiPayment(fee=5)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.add_payment(1, 'AHXtmB84sTZ9Zd35h9Y1vfFvPE2Xzqj8ri')
+    transaction.add_payment(2, 'ATK14wxyYxbELq2b91bAfBY8Vmh9J6MDej')
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_MULTI_PAYMENT
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
     assert transaction_dict['asset']['payments'][0]['amount'] == 1
     assert transaction_dict['asset']['payments'][0]['recipientId'] == 'AHXtmB84sTZ9Zd35h9Y1vfFvPE2Xzqj8ri'
     assert transaction_dict['asset']['payments'][1]['amount'] == 2

tests/transactions/builder/test_second_signature_registration.py

@@ -20,5 +20,25 @@ def test_second_signature_registration_transaction():
     assert transaction_dict['type'] is TRANSACTION_SECOND_SIGNATURE_REGISTRATION
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 500000000
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_second_signature_registration_transaction_custom_fee():
+    """Test if a second signature registration transaction gets built with a custom fee
+    """
+    transaction = SecondSignatureRegistration('this is a top secret passphrase', 5)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('testing')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_SECOND_SIGNATURE_REGISTRATION
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid

tests/transactions/builder/test_transfer.py

@@ -1,9 +1,12 @@
+import pytest
+
 from crypto.configuration.network import set_network
 from crypto.constants import TRANSACTION_TRANSFER, TRANSACTION_TYPE_GROUP
 from crypto.identity.public_key import PublicKey
 from crypto.networks.devnet import Devnet
 from crypto.transactions.builder.transfer import Transfer
 
+
 set_network(Devnet)
 
 
@@ -24,6 +27,53 @@ def test_transfer_transaction():
     assert transaction_dict['type'] is TRANSACTION_TRANSFER
     assert transaction_dict['typeGroup'] == 1
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 10000000
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_transfer_transaction_update_amount():
+    """Test if a transfer transaction can update an amount
+    """
+    transaction = Transfer(
+        recipientId='AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC',
+        amount=200000000
+    )
+    transaction.set_amount(10)
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('this is a top secret passphrase')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_TRANSFER
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['amount'] == 10
+
+    transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
+
+
+def test_transfer_transaction_custom_fee():
+    """Test if a transfer transaction gets built with a custom fee
+    """
+    transaction = Transfer(
+        recipientId='AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC',
+        amount=200000000,
+        fee=5
+    )
+    transaction.set_type_group(TRANSACTION_TYPE_GROUP.CORE)
+    transaction.set_nonce(1)
+    transaction.schnorr_sign('this is a top secret passphrase')
+    transaction_dict = transaction.to_dict()
+
+    assert transaction_dict['nonce'] == 1
+    assert transaction_dict['signature']
+    assert transaction_dict['type'] is TRANSACTION_TRANSFER
+    assert transaction_dict['typeGroup'] == 1
+    assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
+    assert transaction_dict['fee'] == 5
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
 
@@ -49,9 +99,9 @@ def test_transfer_secondsig_transaction():
     assert transaction_dict['typeGroup'] == TRANSACTION_TYPE_GROUP.CORE.value
 
     transaction.schnorr_verify()  # if no exception is raised, it means the transaction is valid
-    transaction.schnorr_verify_second(PublicKey.from_passphrase('second top secret passphrase')) # if no exception is raised, it means the transaction is valid
-    
-    
+    transaction.schnorr_verify_second(PublicKey.from_passphrase('second top secret passphrase'))  # if no exception is raised, it means the transaction is valid
+
+
 def test_parse_signatures(transaction_type_0):
     """Test if parse signature works when parsing serialized data
     """
@@ -62,3 +112,23 @@ def test_parse_signatures(transaction_type_0):
     assert transfer.transaction.signature is None
     transfer.transaction.parse_signatures(transaction_type_0['serialized'], 166)
     assert transfer.transaction.signature
+
+
+def test_transfer_transaction_amount_not_int():
+    with pytest.raises(ValueError):
+        """Test error handling in constructor for non-integer amount
+        """
+        Transfer(
+            recipientId='AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC',
+            amount='bad amount'
+        )
+
+
+def test_transfer_transaction_amount_zero():
+    with pytest.raises(ValueError):
+        """Test error handling in constructor for non-integer amount
+        """
+        Transfer(
+            recipientId='AGeYmgbg2LgGxRW2vNNJvQ88PknEJsYizC',
+            amount=0
+        )