Merge remote-tracking branch 'origin/arduino' into chore(arduino)/merge-changes-at-105

Author: sleepdefic1t

.circleci/config.yml

@@ -18,4 +18,3 @@ workflows:
   build:
     jobs:
       - build-arduino-default
-

.gitattributes

@@ -5,4 +5,3 @@
 /.editorconfig    export-ignore
 /.gitattributes   export-ignore
 /.gitignore       export-ignore
-/README.md        export-ignore

.gitignore

@@ -1,74 +1,4 @@
 
-.DS_Store
-/.history
-/.vs
+/.circleci
 /.vscode
-.pioenvs
-.piolibdeps
-.vscode/.browse.c_cpp.db*
-.vscode/c_cpp_properties.json
-.vscode/launch.json
-/include/uECC
-/lib/
-/bin/
-/src/CMakeFiles
-/CMakeFiles
-/src/Ark-Cpp-Crypto-lib.dir
-/src/cmake_install.cmake
-/src/Ark-Cpp-Crypto-lib.vcxproj.filters
-/src/Ark-Cpp-Crypto-lib.vcxproj
-/src/Ark-Cpp-Crypto-lib.sln
-/src/ALL_BUILD.vcxproj.filters
-/src/ALL_BUILD.vcxproj
-/test/Ark-Cpp-Crypto-tests.dir
-/test/CMakeFiles
-/test/NightlyMemoryCheck.vcxproj.filters
-/test/NightlyMemoryCheck.vcxproj
-/test/Nightly.vcxproj.filters
-/test/Nightly.vcxproj
-/test/Experimental.vcxproj.filters
-/test/Experimental.vcxproj
-/test/DartConfiguration.tcl
-/test/CTestTestfile.cmake
-/test/Continuous.vcxproj.filters
-/test/Continuous.vcxproj
-/test/cmake_install.cmake
-/test/Ark-Cpp-Crypto-tests.vcxproj.filters
-/test/Ark-Cpp-Crypto-tests.vcxproj
-/test/Ark-Cpp-Crypto-tests.sln
-/test/ALL_BUILD.vcxproj.filters
-/test/ALL_BUILD.vcxproj
-/test/INSTALL.vcxproj.filters
-/test/INSTALL.vcxproj
-/Win32
-/_3rdParty/Hunter
-/ZERO_CHECK.vcxproj.filters
-/ZERO_CHECK.vcxproj
-/cmake_install.cmake
-/CMakeCache.txt
-/Ark-Cpp-Crypto.sln
-/ALL_BUILD.vcxproj.filters
-/ALL_BUILD.vcxproj
-/src/INSTALL.vcxproj.filters
-/src/INSTALL.vcxproj
-/INSTALL.vcxproj.filters
-/INSTALL.vcxproj
-/src/Debug
-/test/Debug
-/examples/cmake_example/ZERO_CHECK.vcxproj.filters
-/examples/cmake_example/Win32/Debug
-/examples/cmake_example/cmake_example.vcxproj.filters
-/examples/cmake_example/cmake_example.vcxproj
-/examples/cmake_example/cmake_example.sln
-/examples/cmake_example/cmake_example.dir/Debug
-/examples/cmake_example/Debug
-/examples/cmake_example/cmake_install.cmake
-/examples/cmake_example/CMakeFiles
-/examples/cmake_example/CMakeCache.txt
-/examples/cmake_example/ALL_BUILD.vcxproj.filters
-/examples/cmake_example/ALL_BUILD.vcxproj
-/examples/cmake_example/ZERO_CHECK.vcxproj
-/examples/cmake_example/Cpp-Crypto-Example.dir/Debug
-/examples/cmake_example/Cpp-Crypto-Example.vcxproj.filters
-/examples/cmake_example/Cpp-Crypto-Example.vcxproj
-/examples/cmake_example/Cpp-Crypto-Example.sln
+.DS_Store

extras/docs/cpp.md

@@ -4,10 +4,6 @@ title: "Cpp"
 
 # Cpp
 
-::: warning
-This project is still under development. This page will get more content as the project evolves. In the meantime you can view its source on [Github](https://github.com/ArkEcosystem/cpp-crypto/).
-:::
-
 [[toc]]
 
 ## Installation  
@@ -63,7 +59,6 @@ const auto MyBridgechainTransaction = Builder::buildTransfer(
         MyBridgechainConfiguration);
 ```
 
-
 #### With custom Fees
 
 ```cpp
@@ -205,16 +200,16 @@ const uint8_t wifByte = 0xaa;
 WIF wif = WIF::fromPassphrase(passphrase, wifByte);
 ```
 
-# 
+#
 
 # Arduino
-**Arduino IDE:**  
-Download and install the Arduino IDE (>=1.8.5) from the following link:  
+**Arduino IDE:**
+Download and install the Arduino IDE (>=1.8.5) from the following link:
 ```https://www.arduino.cc/en/Main/Software```
 
-Using the Arduino IDE's built in Library Manager,  
-install the following Libraries:  
-```micro-ecc```  
+Using the Arduino IDE's built in Library Manager,
+install the following Libraries:
+```micro-ecc```
 ```AUnit```
 
 #### Ensure all git submodules have been cloned
@@ -268,11 +263,11 @@ void setup()
 void loop() {}
 ```
 
-**PlatformIO IDE:**  
+**PlatformIO IDE:**
 
-#### Python:  
-Use an installer package from the following link or use your preferred method to install Python:  
-```https://www.python.org/downloads/```  
+#### Python:
+Use an installer package from the following link or use your preferred method to install Python:
+```https://www.python.org/downloads/```
 
 Install PlatformIO:
 
@@ -295,7 +290,7 @@ Install AUnit (2778), micro-ecc (1665)
 
     cd test
 
-#### execute the following command to upload test to your board  
+#### execute the following command to upload test to your board
 
 >| board | command |
 >|:-- |:-- |
@@ -307,20 +302,20 @@ Install AUnit (2778), micro-ecc (1665)
 # OS
 ## Linux, macOS and Windows
 
-**CMake:**  
+**CMake:**
 
-Use an installer package from the following link, Homebrew, or use your preferred method:  
+Use an installer package from the following link, Homebrew, or use your preferred method:
 ```https://www.cmake.org/download/```
 
 using
-**Homebrew:**  
+**Homebrew:**
 
     brew install cmake
 
 > note: all other dependencies will be automatically installed via CMake and Hunter Package Manager.
 
 ### make and build
-    cd cpp-crypto  
+    cd cpp-crypto
     cmake . && cmake --build .
 
 ### run tests (Linux, macOS)

library.json

@@ -7,7 +7,7 @@
     "type": "git",
     "url": "https://github.com/ArkEcosystem/Cpp-Crypto.git"
   },
-  "version": "0.6.0",
+  "version": "0.6.0-arduino",
   "authors": [
     {
       "name": "Ark Ecosystem",
@@ -23,29 +23,9 @@
     },
     {
       "name": "ArduinoJson"
+    },
+    {
+      "name": "BIP66"
     }
-  ],
-  "export": {
-    "include": [
-      "src/*",
-      "examples/*",
-      "docs/*",
-      "extras/*",
-      "*.md",
-      "*.json",
-      "*.properties",
-      "LICENSE",
-      "*.ini",
-      "keywords.txt"
-    ],
-    "exclude": [
-      "*/*.txt"
-    ]
-  },
-  "build": {
-    "flags": [
-      "-I src/include/cpp-crypto",
-      "-I src/lib"
-    ]
-  }
-}
+  ]
+}

library.properties

@@ -1,5 +1,5 @@
 name=Ark-Cpp-Crypto
-version=0.6.0
+version=0.6.0-arduino
 author=Ark Ecosystem
 maintainer=Ark Ecosystem
 sentence=A simple Cryptography Implementation in C++ for the ARK Blockchain.

src/identities/privatekey.h

@@ -10,34 +10,42 @@
 #ifndef PRIVATEKEY_H
 #define PRIVATEKEY_H
 
-#include "helpers/crypto_helpers.h"
-
-#include <cstdint>
+#include <cassert>
 #include <string>
+#include "bcl/Base58Check.hpp"
+#include "bcl/Sha256.hpp"
+#include "bcl/Sha256Hash.hpp"
+#include "helpers/encoding/hex.h"
+#include "helpers/crypto_helpers.h"
 
 namespace Ark {
 namespace Crypto {
 namespace Identities {
-/**/
+
+/**
+ * This is the private key class.
+ *
+ * @author Simon Downey <simon@ark.io>
+ **/
 class PrivateKey {
-private:
-  uint8_t bytes_[PRIVATEKEY_SIZE] {};
+ protected:
+  uint8_t bytes_[PRIVATEKEY_SIZE];
 
-public:
-  PrivateKey() : bytes_() {};
-  PrivateKey(const char* newPrivateKeyStr);
-  PrivateKey(const uint8_t* newPrivateKeyBytes);
+ public:
+  PrivateKey() : bytes_(){};
+  PrivateKey(const char *const newPrivateKeyStr);
+  PrivateKey(const uint8_t *newPrivateKeyBytes);
 
   const uint8_t *toBytes();
   std::string toString() const;
 
-  static PrivateKey fromPassphrase(const char* passphrase);
-  static PrivateKey fromHex(const char* privateKey);
-  static PrivateKey fromWIFString(const char* wifStr, uint8_t wifByte);
+  static PrivateKey fromPassphrase(const char *const passphrase);
+  static PrivateKey fromHex(const char *const privateKey);
+  static PrivateKey fromWIFString(const char *wifStr, uint8_t wifByte);
 
   static bool validate(PrivateKey privateKey);
-  static bool validate(const char* privateKeyStr);
-  static bool validate(const uint8_t* privateKeyBytes);
+  static bool validate(const char *privateKeyStr);
+  static bool validate(const uint8_t *privateKeyBytes);
 };
 /**/
 };  // namespace Identities