Skip to content

Commit 81647da

Browse files
sleepdefic1tfaustbrian
authored andcommitted
test(networks): Fix AbstractNetwork Tests (#102)
Current tests are ran in different orders per platform. This led to a modified global test custom_network being modified improperly. This PR properly handles that order variation by creating a local object to be modified. In future iterations, an AbstractNetwork will allow `const`.
1 parent d9322d2 commit 81647da

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

test/networks/abstractnetwork.cpp

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,16 @@ TEST(networks, abstract_network_base58_prefix_get) {
5959
/**/
6060

6161
TEST(networks, abstract_network_base58_prefix_set) {
62-
CUSTOM_NETWORK.setBase58Prefix(BASE58_ADDRESS_P2PKH, 0x10);
63-
ASSERT_EQ(0x10, CUSTOM_NETWORK.getBase58Prefix(BASE58_ADDRESS_P2PKH));
62+
AbstractNetwork testNetwork = CUSTOM_NETWORK;
6463

65-
CUSTOM_NETWORK.setBase58Prefix(BASE58_ADDRESS_P2SH, 0x20);
66-
ASSERT_EQ(0x20, CUSTOM_NETWORK.getBase58Prefix(BASE58_ADDRESS_P2SH));
64+
testNetwork.setBase58Prefix(BASE58_ADDRESS_P2PKH, 0x10);
65+
ASSERT_EQ(0x10, testNetwork.getBase58Prefix(BASE58_ADDRESS_P2PKH));
6766

68-
CUSTOM_NETWORK.setBase58Prefix(BASE58_WIF, 0x30);
69-
ASSERT_EQ(0x30, CUSTOM_NETWORK.getBase58Prefix(BASE58_WIF));
67+
testNetwork.setBase58Prefix(BASE58_ADDRESS_P2SH, 0x20);
68+
ASSERT_EQ(0x20, testNetwork.getBase58Prefix(BASE58_ADDRESS_P2SH));
69+
70+
testNetwork.setBase58Prefix(BASE58_WIF, 0x30);
71+
ASSERT_EQ(0x30, testNetwork.getBase58Prefix(BASE58_WIF));
7072
}
7173

7274
/**/
@@ -79,11 +81,13 @@ TEST(networks, abstract_network_bip32_prefix_get) {
7981
/**/
8082

8183
TEST(networks, abstract_network_bip32_prefix_set) {
82-
CUSTOM_NETWORK.setBIP32Prefix(BIP32_PREFIX_XPUB, 1000000);
83-
ASSERT_EQ(1000000, CUSTOM_NETWORK.getBIP32Prefix(BIP32_PREFIX_XPUB));
84+
AbstractNetwork testNetwork = CUSTOM_NETWORK;
85+
86+
testNetwork.setBIP32Prefix(BIP32_PREFIX_XPUB, 1000000);
87+
ASSERT_EQ(1000000, testNetwork.getBIP32Prefix(BIP32_PREFIX_XPUB));
8488

85-
CUSTOM_NETWORK.setBIP32Prefix(BIP32_PREFIX_XPRV, 1000001);
86-
ASSERT_EQ(1000001, CUSTOM_NETWORK.getBIP32Prefix(BIP32_PREFIX_XPRV));
89+
testNetwork.setBIP32Prefix(BIP32_PREFIX_XPRV, 1000001);
90+
ASSERT_EQ(1000001, testNetwork.getBIP32Prefix(BIP32_PREFIX_XPRV));
8791
}
8892

8993
/**/

0 commit comments

Comments
 (0)