improve mapping generator dockwidget UI

Author: mwinkens

src/dialogs/dialog_check_map.py

@@ -14,10 +14,10 @@
 
 
 class CheckMapDialog(QDialog):
-    def __init__(self, parent, *args, **kwargs):
+    def __init__(self, parent, title, cancel, *args, **kwargs):
         super().__init__(parent, *args, **kwargs)
 
-        self.setWindowTitle("Check tile configurations")
+        self.setWindowTitle(title)
         self.layout = QGridLayout()
         self.layout.setHorizontalSpacing(0)
         self.layout.setVerticalSpacing(0)
@@ -58,11 +58,15 @@ def __init__(self, parent, *args, **kwargs):
                 self.layout.addWidget(tile, grid_y, grid_x, 1, 1)
 
         # add ok and cancel button
-        q_btn = QDialogButtonBox.StandardButton.Ok | QDialogButtonBox.StandardButton.Cancel
+        if cancel:
+            q_btn = QDialogButtonBox.StandardButton.Ok | QDialogButtonBox.StandardButton.Cancel
+        else:
+            q_btn = QDialogButtonBox.StandardButton.Ok
 
         self.buttonBox = QDialogButtonBox(q_btn)
         self.buttonBox.accepted.connect(self.accept)
-        self.buttonBox.rejected.connect(self.reject)
+        if cancel:
+            self.buttonBox.rejected.connect(self.reject)
         self.layout.addWidget(self.buttonBox, height + 2, 0, 1, width, Qt.AlignmentFlag.AlignHCenter)
         self.setLayout(self.layout)
         self.setModal(True)

src/widgets/widget_mapper_generator.py

@@ -54,8 +54,12 @@ def __init__(self, parent=None):
         self.image_label = QLabel("No Image")
         self.layout.addWidget(self.image_label)
 
-        # check ddnet
-        self.ddnet_push_button = QPushButton("Check with ddnet")
+        # check map
+        self.check_map_button = QPushButton("Check mapping rules")
+        self.layout.addWidget(self.check_map_button)
+
+        # check map with ddnet
+        self.ddnet_push_button = QPushButton("Check mapping rules with ddnet")
         self.layout.addWidget(self.ddnet_push_button)
         if ConfigManager.instance().config()["client_path"] is None:
             self.ddnet_push_button.setDisabled(True)
@@ -65,6 +69,7 @@ def __init__(self, parent=None):
 
         # Generate button
         self.generate_button = QPushButton("Generate")
+        self.generate_button.setEnabled(False)  # no rule name yet
         self.layout.addWidget(self.generate_button)
 
         self.setLayout(self.layout)
@@ -74,8 +79,10 @@ def __init__(self, parent=None):
         # handle connections
         for radio_button in self.radio_buttons:
             radio_button.toggled.connect(self.ruleNameToggle)
-        self.generate_button.clicked.connect(self.openFileDialog)
+        self.generate_button.clicked.connect(self.startRuleGeneration)
         self.ddnet_push_button.clicked.connect(self.startDDNetCheck)
+        self.check_map_button.clicked.connect(self.checkMappingRules)
+        self.new_mapper_line_edit.textChanged.connect(self.mappingRuleNameChanged)
 
         # some configuration
         # configure validator new_mapper_line_edit
@@ -94,11 +101,11 @@ def setImage(self, image_path):
         self.image_label.setScaledContents(True)
         self.image_label.setMaximumSize(200, 200)
 
-    def openFileDialog(self):
+    def startRuleGeneration(self):
         rule_name = self.new_mapper_line_edit.text()
         if not AppState.imagePath() or not len(rule_name):
             return
-        cmd = CheckMapDialog(self)
+        cmd = CheckMapDialog(self, title=f"Do you want to save your mapping rule '{rule_name}'?", cancel=True)
         ret = cmd.exec()
         if ret:
             loaded_image_path = Path(AppState.imagePath())
@@ -115,6 +122,16 @@ def openFileDialog(self):
             else:
                 QMessageBox.warning(self, "Warning", "Please select an image first.")
         """
+    def checkMappingRules(self):
+        cmd = CheckMapDialog(self, title="Check Mapping Rules", cancel=False)
+        cmd.exec()
+
+    def mappingRuleNameChanged(self):
+        rule_name = self.new_mapper_line_edit.text()
+        if not rule_name or len(rule_name) == 0:
+            self.generate_button.setDisabled(True)
+        else:
+            self.generate_button.setEnabled(True)
 
     def ruleNameToggle(self):
         if self.radio_buttons[0].isChecked():