Merge pull request #251 from AthennaIO/develop

chore: remove trace options from arguments

Author: jlenon7

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@athenna/core",
-  "version": "5.15.0",
+  "version": "5.16.0",
   "description": "One foundation for multiple applications.",
   "license": "MIT",
   "author": "João Lenon <lenon@athenna.io>",

package.json

@@ -19,7 +19,6 @@ export class Cron {
    */
   public static async boot(options?: CronOptions): Promise<CronImpl> {
     options = Options.create(options, {
-      trace: Config.get('cron.trace', false),
       routePath: Path.routes(`cron.${Path.ext()}`),
       kernelPath: '@athenna/cron/kernels/CronKernel'
     })
@@ -53,7 +52,7 @@ export class Cron {
 
     const kernel = new Kernel()
 
-    await kernel.registerRTracer(options.trace)
+    await kernel.registerRTracer()
     await kernel.registerExceptionHandler(options.exceptionHandlerPath)
     await kernel.registerSchedulers()
     await kernel.registerRoutes(options.routePath)

src/applications/Cron.ts

@@ -8,13 +8,6 @@
  */
 
 export type CronOptions = {
-  /**
-   * Create a custom trace uuid to all new requests done to the server using AsyncLocalStorage.
-   *
-   * @default Config.get('cron.trace', false)
-   */
-  trace?: boolean
-
   /**
    * The path to the cron routes.
    *

src/types/CronOptions.ts

@@ -12,8 +12,8 @@ import { Path } from '@athenna/common'
 import { Cron } from '#src/applications/Cron'
 import { CommanderHandler } from '@athenna/artisan'
 import { Log, LoggerProvider } from '@athenna/logger'
+import { Cron as CronFacade, CronProvider, CronBuilder } from '@athenna/cron'
 import { Test, type Context, BeforeEach, AfterEach, Mock } from '@athenna/test'
-import { Cron as CronFacade, CronProvider, CronKernel, CronBuilder } from '@athenna/cron'
 
 export default class CronTest {
   private cronBuilder: CronBuilder
@@ -63,15 +63,6 @@ export default class CronTest {
     assert.calledOnceWith(Log.info, 'importing CustomCronExceptionHandler')
   }
 
-  @Test()
-  public async shouldBeAbleToBootACronApplicationWithTracingPluginRegistered({ assert }: Context) {
-    Mock.when(CronKernel.prototype, 'registerRTracer').resolve(undefined)
-
-    await Cron.boot({ trace: true })
-
-    assert.calledOnceWith(CronKernel.prototype.registerRTracer, true)
-  }
-
   @Test()
   public async shouldBeAbleToBootACronApplicationAndRegisterTheRouteFile({ assert }: Context) {
     await Cron.boot({ routePath: Path.fixtures('routes/cron.ts') })

tests/unit/applications/CronTest.ts

@@ -12,8 +12,8 @@ import { Path } from '@athenna/common'
 import { Http } from '#src/applications/Http'
 import { CommanderHandler } from '@athenna/artisan'
 import { Log, LoggerProvider } from '@athenna/logger'
+import { HttpServerProvider, HttpRouteProvider, Server } from '@athenna/http'
 import { Test, type Context, BeforeEach, AfterEach, Mock } from '@athenna/test'
-import { HttpServerProvider, HttpRouteProvider, Server, HttpKernel } from '@athenna/http'
 
 export default class HttpTest {
   @BeforeEach()
@@ -82,17 +82,6 @@ export default class HttpTest {
     assert.calledOnceWith(Server.listen, { host: '127.0.0.1', port: 3000 })
   }
 
-  @Test()
-  public async shouldBeAbleToBootAHttpApplicationWithTracingPluginRegistered({ assert }: Context) {
-    Mock.when(HttpKernel.prototype, 'registerRTracer').resolve(undefined)
-    Server.when('listen').resolve(undefined)
-
-    await Http.boot({ trace: true })
-
-    assert.calledOnceWith(Server.listen, { host: '127.0.0.1', port: 3000 })
-    assert.calledOnceWith(HttpKernel.prototype.registerRTracer, true)
-  }
-
   @Test()
   public async shouldBeAbleToBootAHttpApplicationAndRegisterTheRouteFile({ assert }: Context) {
     Server.when('listen').resolve(undefined)