Skip to content

Commit 00605e4

Browse files
os check while group install and list emulators in separate command
1 parent ee1f302 commit 00605e4

3 files changed

Lines changed: 37 additions & 30 deletions

File tree

Framework/install_handler/long_poll_handler.py

Lines changed: 32 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from Framework.install_handler.route import Response, services
88
from Framework.install_handler.utils import (
99
debug,
10+
current_os,
1011
send_response,
1112
read_node_id,
1213
generate_services_list,
@@ -57,29 +58,6 @@ async def on_message(self, message: Response) -> None:
5758
}
5859
)
5960

60-
avd_list = await get_filtered_avd_services()
61-
if avd_list:
62-
await send_response(
63-
{
64-
"action": "services_update",
65-
"data": {
66-
'category': 'AndroidEmulator',
67-
"services": avd_list['services'],
68-
},
69-
}
70-
)
71-
72-
simulator_list = await get_filtered_simulator_services()
73-
if simulator_list:
74-
await send_response(
75-
{
76-
"action": "services_update",
77-
"data": {
78-
'category': 'iOSSimulator',
79-
"services": simulator_list['services'],
80-
},
81-
}
82-
)
8361
elif action == "system_info":
8462
if debug:
8563
print(f"[installer] Received system_info request")
@@ -113,6 +91,21 @@ async def on_message(self, message: Response) -> None:
11391
if category["category"] == "AndroidEmulator":
11492
service_name = message.value.item.name
11593

94+
# Case 0: If list of emulators needed to be sent
95+
if service_name == 'emulator_list':
96+
avd_list = await get_filtered_avd_services()
97+
if avd_list:
98+
await send_response(
99+
{
100+
"action": "services_update",
101+
"data": {
102+
'category': 'AndroidEmulator',
103+
"services": avd_list['services'],
104+
},
105+
}
106+
)
107+
return
108+
116109
# Case 1: No service name or empty - get system images list
117110
if not service_name:
118111
if (
@@ -176,6 +169,21 @@ async def on_message(self, message: Response) -> None:
176169
)
177170
service_name = message.value.item.name
178171

172+
# Case 0: If list of simulators needed to be sent
173+
if service_name == 'simulator_list':
174+
simulator_list = await get_filtered_simulator_services()
175+
if simulator_list:
176+
await send_response(
177+
{
178+
"action": "services_update",
179+
"data": {
180+
'category': 'iOSSimulator',
181+
"services": simulator_list['services'],
182+
},
183+
}
184+
)
185+
return
186+
179187
# Case 1: No service name or empty - get device types list
180188
if not service_name:
181189
if action == "install" and "install_function" in category and category["install_function"]:
@@ -269,7 +277,7 @@ async def on_message(self, message: Response) -> None:
269277
i for i in services if i["category"] == message.value.item.category
270278
][0]["services"]
271279
functions = [
272-
i["status_function"] for i in services_list if i["status_function"]
280+
i["status_function"] for i in services_list if i["status_function"] and current_os in i["os"]
273281
]
274282
for func in functions:
275283
await func()

Framework/install_handler/route.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@
195195
{
196196
"category": "MacOS",
197197
"group": {
198-
"check_text": "",
199-
"install_text": "",
198+
"check_text": "Check all",
199+
"install_text": "Install all",
200200
},
201201
"services": [
202202
{
@@ -268,8 +268,8 @@
268268
{
269269
"category": "Windows",
270270
"group": {
271-
"check_text": "",
272-
"install_text": "",
271+
"check_text": "Check all",
272+
"install_text": "Install all",
273273
},
274274
"install_function": inspector.install,
275275
"services": [

Framework/install_handler/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@
55

66
debug = False
77
version = "2.0.0"
8+
current_os = platform.system().lower()
89

910

1011
def read_node_id():
1112
return CommonUtil.MachineInfo().getLocalUser().lower()
1213

1314

1415
def generate_services_list(services):
15-
current_os = platform.system().lower()
16-
1716
filtered_services = []
1817
for category in services:
1918
filtered_category = {

0 commit comments

Comments
 (0)