fixed linux installation issue

Author: mahbd

Framework/Built_In_Automation/Desktop/Linux/BuiltInFunctions.py

@@ -235,27 +235,12 @@ def capture_screenshot(file_path: str, app_name: str | None = None) -> bool:
                     if os.path.exists(file_path) and os.path.getsize(file_path) > 0:
                         return True
     except FileNotFoundError:
-        # xwd not present; fallback to previously supported tools
-        pass
+        # xwd not present
+        CommonUtil.ExecLog(MODULE_NAME, "xwd command not found", 3)
     except Exception as e:
         CommonUtil.ExecLog(MODULE_NAME, f"xwd/convert screenshot failed: {e}", 3)
 
-    # Fallback: try scrot / gnome-screenshot / import (root window capture) like before
-    tools = [
-        ["scrot", file_path],
-        ["gnome-screenshot", "-f", file_path],
-        ["import", "-window", "root", file_path]
-    ]
-
-    for cmd in tools:
-        try:
-            subprocess.run(cmd, check=True, capture_output=True)
-            if os.path.exists(file_path) and os.path.getsize(file_path) > 0:
-                return True
-        except (subprocess.CalledProcessError, FileNotFoundError):
-            continue
-
-    CommonUtil.ExecLog(MODULE_NAME, "Failed to capture screenshot. Ensure xwd/xdotool and at least one screenshot tool like scrot, gnome-screenshot, or imagemagick are installed.", 3)
+    CommonUtil.ExecLog(MODULE_NAME, "Failed to capture screenshot. Ensure xwd, xdotool, and ImageMagick (convert) are installed.", 3)
     return False
 
 

Installer/setup_linux_inspector.sh

@@ -10,7 +10,9 @@ APT_PACKAGES=(
   libgirepository1.0-dev
   libcairo2-dev
   xdotool
-  scrot
+  x11-apps            # provides xwd
+  imagemagick         # provides convert, import
+  wmctrl
 )
 
 DNF_PACKAGES=(
@@ -19,9 +21,11 @@ DNF_PACKAGES=(
   gobject-introspection-devel
   cairo-devel
   xdotool
+  xorg-x11-utils      # provides xwd on some distros
+  ImageMagick
+  wmctrl
   python3-devel
   cairo-gobject-devel
-  scrot
 )
 
 PACMAN_PACKAGES=(
@@ -32,7 +36,8 @@ PACMAN_PACKAGES=(
   cairo
   xdotool
   gobject-introspection
-  scrot
+  imagemagick
+  wmctrl
 )
 
 BREW_PACKAGES=(
@@ -41,7 +46,7 @@ BREW_PACKAGES=(
   cairo
   xdotool
   gobject-introspection
-  scrot
+  imagemagick
 )
 
 # Function to join array into space-separated string
@@ -74,3 +79,16 @@ else
 fi
 
 echo "✅ Installation complete."
+
+# Post-install sanity checks for screenshot/capture utilities
+echo "\nChecking availability of key utilities:" 
+REQUIRED_TOOLS=(xdotool xwd convert import wmctrl)
+for t in "${REQUIRED_TOOLS[@]}"; do
+  if command -v "$t" >/dev/null 2>&1; then
+    echo " - $t: available"
+  else
+    echo " - $t: NOT FOUND"
+  fi
+done
+
+echo "If any of the above are missing, please install them for full Linux inspector functionality."

node_cli.py

@@ -1173,8 +1173,6 @@ async def command_line_args() -> Path | None:
 
     # Desktop automation and UI inspection options
     install_linux_deps = all_arguments.install_linux_deps
-    list_apps = all_arguments.list_apps
-    dump_ui = all_arguments.dump_ui
 
     # Handle RSA key management commands
     if generate_key:
@@ -1201,6 +1199,11 @@ async def command_line_args() -> Path | None:
             sys.exit(0)
         else:
             sys.exit(1)
+    if install_linux_deps:
+        if install_linux_inspector_deps():
+            sys.exit(0)
+        else:
+            sys.exit(1)
 
     # Update chrome extension download settings if specified
     if chrome_fetch is not None: