Managed objects aren't Sendable, but their keys are

Author: nolanw

App/View Controllers/Messages/MessageViewController.swift

@@ -262,9 +262,7 @@ final class MessageViewController: ViewController {
 
                     if message.seen == false {
                         message.seen = true
-                        try await message.managedObjectContext?.perform {
-                            try message.managedObjectContext?.save()
-                        }
+                        try message.managedObjectContext?.save()
                     }
                 } catch {
                     title = ""

AwfulCore/Sources/AwfulCore/Model/AwfulManagedObject.swift

@@ -5,14 +5,14 @@
 import CoreData
 
 /// A slightly more convenient NSManagedObject for entities with a custom class.
-public class AwfulManagedObject: NSManagedObject, @unchecked Sendable {
+public class AwfulManagedObject: NSManagedObject {
     public var objectKey: AwfulObjectKey {
         fatalError("subclass implementation please")
     }
 }
 
 /// An object key uniquely identifies an AwfulManagedObject, but (unlike NSManagedObjectID) in an Awful-specific away.
-public class AwfulObjectKey: NSObject, NSCoding, NSCopying {
+public class AwfulObjectKey: NSObject, NSCoding, NSCopying, @unchecked Sendable {
     let entityName: String
     var keys: [String] {
         fatalError("subclass implementation please")

AwfulCore/Sources/AwfulCore/Model/Forum.swift

@@ -36,7 +36,7 @@ public class Forum: AwfulManagedObject, Managed {
 }
 
 @objc(ForumKey)
-public final class ForumKey: AwfulObjectKey {
+public final class ForumKey: AwfulObjectKey, @unchecked Sendable {
     @objc let forumID: String
 
     public init(forumID: String) {
@@ -99,7 +99,7 @@ public class ForumGroup: AwfulManagedObject, Managed {
 }
 
 @objc(ForumGroupKey)
-public final class ForumGroupKey: AwfulObjectKey {
+public final class ForumGroupKey: AwfulObjectKey, @unchecked Sendable {
     let groupID: String
 
     public init(groupID: String) {

AwfulCore/Sources/AwfulCore/Model/Post.swift

@@ -6,7 +6,7 @@ import CoreData
 
 /// A single reply to a thread.
 @objc(Post)
-public class Post: AwfulManagedObject, Managed, @unchecked Sendable {
+public class Post: AwfulManagedObject, Managed {
     public static var entityName: String { "Post" }
 
     /// Whether the logged-in user can edit the post.
@@ -74,7 +74,7 @@ private func pageForIndex(index: Int32) -> Int {
 }
 
 @objc(PostKey)
-public final class PostKey: AwfulObjectKey {
+public final class PostKey: AwfulObjectKey, @unchecked Sendable {
     @objc public let postID: String
 
     public init(postID: String) {

AwfulCore/Sources/AwfulCore/Model/PrivateMessage.swift

@@ -51,7 +51,7 @@ extension PrivateMessage {
 }
 
 @objc(PrivateMessageKey)
-public final class PrivateMessageKey: AwfulObjectKey {
+public final class PrivateMessageKey: AwfulObjectKey, @unchecked Sendable {
     @objc public let messageID: String
 
     public init(messageID: String) {

AwfulCore/Sources/AwfulCore/Model/Thread.swift

@@ -142,7 +142,7 @@ extension AwfulThread {
 }
 
 @objc(ThreadKey)
-public final class ThreadKey: AwfulObjectKey {
+public final class ThreadKey: AwfulObjectKey, @unchecked Sendable {
     @objc let threadID: String
 
     public init(threadID: String) {

AwfulCore/Sources/AwfulCore/Model/ThreadTag.swift

@@ -34,7 +34,7 @@ extension ThreadTag {
 }
 
 @objc(ThreadTagKey)
-public final class ThreadTagKey: AwfulObjectKey {
+public final class ThreadTagKey: AwfulObjectKey, @unchecked Sendable {
     @objc public let imageName: String?
     @objc public let threadTagID: String?
 

AwfulCore/Sources/AwfulCore/Model/User.swift

@@ -51,7 +51,7 @@ public func extractAvatarURL(fromCustomTitleHTML customTitleHTML: String) -> URL
 }
 
 @objc(UserKey)
-public final class UserKey: AwfulObjectKey {
+public final class UserKey: AwfulObjectKey, @unchecked Sendable {
     @objc public let userID: String
     @objc let username: String?