update

Author: zhiyuanliang-ms

package-lock.json

@@ -25,7 +25,7 @@
     "dev": "rollup --config --watch",
     "lint": "eslint src/ test/",
     "fix-lint": "eslint src/ test/ --fix",
-    "test": "mocha out/test/*.test.{js,cjs,mjs} --parallel"
+    "test": "mocha out/test/load.test.{js,cjs,mjs} --parallel"
   },
   "repository": {
     "type": "git",

package.json

@@ -60,8 +60,6 @@ import { InvalidOperationError, ArgumentError, isFailoverableError, isInputError
 
 const MIN_DELAY_FOR_UNHANDLED_FAILURE = 5_000; // 5 seconds
 
-const MAX_TAG_FILTER_COUNT = 5;
-
 type PagedSettingSelector = SettingSelector & {
     pageEtags?: string[];
 };
@@ -982,11 +980,11 @@ function getValidSettingSelectors(selectors: SettingSelector[]): SettingSelector
         const selector = { ...selectorCandidate };
         if (selector.snapshotName) {
             if (selector.keyFilter || selector.labelFilter || selector.tagFilters) {
-                throw new ArgumentError("Key, label or tag filter should not be used for a snapshot.");
+                throw new ArgumentError("Key, label or tag filters should not be specified while selecting a snapshot.");
             }
         } else {
-            if (!selector.keyFilter && (!selector.tagFilters || selector.tagFilters.length === 0)) {
-                throw new ArgumentError("Key filter and tag filter cannot both be null or empty.");
+            if (!selector.keyFilter) {
+                throw new ArgumentError("Key filter cannot be null or empty.");
             }
             if (!selector.labelFilter) {
                 selector.labelFilter = LabelFilter.Null;
@@ -1041,9 +1039,6 @@ function getValidFeatureFlagSelectors(selectors?: SettingSelector[]): SettingSel
 }
 
 function validateTagFilters(tagFilters: string[]): void {
-    if (tagFilters.length > MAX_TAG_FILTER_COUNT) {
-        throw new Error(`The number of tag filters cannot exceed ${MAX_TAG_FILTER_COUNT}.`);
-    }
     for (const tagFilter of tagFilters) {
         const res = tagFilter.split("=");
         if (res[0] === "" || res.length !== 2) {

src/AzureAppConfigurationImpl.ts

@@ -142,7 +142,7 @@ describe("load", function () {
             selectors: [{
                 labelFilter: "\0"
             }]
-        })).eventually.rejectedWith("Key filter and tag filter cannot both be null or empty.");
+        })).eventually.rejectedWith("Key filter cannot be null or empty.");
     });
 
     it("should throw error given invalid snapshot selector", async () => {
@@ -152,7 +152,7 @@ describe("load", function () {
                 snapshotName: "Test",
                 labelFilter: "\0"
             }]
-        })).eventually.rejectedWith("Key, label or tag filter should not be used for a snapshot.");
+        })).eventually.rejectedWith("Key, label or tag filters should not be specified while selecting a snapshot.");
     });
 
     it("should not include feature flags directly in the settings", async () => {
@@ -183,6 +183,7 @@ describe("load", function () {
         const connectionString = createMockedConnectionString();
         const loadWithTag1 = await load(connectionString, {
             selectors: [{
+                keyFilter: "*",
                 tagFilters: ["tag1=someValue"]
             }]
         });
@@ -194,6 +195,7 @@ describe("load", function () {
 
         const loadWithMultipleTags = await load(connectionString, {
             selectors: [{
+                keyFilter: "*",
                 tagFilters: ["tag1=someValue", "tag2=someValue"]
             }]
         });
@@ -316,6 +318,7 @@ describe("load", function () {
         const connectionString = createMockedConnectionString();
         const loadWithInvalidTagFilter = load(connectionString, {
             selectors: [{
+                keyFilter: "*",
                 tagFilters: ["testTag"]
             }]
         });