Skip to content

fix(vscode): Update dependencies to latest for codeful public preview#9193

Merged
lambrianmsft merged 8 commits into
Azure:mainfrom
lambrianmsft:lambrian/codeful-public-preview
May 20, 2026
Merged

fix(vscode): Update dependencies to latest for codeful public preview#9193
lambrianmsft merged 8 commits into
Azure:mainfrom
lambrianmsft:lambrian/codeful-public-preview

Conversation

@lambrianmsft
Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Updating the sdk and lsp server to have the latest versions required for codeful workflows. These changes are all for public preview. There is no impact on other features.

Impact of Change

  • Users:
    Users will see additional supported actions for codeful workflows and all customers can now access it.
  • Developers:
    N/A
  • System:
    N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:
    VSIX was manually built and tested with these new changes, ensuring that the latest sdk is reflected and the actions are available.

Contributors

@andrew-eldridge

Screenshots/Videos

Copilot AI review requested due to automatic review settings May 20, 2026 00:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates VS Code designer codeful project configuration by removing hardcoded extension-bundle pinning/override settings so codeful workflows rely on the default extension bundle range and public feed behavior for public preview.

Changes:

  • Removed the pinned AzureFunctionsJobHost__extensionBundle__version value from codeful local.settings.json schema defaults.
  • Stopped generating AzureFunctionsJobHost__extensionBundle__version and FUNCTIONS_EXTENSIONBUNDLE_SOURCE_URI in new codeful projects’ local.settings.json.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File Description
apps/vs-code-designer/src/app/utils/appSettings/localSettings.ts Removes codeful defaults that pinned bundle version and private bundle source URI.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts Stops emitting bundle version/source URI overrides when scaffolding codeful projects.

Comment thread apps/vs-code-designer/src/app/utils/appSettings/localSettings.ts
@lambrianmsft lambrianmsft enabled auto-merge (squash) May 20, 2026 16:40
@github-actions
Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Update dependencies to latest for codeful public preview
  • Issue: Title is acceptable and follows conventional commits scope/subject. It is a bit generic — it doesn't call out the most important packages changed (lsp server, workflows SDK) or that this is for public preview. Consider adding a short hint about the key dependency areas updated.
  • Recommendation: Keep the current title or make it slightly more specific, e.g. fix(vscode): update lsp-server and workflows-sdk for codeful public preview

Commit Type

  • Properly selected (fix).
  • Note: Only one commit type is selected in the PR body which is correct.

Risk Level

  • The PR body selects: Low.
  • Assessment: The PR currently has no risk label applied to the GitHub PR (labels: []). Dependency upgrades to the LSP server and SDK can introduce behavioral changes and wider surface impact (runtime integration with VSIX and workflows). Based on the described changes, I advise Medium risk.
  • Recommendation: Add a matching label to the PR (e.g. risk:medium) or provide justification and additional validation evidence if you believe the risk truly is Low (strong automated test coverage, backward-compatibility guarantees from upstream, etc.). Also update the Risk Level checkboxes in the PR body to match the chosen label.

⚠️ What & Why

  • Current: "Updating the sdk and lsp server to have the latest versions required for codeful workflows. These changes are all for public preview. There is no impact on other features."
  • Issue: This is brief. Good as a short summary, but it should list the main packages that were updated (package names and new versions or ranges) and a sentence about why they are required for public preview.
  • Recommendation: Expand to include specific packages and versions. Example: Updating @azure/workflows-sdk from x.y.z to a.b.c and lsp-server from x.y to a.b to enable X/Y features for codeful workflows in public preview.

⚠️ Impact of Change

  • Developers/System entries are marked N/A which is unexpected for dependency upgrades.
  • Issue: Dependency upgrades can affect developers (local builds, new APIs) and system behavior (runtime/version compatibility). Marking N/A does not give reviewers enough context.
  • Recommendation: Populate these fields with concrete impact statements:
    • Users: e.g. "Users of codeful workflows will see additional supported actions and improved behavior in X scenarios." (you already have this — keep it)
    • Developers: e.g. "May need to run npm install to update lockfile, watch for new lint/build rules, and update local dev environment if the SDK introduces breaking changes."
    • System: e.g. "VSIX packaging and the LSP integration tested in VS Code; monitor for any performance regressions or telemetry spikes after release."

⚠️ Test Plan

  • Assessment: The PR indicates manual testing completed and notes a VSIX was built and tested.
  • Issue: No unit or E2E tests were added and the PR does not detail the manual test scenarios, pass/fail criteria, or environment matrix. For dependency updates, automated tests or at least a clear manual verification checklist are strongly recommended.
  • Recommendation: Either add/point to automated tests that cover the updated functionality, or expand the Test Plan to include:
    • The exact manual scenarios executed (steps), VS Code version used, OS matrix, and how you verified the new actions are available.
    • Any smoke test commands and logs (or links to test artifacts) used to validate the VSIX.
    • If automated tests cannot be added for this change, state why and provide a risk mitigation plan (rollout gating, telemetry, quick rollback instructions).

Contributors

  • Assessment: @andrew-eldridge is listed. Good to credit reviewers/implementers.
  • Note: If others contributed (PM, Designer, additional reviewers), consider adding them as well.

Screenshots/Videos

  • Assessment: Not applicable / not required for this PR (no UI changes called out). No action required.

Summary Table

Section Status Recommendation
Title Consider making it slightly more specific (call out lsp-server/workflows-sdk)
Commit Type No change needed
Risk Level Add risk:medium label or justify Low with stronger validation evidence
What & Why ⚠️ Expand to list specific packages/versions and reason for upgrade
Impact of Change ⚠️ Fill out Developers/System impact and describe potential compatibility considerations
Test Plan ⚠️ Provide detailed manual test checklist or add automated tests; include VSIX test artifacts or logs
Contributors OK — add others if applicable
Screenshots/Videos Not required

Final message:
Please update the PR to:

  • Add a risk label to the PR (recommended risk:medium) and update the Risk Level checkbox to match. If you keep Low, include explicit justification (e.g., comprehensive automated tests and compatibility guarantees).
  • Expand "What & Why" to list the specific packages and versions updated.
  • Populate Developers and System impact sections with expected effects and mitigations.
  • Improve the Test Plan: either add unit/E2E tests or provide a detailed manual verification checklist, VS Code versions/OS used, and artifacts or logs from the VSIX test.

Once those changes are made (or you provide strong justification for Low risk and absence of automated tests), this can be approved and merged. Thank you for the clear PR body and manual test note — the remaining items are primarily for traceability and risk mitigation.


Last updated: Wed, 20 May 2026 16:49:14 GMT

@lambrianmsft lambrianmsft merged commit 3f0854f into Azure:main May 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants