Skip to content

Commit 624dfe2

Browse files
committed
fix: Review templates
1 parent ffb41ff commit 624dfe2

3 files changed

Lines changed: 6 additions & 22 deletions

File tree

internal/template/generator/node.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,10 @@ func generateNode() (config.Config, error) {
3535

3636
cfg.DefaultTask = determineDefaultTask(pkg.Scripts)
3737

38-
cfg.Tasks["install"] = models.Task{
38+
cfg.Hooks["install"] = models.Hook{
3939
Name: "install",
40-
Alias: "i",
4140
Command: packageManager + " install",
4241
Description: "Install dependencies",
43-
Cache: true,
44-
Inputs: []string{"package.json", getPackageLockFile(packageManager)},
45-
Outputs: []string{"node_modules"},
4642
}
4743

4844
for scriptName, scriptCommand := range pkg.Scripts {
@@ -214,14 +210,10 @@ func generateTaskFromScript(name, command, pm string) models.Task {
214210
func generateDefaultNode(cfg *config.Config) (config.Config, error) {
215211
cfg.DefaultTask = "build"
216212

217-
cfg.Tasks["install"] = models.Task{
213+
cfg.Hooks["install"] = models.Hook{
218214
Name: "install",
219-
Alias: "i",
220215
Command: "npm install",
221216
Description: "Install dependencies",
222-
Cache: true,
223-
Inputs: []string{"package.json", "package-lock.json"},
224-
Outputs: []string{"node_modules"},
225217
}
226218

227219
cfg.Tasks["build"] = models.Task{

internal/template/generator/python.go

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func generatePython() (config.Config, error) {
3333
cfg.DefaultTask = "test"
3434
}
3535

36-
cfg.Tasks["install"] = generateInstallTask(depManager)
36+
cfg.Hooks["install"] = generateInstallHook(depManager)
3737

3838
if entryPoint != "" {
3939
cfg.Tasks["run"] = models.Task{
@@ -150,32 +150,24 @@ func hasPyprojectToml() bool {
150150
return hasFile("pyproject.toml")
151151
}
152152

153-
func generateInstallTask(depManager string) models.Task {
153+
func generateInstallHook(depManager string) models.Hook {
154154
var command string
155-
var inputs []string
156155

157156
switch depManager {
158157
case "poetry":
159158
command = "poetry install"
160-
inputs = []string{"pyproject.toml", "poetry.lock"}
161159
case "pdm":
162160
command = "pdm install"
163-
inputs = []string{"pyproject.toml", "pdm.lock"}
164161
case "pipenv":
165162
command = "pipenv install"
166-
inputs = []string{"Pipfile", "Pipfile.lock"}
167163
default:
168164
command = "pip install -r requirements.txt"
169-
inputs = []string{"requirements.txt"}
170165
}
171166

172-
return models.Task{
167+
return models.Hook{
173168
Name: "install",
174-
Alias: "i",
175169
Command: command,
176170
Description: "Install dependencies",
177-
Cache: true,
178-
Inputs: inputs,
179171
}
180172
}
181173

internal/template/generator/rust.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func generateRust() (config.Config, error) {
4747
Alias: "r",
4848
Command: "cargo build --release",
4949
Description: "Build release binary",
50-
Requires: []string{"test"},
50+
DependsOn: []string{"test"},
5151
Cache: true,
5252
Inputs: []string{"src/**/*.rs", "Cargo.toml", "Cargo.lock"},
5353
Outputs: []string{"target/release"},

0 commit comments

Comments
 (0)