refactor: minor cleanups from code review

- Read VERSION from package metadata instead of hardcoding it in config.py
- Add parentheses to clarify operator precedence in po2file
- Rename `dir` parameter in find_files to avoid shadowing built-in
- Run tests before publish in release workflow

Author: burner1024

.github/workflows/release.yml

@@ -14,6 +14,9 @@ jobs:
       - name: Install uv
         uses: astral-sh/setup-uv@v7
 
+      - name: Run tests
+        run: uv run pytest
+
       - name: Publish to PyPi
         if: startsWith(github.ref, 'refs/tags/')
         run: |

msg2po/common.py

@@ -2,12 +2,12 @@
 import os
 
 
-def find_files(dir: str, ext: str):
+def find_files(directory: str, ext: str):
     """
-    Find files with extension ext in directory dir
+    Find files with extension ext in directory
     """
     files = []
-    for root, _subdir_list, file_list in os.walk(dir):
+    for root, _subdir_list, file_list in os.walk(directory):
         for f in file_list:
             if get_ext(f) == ext:
                 files.append(os.path.join(root, f))

msg2po/config.py

@@ -4,12 +4,13 @@
 
 import os
 from dataclasses import dataclass, field
+from importlib.metadata import version as _pkg_version
 from typing import Any
 
 import ruamel.yaml
 from loguru import logger
 
-VERSION = "1.5.0"
+VERSION = _pkg_version("msg2po")
 
 TRANSLATION_DEFAULTS: dict[str, Any] = {
     "encoding": "cp1252",

msg2po/conversion.py

@@ -122,7 +122,7 @@ def po2file(
         po_index = file_trans["po_index"]
         entry = po[po_index]
 
-        if entry.msgstr == "" or "fuzzy" in entry.flags and not extract_fuzzy:  # if not translated, keep msgid
+        if entry.msgstr == "" or ("fuzzy" in entry.flags and not extract_fuzzy):  # if not translated, keep msgid
             value = entry.msgid
         else:
             value = entry.msgstr  # either translated or fuzzy+extract_fuzzy