[Bug] Attribute modifications provided by effects are not cleared after the end of the effects

[Galysso]

What happened? Describe in detail down below and include the mod version as well.

It took me some time to find the responsible mod. To make quick tests I used the following setup:

• Place a beacon with speed effect as a bonus (the speed attributes changes the field of view, so it is very easy to see when the attribute is increased/removed).
• Drink milk when you have the effect to remove it (and see if the field of view goes back to normal).

I am on Fabric 1.21.1, version 2.0.4 of the mod.

Thank you very much for your work :-)

What mod loaders is this problem occuring on?

Fabric

What do you think this bug is related to?

• Visual
• Feature Related
• Crash
• Mod Conflict
• Others

Relevant logs

I think logs are irrelevant in this case.

Anything else?

No response

By submitting this issue, I have confirmed I have followed all instructions and all my mods are up-to-date.

• Yes

[Galysso]

By the way, I found another issue without digging further and it is likely related:

When I have a weapon providing a certain attribute (like attack damange), going back to an empty hand keeps the attack damage from the weapon.

[MasterCakeX5]

This happened to me as well in the neoforge 1.21.1 version and it drove me insane! Thankfully I found this mod and disabled it - now that behaviour is gone.