Skip to content

Commit 6cead5b

Browse files
committed
fix PHP warnings on not-set values in reviews
1 parent eb0ddc7 commit 6cead5b

1 file changed

Lines changed: 14 additions & 12 deletions

File tree

google-play.php

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ public function parseApplication($packageName, $lang='en_US', $loc='US') {
222222

223223
$limit = 5; $proto = '';
224224
while ( empty($proto) && $limit > 0 ) { // sometimes protobuf is missing, but present again on subsequent call
225-
$proto = json_decode($this->getRegVal("/key: 'ds:4'. hash: '7'. data:(?<content>\[\[\[.+?). sideChannel: .*?\);<\/script/ims")); // DataSource:4 = featureGraphic, video, summary
225+
$proto = json_decode($this->getRegVal("/key: 'ds:4'. hash: '\d+'. data:(?<content>\[\[\[.+?). sideChannel: .*?\);<\/script/ims")); // DataSource:4 = featureGraphic, video, summary
226226
if ( empty($proto) || empty($proto[1]) ) {
227227
$this->getApplicationPage($packageName, $lang, $loc);
228228
--$limit;
@@ -242,17 +242,19 @@ public function parseApplication($packageName, $lang='en_US', $loc='US') {
242242
if ( $proto = json_decode($this->getRegVal("/key: 'ds:7'. hash: '\d+'. data:(?<content>\[\[\[.+?). sideChannel: .*?\);<\/script/ims")) ) { // DataSource:7 = reviews
243243
foreach($proto[0] as $rev) {
244244
$r["review_id"] = $rev[0];
245-
$r["reviewed_version"] = $rev[10];
246-
$r["review_date"] = $rev[5][0];
247-
$r["review_text"] = $rev[4];
248-
$r["stars"] = $rev[2];
249-
$r["like_count"] = $rev[6];
250-
$r["reviewer"] = [
251-
"reviewer_id"=>$rev[9][0],
252-
"name"=>$rev[9][1],
253-
"avatar"=>$rev[9][3][0][3][2],
254-
"bg_image"=>$rev[9][4][3][2]
255-
];
245+
$r["reviewed_version"] = (isset($rev[10])) ? $rev[10] : '';
246+
$r["review_date"] = isset($rev[5][0]) ? $rev[5][0] : '';
247+
$r["review_text"] = isset($rev[4]) ? $rev[4] : '';
248+
$r["stars"] = isset($rev[2]) ? $rev[2] : '';
249+
$r["like_count"] = isset ($rev[6]) ? $rev[6] : '';
250+
if ( isset($rev[9]) && !empty($rev[9]) ) {
251+
$r["reviewer"] = [
252+
"reviewer_id"=>$rev[9][0],
253+
"name"=>$rev[9][1],
254+
"avatar"=>$rev[9][3][0][3][2],
255+
"bg_image"=>$rev[9][4][3][2]
256+
];
257+
} else $r["reviewer"] = [];
256258
if ( empty($rev[7]) ) {
257259
$r["reply"] = [];
258260
} else {

0 commit comments

Comments
 (0)