Commit 5543e3f
authored
desktop: shrink dashboard Tasks/Goals cards to fit content (#6902)
## Summary
Both `TasksWidget` and `GoalsWidget` had `.frame(maxHeight: .infinity,
alignment: .topLeading)` at their root. With `ChatMessagesView` below
them (also `maxHeight: .infinity`), the two siblings competed for
vertical space and each grabbed roughly half the dashboard — even when
the Tasks card had 2–3 rows and the Goals card had 1–2 goals.
This PR removes the maxHeight infinity from both widget roots and the
inner Spacers in the non-empty branches, so the cards size to their
content. The Grid in `DashboardPage.expandedWidgets` still equalizes the
row to the taller of the two intrinsic heights.
## Test plan
- [ ] Open the dashboard with a small number of tasks (≤3) and goals
(≤2) — both cards should hug their content; chat should fill the rest.
- [ ] Scale up tasks to ~10 — Tasks card grows to fit 3 rows + "View
all" footer (`prefix(3)` is unchanged); Goals card matches its height.
- [ ] Empty state for both — cards display their empty-state content
with reasonable padding instead of large empty centered area.
🤖 Generated with [Claude Code](https://claude.com/claude-code)3 files changed
Lines changed: 57 additions & 73 deletions
File tree
- desktop
- Desktop/Sources/MainWindow/Components
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
Lines changed: 21 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
57 | 51 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 52 | + | |
| 53 | + | |
62 | 54 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
67 | 59 | | |
68 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
69 | 64 | | |
70 | 65 | | |
71 | 66 | | |
| |||
85 | 80 | | |
86 | 81 | | |
87 | 82 | | |
88 | | - | |
| 83 | + | |
89 | 84 | | |
90 | 85 | | |
91 | 86 | | |
| |||
Lines changed: 33 additions & 46 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
47 | 41 | | |
48 | 42 | | |
49 | | - | |
| 43 | + | |
50 | 44 | | |
51 | 45 | | |
52 | 46 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
69 | 52 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 53 | | |
82 | | - | |
83 | | - | |
| 54 | + | |
84 | 55 | | |
85 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
86 | 72 | | |
87 | | - | |
| 73 | + | |
| 74 | + | |
88 | 75 | | |
89 | 76 | | |
90 | 77 | | |
91 | | - | |
| 78 | + | |
92 | 79 | | |
93 | 80 | | |
94 | 81 | | |
| |||
0 commit comments