Moved checksum check for _toolbar.html.erb into test step

Author: davezuckerman

.github/workflows/build.yml

@@ -9,42 +9,9 @@ on:
 env:
   BUILD_SUFFIX: -build-${{ github.run_id }}_${{ github.run_attempt }}
   DOCKER_METADATA_SET_OUTPUT_ENV: 'true'
-  ARCHIVESSPACE_RESOURCE_TOOLBAR_SHA256: 2feb4bf50a103574dc541d36dd237b5d49f6e663439dfe23314b89ccf964b83d
 
 jobs:
-  verify-upstream:
-    runs-on: ubuntu-24.04
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Verify upstream resource toolbar checksum
-        run: |
-          set -euo pipefail
-          version="$(sed -n 's/^ARG ARCHIVESSPACE_VERSION="\([^"]*\)"/\1/p' Dockerfile)"
-          repo_dir="$(mktemp -d)"
-          trap 'rm -rf "$repo_dir"' EXIT
-
-          if [[ -z "$version" ]]; then
-            echo "Could not determine ARCHIVESSPACE_VERSION from Dockerfile"
-            exit 1
-          fi
-
-          git init -q "$repo_dir"
-          git -C "$repo_dir" remote add origin https://github.com/archivesspace/archivesspace.git
-          git -C "$repo_dir" fetch --depth 1 origin "refs/tags/${version}:refs/tags/${version}"
-
-          actual="$(git -C "$repo_dir" show "${version}:frontend/app/views/resources/_toolbar.html.erb" | shasum -a 256 | awk '{print $1}')"
-
-          if [[ "$actual" != "$ARCHIVESSPACE_RESOURCE_TOOLBAR_SHA256" ]]; then
-            echo "Expected checksum: $ARCHIVESSPACE_RESOURCE_TOOLBAR_SHA256"
-            echo "Actual checksum:   $actual"
-            echo "Upstream file changed for ArchivesSpace ${version}"
-            exit 1
-          fi
-
   build:
-    needs: verify-upstream
     runs-on: ${{ matrix.runner }}
     outputs:
       image-arm64: ${{ steps.gen-output.outputs.image-arm64 }}
@@ -170,6 +137,16 @@ jobs:
           docker compose up --wait
           docker compose exec -u root app chown archivesspace:archivesspace artifacts
 
+      - name: Verify deployed resource toolbar matches upstream
+        run: |
+          set -euo pipefail
+          csum="$(docker compose exec -T app sh -lc "diff /opt/app/data/tmp/jetty-0_0_0_0-8080-frontend_war-_-any-*/webapp/WEB-INF/app/views/resources/_toolbar.html.erb /opt/app/plugins/local/frontend/views/resources/_toolbar.html.erb | sha256sum | cut -f1 -d' '")"
+
+          if [[ "$csum" != "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855" ]]; then
+            echo "resources/toolbar.html.erb checksum differs. We override this file in plugins so probably needs to be compared and updated" 
+            exit 1
+          fi
+
       - name: Query the ASpace home page
         run: |
           curl --location --fail --retry 30 --retry-all-errors http://localhost:8080/