Merge pull request #132 from BrianDeacon/master

Normalize the address for VaultConfig for consistent pathing downstream.

Author: steve-perkins

src/main/java/com/bettercloud/vault/VaultConfig.java

@@ -108,7 +108,10 @@ public VaultConfig engineVersion(final Integer globalEngineVersion) {
      * @return This object, with address populated, ready for additional builder-pattern method calls or else finalization with the build() method
      */
     public VaultConfig address(final String address) {
-        this.address = address;
+        this.address = address.trim();
+        if (this.address.endsWith("/")) {
+            this.address = this.address.substring(0, this.address.length() - 1);
+        }
         return this;
     }
 

src/test/java/com/bettercloud/vault/VaultConfigTests.java

@@ -96,6 +96,18 @@ public void testConfigConstructor() throws VaultException {
         assertEquals("token", config.getToken());
     }
 
+    /**
+     * Test creating a new <code>VaultConfig</code> via its constructor, ensuring that addresses are normalized to
+     * not have a trailing slash.
+     *
+     * @throws VaultException
+     */
+    @Test
+    public void testConfigConstructor_NormalizesAddress() throws VaultException {
+        final VaultConfig config = new VaultConfig().address("https://localhost:8200/").build();
+        assertEquals("https://localhost:8200", config.getAddress());
+    }
+
     /**
      * Test creating a new <code>VaultConfig</code> via its constructor, passing null address and token values AND
      * having them unavailable in the environment variables too.  This should cause initialization failure.