Skip to content

Commit 764219b

Browse files
committed
simplify clone of ArrayList
1 parent ff5f5b6 commit 764219b

3 files changed

Lines changed: 5 additions & 15 deletions

File tree

src/main/java/com/bettercloud/vault/api/mounts/MountConfig.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,19 +76,15 @@ public List<String> getAuditNonHmacRequestKeys() {
7676
if (auditNonHmacRequestKeys == null) {
7777
return null;
7878
} else {
79-
final List<String> clone = new ArrayList<>();
80-
clone.addAll(auditNonHmacRequestKeys);
81-
return clone;
79+
return new ArrayList<>(auditNonHmacRequestKeys);
8280
}
8381
}
8482

8583
public List<String> getAuditNonHmacResponseKeys() {
8684
if (auditNonHmacResponseKeys == null) {
8785
return null;
8886
} else {
89-
final List<String> clone = new ArrayList<>();
90-
clone.addAll(auditNonHmacResponseKeys);
91-
return clone;
87+
return new ArrayList<>(auditNonHmacResponseKeys);
9288
}
9389
}
9490

src/main/java/com/bettercloud/vault/api/mounts/MountPayload.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,19 +89,15 @@ public List<String> getAuditNonHmacRequestKeys() {
8989
if (auditNonHmacRequestKeys == null) {
9090
return null;
9191
} else {
92-
final List<String> clone = new ArrayList<>();
93-
clone.addAll(auditNonHmacRequestKeys);
94-
return clone;
92+
return new ArrayList<>(auditNonHmacRequestKeys);
9593
}
9694
}
9795

9896
public List<String> getAuditNonHmacResponseKeys() {
9997
if (auditNonHmacResponseKeys == null) {
10098
return null;
10199
} else {
102-
final List<String> clone = new ArrayList<>();
103-
clone.addAll(auditNonHmacResponseKeys);
104-
return clone;
100+
return new ArrayList<>(auditNonHmacResponseKeys);
105101
}
106102
}
107103

src/main/java/com/bettercloud/vault/api/pki/RoleOptions.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,7 @@ public List<String> getAllowedDomains() {
221221
if (allowedDomains == null) {
222222
return null;
223223
} else {
224-
final List<String> clone = new ArrayList<>();
225-
clone.addAll(allowedDomains);
226-
return clone;
224+
return new ArrayList<>(allowedDomains);
227225
}
228226
}
229227

0 commit comments

Comments
 (0)