Warn on using global namespace.

Test preventing empty namespaces.

Author: jarrodcodes

src/main/java/com/bettercloud/vault/VaultConfig.java

@@ -84,10 +84,11 @@ public VaultConfig environmentLoader(final EnvironmentLoader environmentLoader)
      * @return This object, with the namespace populated, ready for additional builder-pattern method calls or else
      * finalization with the build() method
      */
-    public VaultConfig nameSpace(final String nameSpace) {
-        assert !nameSpace.isEmpty();
-        this.nameSpace = nameSpace;
-        return this;
+    public VaultConfig nameSpace(final String nameSpace) throws VaultException {
+        if (nameSpace != null && !nameSpace.isEmpty()) {
+            this.nameSpace = nameSpace;
+            return this;
+        } else throw new VaultException("A namespace cannot be empty.");
     }
 
     /**

src/test/java/com/bettercloud/vault/VaultTests.java

@@ -29,7 +29,7 @@ public void testGlobalEngineVersionVaultConstructor() {
     }
 
     @Test
-    public void testNameSpaceProvidedVaultConstructor() {
+    public void testNameSpaceProvidedVaultConstructor() throws VaultException {
         VaultConfig vaultConfig = new VaultConfig().nameSpace("testNameSpace");
         Vault vault = new Vault(vaultConfig, 1);
         Assert.assertNotNull(vault);
@@ -39,19 +39,11 @@ public void testNameSpaceProvidedVaultConstructor() {
     public void testNameSpaceProvidedVaultConstructorCannotBeEmpty() {
         try {
             VaultConfig vaultConfig = new VaultConfig().nameSpace("");
-        } catch (AssertionError e) {
-            Assert.assertEquals(e.getClass(), AssertionError.class);
+        } catch (VaultException e) {
+            Assert.assertEquals(e.getMessage(), "A namespace cannot be empty.");
         }
     }
 
-
-    @Test
-    public void testNameSpaceNotProvidedVaultConstructor() {
-        VaultConfig vaultConfig = new VaultConfig().nameSpace(null);
-        Vault vault = new Vault(vaultConfig, 1);
-        Assert.assertNotNull(vault);
-    }
-
     @Test(expected = IllegalArgumentException.class)
     public void testInvalidGlobalEngineVersionVaultConstructor() {
         VaultConfig vaultConfig = new VaultConfig();