Extract IsURL to utils

Author: zerebos

cmd/plugins.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/betterdiscord/cli/internal/betterdiscord"
 	"github.com/betterdiscord/cli/internal/output"
+	"github.com/betterdiscord/cli/internal/utils"
 	"github.com/spf13/cobra"
 )
 
@@ -86,7 +87,7 @@ var pluginsInstallCmd = &cobra.Command{
 	RunE: func(cmd *cobra.Command, args []string) error {
 		identifier := args[0]
 		// Check if not a URL and already installed
-		if !isURL(identifier) {
+		if !utils.IsURL(identifier) {
 			if existing := betterdiscord.FindAddon(betterdiscord.AddonPlugin, identifier); existing != nil {
 				name := existing.Meta.Name
 				if name == "" {
@@ -140,7 +141,7 @@ var pluginsUpdateCmd = &cobra.Command{
 		checkOnly, _ := cmd.Flags().GetBool("check")
 
 		// For non-URL identifiers, check if update is available
-		if !isURL(identifier) {
+		if !utils.IsURL(identifier) {
 			existing := betterdiscord.FindAddon(betterdiscord.AddonPlugin, identifier)
 			if existing == nil {
 				output.Printf("❌ Plugin '%s' is not installed.\n", identifier)

cmd/root.go

@@ -3,7 +3,6 @@ package cmd
 import (
 	"fmt"
 	"io"
-	"net/url"
 	"os"
 	"strings"
 
@@ -45,12 +44,6 @@ func IsDebugBuild() bool {
 	return buildVersion == "dev"
 }
 
-// isURL checks if a string is a valid URL
-func isURL(input string) bool {
-	parsed, err := url.Parse(input)
-	return err == nil && parsed.Scheme != "" && parsed.Host != ""
-}
-
 var silent bool
 
 func init() {

cmd/themes.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/betterdiscord/cli/internal/betterdiscord"
 	"github.com/betterdiscord/cli/internal/output"
+	"github.com/betterdiscord/cli/internal/utils"
 	"github.com/spf13/cobra"
 )
 
@@ -75,7 +76,7 @@ var themesInstallCmd = &cobra.Command{
 	RunE: func(cmd *cobra.Command, args []string) error {
 		identifier := args[0]
 		// Check if not a URL and already installed
-		if !isURL(identifier) {
+		if !utils.IsURL(identifier) {
 			if existing := betterdiscord.FindAddon(betterdiscord.AddonTheme, identifier); existing != nil {
 				name := existing.Meta.Name
 				if name == "" {
@@ -129,7 +130,7 @@ var themesUpdateCmd = &cobra.Command{
 		checkOnly, _ := cmd.Flags().GetBool("check")
 
 		// For non-URL identifiers, check if update is available
-		if !isURL(identifier) {
+		if !utils.IsURL(identifier) {
 			existing := betterdiscord.FindAddon(betterdiscord.AddonTheme, identifier)
 			if existing == nil {
 				output.Printf("❌ Theme '%s' is not installed.\n", identifier)

internal/betterdiscord/addons.go

@@ -119,7 +119,7 @@ func InstallAddon(kind AddonKind, identifier string) (*ResolvedAddon, error) {
 	resolved := &ResolvedAddon{}
 
 	// Case 1: Direct URL
-	if isURL(identifier) {
+	if utils.IsURL(identifier) {
 		dest, err := downloadAddon(kind, dir, identifier)
 		if err != nil {
 			return nil, err
@@ -261,11 +261,6 @@ func candidateFilenames(kind AddonKind, identifier string) []string {
 	return out
 }
 
-func isURL(input string) bool {
-	parsed, err := url.Parse(input)
-	return err == nil && parsed.Scheme != "" && parsed.Host != ""
-}
-
 // LogLocalAddonInfo prints detailed information about a locally installed addon.
 func LogLocalAddonInfo(entry *AddonEntry) {
 	name := entry.Meta.Name

internal/utils/strings.go

@@ -0,0 +1,9 @@
+package utils
+
+import "net/url"
+
+// IsURL checks if a string is a valid URL
+func IsURL(input string) bool {
+	parsed, err := url.Parse(input)
+	return err == nil && parsed.Scheme != "" && parsed.Host != ""
+}