fix: use experiment-wide min/max for eFP colour scale; before was using group max and heat scale max was wrong

Author: VinLau

Eplant/views/eFP/Viewer/index.tsx

@@ -407,7 +407,7 @@ export default class EFPViewer
               borderRadius: 1,
             })}
           >
-            {activeData.viewData[activeViewIndex].supported ? (
+            {sortedViewData[activeViewIndex].supported ? (
               <>
                 <div>
                   <Typography
@@ -422,9 +422,9 @@ export default class EFPViewer
                     {geneticElement?.id}
                   </Typography>
 
-                  {activeData.views[activeViewIndex].name !== 'cellEFP' && (
+                  {sortedViews[activeViewIndex].name !== 'cellEFP' && (
                     <GeneDistributionChart
-                      data={{ ...activeData.viewData[activeViewIndex] }}
+                      data={{ ...sortedViewData[activeViewIndex] }}
                     />
                   )}
                 </div>
@@ -447,7 +447,7 @@ export default class EFPViewer
                     zIndex: 10,
                   })}
                   data={{
-                    ...activeData.viewData[activeViewIndex],
+                    ...sortedViewData[activeViewIndex],
                   }}
                   maskThreshold={state.maskThreshold}
                   colorMode={state.colorMode}

Eplant/views/eFP/svg.tsx

@@ -8,7 +8,6 @@ import { Theme, useTheme } from '@mui/material'
 import {
   ColorMode,
   EFPData,
-  EFPGroup,
   EFPId,
   EFPSampleData,
   EFPSVGCache,
@@ -90,7 +89,7 @@ export const useEFPSVG = (
 
 export function getColor(
   value: number,
-  group: EFPSampleData | EFPGroup,
+  group: EFPSampleData,
   control: number,
   theme: Theme,
   colorMode: ColorMode,
@@ -124,12 +123,13 @@ export function getColor(
 
 export function useStyles(
   id: string,
-  { groups, control }: EFPData,
+  data: EFPData,
   colorMode: ColorMode,
   maskThreshold?: number,
   maskingEnabled?: boolean
 ) {
   const theme = useTheme()
+  const { groups, control } = data
   const samples = groups
     .flatMap((group) =>
       group.tissues.map(
@@ -138,7 +138,7 @@ export function useStyles(
             tissue.id
           } { fill: ${getColor(
             tissue.mean,
-            group,
+            data,
             control ?? 1,
             theme,
             colorMode,