Skip to content

Commit eb1385f

Browse files
authored
Remove unnecessary ESLint prettier config and plugin (#23)
You don't need an ESLint prettier config and plugin if you just run prettier which if issues exist, should be caught via the GitHub Actions.
1 parent 86129c3 commit eb1385f

6 files changed

Lines changed: 117 additions & 423 deletions

File tree

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,22 @@ name: Code Quality Assurance - JavaScript
66
on:
77
push:
88
branches: [master]
9+
paths:
10+
- ".github/workflows/code-qa-js.yaml"
11+
- ".prettier*"
12+
- "**/*.css"
13+
- "**/*.html"
14+
- "**/*.js"
15+
- "**/*.json"
916
pull_request:
1017
branches: [master]
18+
paths:
19+
- ".github/workflows/code-qa-js.yaml"
20+
- ".prettier*"
21+
- "**/*.css"
22+
- "**/*.html"
23+
- "**/*.js"
24+
- "**/*.json"
1125

1226
permissions:
1327
contents: read
@@ -28,7 +42,7 @@ jobs:
2842
with:
2943
node-version: ${{ matrix.node-version }}
3044
- name: Cache Node.js modules
31-
uses: actions/cache@v4
45+
uses: actions/cache@v5
3246
with:
3347
path: ~/.npm
3448
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646

4747
steps:
4848
- name: Checkout repository
49-
uses: actions/checkout@v5
49+
uses: actions/checkout@v6
5050

5151
# Initializes the CodeQL tools for scanning.
5252
- name: Initialize CodeQL

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ This will display the visualized and coloured tissue expression data within the
5050

5151
| Chrome | Firefox | Edge | Safari | Opera | Tor | Mobile |
5252
| ------ | ------- | ---- | ------ | ----- | --- | ------ |
53-
||||||||
53+
| | | | | | | |
5454

5555
## Known issues
5656

eslint.config.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
const eslintPluginPrettier = require("eslint-plugin-prettier");
2-
31
module.exports = [
42
{
53
ignores: ["**/*.min.js", "eslint.config.js", "node_modules/**/*"],
@@ -13,9 +11,6 @@ module.exports = [
1311
},
1412
},
1513
},
16-
plugins: {
17-
prettier: eslintPluginPrettier,
18-
},
1914
rules: {
2015
indent: ["error", "tab"],
2116
"no-console": "off",
@@ -24,7 +19,6 @@ module.exports = [
2419
"no-restricted-syntax": "off",
2520
"no-unused-vars": ["error", { argsIgnorePattern: "^_", varsIgnorePattern: "^_" }],
2621
"no-use-before-define": "off",
27-
"prettier/prettier": "error",
2822
semi: ["error", "always"],
2923
},
3024
},

0 commit comments

Comments
 (0)