refactor: modernize type annotations and improve code style

- Replace legacy typing imports with modern Python 3.10+ syntax (Union -> |, Optional -> |, List -> list)
- Update AsyncGenerator type hints to use collections.abc import
- Add comprehensive docstring to settings.py explaining configuration priority and validation
- Implement typed dependency annotations using Annotated for better type safety
- Remove unused parameters and imports across multiple modules
- Standardize function signatures and return type annotations

Author: Bit-Maximum

README.md

@@ -66,12 +66,12 @@ src
 This application can be configured with environment variables.
 
 You can create `.env` file in the root directory and place all
-environment variables here. 
+environment variables here.
 
 All environment variables should start with "FASTAPI_SUPER_TEMPLATE_" prefix.
 
 For example if you see in your "FastAPI_super_template/settings.py" a variable named like
-`random_parameter`, you should provide the "FASTAPI_SUPER_TEMPLATE_RANDOM_PARAMETER" 
+`random_parameter`, you should provide the "FASTAPI_SUPER_TEMPLATE_RANDOM_PARAMETER"
 variable to configure the value. This behaviour can be changed by overriding `env_prefix` property
 in `FastAPI_super_template.settings.Settings.Config`.
 
@@ -83,9 +83,9 @@ FASTAPI_SUPER_TEMPLATE_ENVIRONMENT="dev"
 ```
 
 You can read more about BaseSettings class here: https://pydantic-docs.helpmanual.io/usage/settings/
-## OpenTelemetry 
+## OpenTelemetry
 
-If you want to start your project with OpenTelemetry collector 
+If you want to start your project with OpenTelemetry collector
 you can add `-f ./deploy/docker-compose.otlp.yml` to your docker command.
 
 Like this:
@@ -94,11 +94,11 @@ Like this:
 docker-compose -f docker-compose.yml -f deploy/docker-compose.otlp.yml --project-directory . up
 ```
 
-This command will start OpenTelemetry collector and jaeger. 
+This command will start OpenTelemetry collector and jaeger.
 After sending a requests you can see traces in jaeger's UI
 at http://localhost:16686/.
 
-This docker configuration is not supposed to be used in production. 
+This docker configuration is not supposed to be used in production.
 It's only for demo purpose.
 
 You can read more about OpenTelemetry here: https://opentelemetry.io/

deploy/docker-compose.otlp.yml

@@ -20,4 +20,3 @@ services:
     ports:
       # Jaeger UI
       - 16686:16686
-

src/gunicorn_runner.py

@@ -7,7 +7,7 @@
 try:
     import uvloop  # (Found nested import)
 except ImportError:
-    uvloop = None  # type: ignore  # (variables overlap)
+    uvloop = None
 
 
 class UvicornWorker(BaseUvicornWorker):
@@ -42,7 +42,7 @@ def __init__(  # (Too many args)
         host: str,
         port: int,
         workers: int,
-        **kwargs: Any,
+        **kwargs: dict[str, Any],
     ) -> None:
         self.options = {
             "bind": f"{host}:{port}",

src/log.py

@@ -1,6 +1,6 @@
 import logging
 import sys
-from typing import Any, Union
+from typing import Any
 
 from loguru import logger
 from opentelemetry.trace import INVALID_SPAN, INVALID_SPAN_CONTEXT, get_current_span
@@ -26,14 +26,14 @@ def emit(self, record: logging.LogRecord) -> None:  # pragma: no cover
         :param record: record to log.
         """
         try:
-            level: Union[str, int] = logger.level(record.levelname).name
+            level: str | int = logger.level(record.levelname).name
         except ValueError:
             level = record.levelno
 
         # Find caller from where originated the logged message
         frame, depth = logging.currentframe(), 2
         while frame.f_code.co_filename == logging.__file__:
-            frame = frame.f_back  # type: ignore
+            frame = frame.f_back
             depth += 1
 
         logger.opt(depth=depth, exception=record.exc_info).log(
@@ -97,5 +97,5 @@ def configure_logging() -> None:  # pragma: no cover
     logger.add(
         sys.stdout,
         level=settings.log_level.value,
-        format=record_formatter,  # type: ignore
+        format=record_formatter,
     )

src/services/kafka/dependencies.py

@@ -1,10 +1,13 @@
+from typing import Annotated
+
 from aiokafka import AIOKafkaProducer
 from fastapi import Request
 from taskiq import TaskiqDepends
+from taskiq_dependencies import Depends
 
 
 def get_kafka_producer(
-    request: Request = TaskiqDepends(),
+    request: Annotated[Request, Depends(TaskiqDepends)],
 ) -> AIOKafkaProducer:  # pragma: no cover
     """
     Returns kafka producer.

src/services/rabbit/dependencies.py

@@ -1,11 +1,14 @@
+from typing import Annotated
+
 from aio_pika import Channel
 from aio_pika.pool import Pool
 from fastapi import Request
 from taskiq import TaskiqDepends
+from taskiq_dependencies import Depends
 
 
 def get_rmq_channel_pool(
-    request: Request = TaskiqDepends(),
+    request: Annotated[Request, Depends(TaskiqDepends)],
 ) -> Pool[Channel]:  # pragma: no cover
     """
     Get channel pool from the state.

src/services/redis/dependency.py

@@ -1,13 +1,15 @@
-from typing import AsyncGenerator
+from collections.abc import AsyncGenerator
+from typing import Annotated
 
 from redis.asyncio import Redis
 from starlette.requests import Request
 from taskiq import TaskiqDepends
+from taskiq_dependencies import Depends
 
 
 async def get_redis_pool(
-    request: Request = TaskiqDepends(),
-) -> AsyncGenerator[Redis, None]:  # pragma: no cover
+    request: Annotated[Request, Depends(TaskiqDepends)],
+) -> AsyncGenerator[Redis]:  # pragma: no cover
     """
     Returns connection pool.
 

src/settings.py

@@ -1,7 +1,28 @@
+"""File with environment variables and general configuration logic.
+
+`SECRET_KEY`, `ENVIRONMENT` etc. map to env variables with the same names.
+
+Pydantic priority ordering:
+
+1. (Most important, will overwrite everything) - environment variables
+2. `.env` file in root folder of project
+3. Default values
+
+For project name, version, description we use pyproject.toml
+For the rest, we use file `.env` (gitignored), see `.env.example`
+
+`SQLALCHEMY_DATABASE_URI` is  meant to be validated at the runtime,
+do not change unless you know what are you doing.
+The validator is to build full URI (TCP protocol) to databases to avoid typo bugs.
+
+See https://pydantic-docs.helpmanual.io/usage/settings/
+
+Note, complex types like lists are read as json-encoded strings.
+"""
+
 import enum
 from pathlib import Path
 from tempfile import gettempdir
-from typing import List, Optional
 
 from pydantic_settings import BaseSettings, SettingsConfigDict
 from yarl import URL
@@ -43,15 +64,15 @@ class Settings(BaseSettings):
     # Variables for Redis
     redis_host: str = "src-redis"
     redis_port: int = 6379
-    redis_user: Optional[str] = None
-    redis_pass: Optional[str] = None
-    redis_base: Optional[int] = None
+    redis_user: str | None = None
+    redis_pass: str | None = None
+    redis_base: int | None = None
 
     # Variables for RabbitMQ
     rabbit_host: str = "src-rmq"
     rabbit_port: int = 5672
     rabbit_user: str = "guest"
-    rabbit_pass: str = "guest"
+    rabbit_pass: str
     rabbit_vhost: str = "/"
 
     rabbit_pool_size: int = 2
@@ -62,14 +83,14 @@ class Settings(BaseSettings):
     prometheus_dir: Path = TEMP_DIR / "prom"
 
     # Sentry's configuration.
-    sentry_dsn: Optional[str] = None
+    sentry_dsn: str | None = None
     sentry_sample_rate: float = 1.0
 
     # Grpc endpoint for opentelemetry.
     # E.G. http://localhost:4317
-    opentelemetry_endpoint: Optional[str] = None
+    opentelemetry_endpoint: str | None = None
 
-    kafka_bootstrap_servers: List[str] = ["src-kafka:9092"]
+    kafka_bootstrap_servers: list[str] = ["src-kafka:9092"]
 
     @property
     def redis_url(self) -> URL: