fix(abstract-utxo): move toCanonicalTransactionRecipient to parseTransaction

Move toCanonicalTransactionRecipient out of the AbstractUtxoCoin class into
the parseTransaction module where it's used, removing it from the public API.

Issue: BTC-2962

Co-authored-by: llm-git <llm-git@ttll.de>

Author: OttoAllmendinger

modules/abstract-utxo/src/abstractUtxoCoin.ts

@@ -592,19 +592,6 @@ export abstract class AbstractUtxoCoin
     return this.decodeTransaction(string, decodeWith);
   }
 
-  toCanonicalTransactionRecipient(output: { valueString: string; address?: string }): {
-    amount: bigint;
-    address: string;
-  } {
-    const amount = BigInt(output.valueString);
-    assertValidTransactionRecipient({ amount, address: output.address });
-    assert(output.address, 'address is required');
-    if (isScriptRecipient(output.address)) {
-      return { amount, address: output.address };
-    }
-    return { amount, address: this.canonicalAddress(output.address) };
-  }
-
   /**
    * Extract and fill transaction details such as internal/change spend, external spend (explicit vs. implicit), etc.
    * @param params

modules/abstract-utxo/src/transaction/fixedScript/parseTransaction.ts

@@ -8,7 +8,12 @@ import type { AbstractUtxoCoin, ParseTransactionOptions } from '../../abstractUt
 import type { FixedScriptWalletOutput, Output, ParsedTransaction } from '../types';
 import { fetchKeychains, getKeySignatures, toKeychainTriple, UtxoKeychain, UtxoNamedKeychains } from '../../keychains';
 import { ComparableOutput, outputDifference } from '../outputDifference';
-import { fromExtendedAddressFormatToScript, toExtendedAddressFormat } from '../recipient';
+import {
+  assertValidTransactionRecipient,
+  fromExtendedAddressFormatToScript,
+  isScriptRecipient,
+  toExtendedAddressFormat,
+} from '../recipient';
 
 import type { TransactionExplanation } from './explainTransaction';
 import { CustomChangeOptions, parseOutput } from './parseOutput';
@@ -17,6 +22,22 @@ export type ComparableOutputWithExternal<TValue> = ComparableOutput<TValue> & {
   external: boolean | undefined;
 };
 
+function toCanonicalTransactionRecipient(
+  coin: AbstractUtxoCoin,
+  output: { valueString: string; address?: string }
+): {
+  amount: bigint;
+  address: string;
+} {
+  const amount = BigInt(output.valueString);
+  assertValidTransactionRecipient({ amount, address: output.address });
+  assert(output.address, 'address is required');
+  if (isScriptRecipient(output.address)) {
+    return { amount, address: output.address };
+  }
+  return { amount, address: coin.canonicalAddress(output.address) };
+}
+
 async function parseRbfTransaction<TNumber extends bigint | number>(
   coin: AbstractUtxoCoin,
   params: ParseTransactionOptions<TNumber>
@@ -33,7 +54,7 @@ async function parseRbfTransaction<TNumber extends bigint | number>(
       if (output.wallet === wallet.id()) {
         return [];
       }
-      return [coin.toCanonicalTransactionRecipient(output)];
+      return [toCanonicalTransactionRecipient(coin, output)];
     }
   );