feat(abstract-utxo): simplify interface, use wasm types

Simplify FixedScriptAddressCoinSpecific by removing redeem and witness
script fields, which are no longer needed with the WASM implementation.

Also update parameter type to use WalletKeysArg from wasm-utxo instead
of the deprecated bitgo.RootWalletKeys.

Issue: BTC-2916

Co-authored-by: llm-git <llm-git@ttll.de>

Author: OttoAllmendinger

modules/abstract-utxo/src/address/fixedScript.ts

@@ -12,18 +12,15 @@ import {
   isTriple,
   Triple,
 } from '@bitgo/sdk-core';
-import { bitgo } from '@bitgo/utxo-lib';
 import { fixedScriptWallet } from '@bitgo/wasm-utxo';
 
-import { getNetworkFromCoinName, UtxoCoinName } from '../names';
+import { UtxoCoinName } from '../names';
 
 type ScriptType2Of3 = fixedScriptWallet.OutputScriptType;
 type ChainCode = fixedScriptWallet.ChainCode;
 
 export interface FixedScriptAddressCoinSpecific {
   outputScript?: string;
-  redeemScript?: string;
-  witnessScript?: string;
 }
 
 export interface GenerateAddressOptions {
@@ -43,18 +40,24 @@ function supportsAddressType(coinName: UtxoCoinName, addressType: ScriptType2Of3
   return fixedScriptWallet.supportsScriptType(coinName, addressType);
 }
 
+/**
+ * Normalize script type aliases. "p2tr" is an alias for "p2trLegacy".
+ */
+function normalizeScriptType(scriptType: ScriptType2Of3 | 'p2tr'): ScriptType2Of3 {
+  return scriptType === 'p2tr' ? 'p2trLegacy' : scriptType;
+}
+
 export function generateAddressWithChainAndIndex(
   coinName: UtxoCoinName,
-  keychains: fixedScriptWallet.RootWalletKeys | bitgo.RootWalletKeys | Triple<string>,
+  keychains: fixedScriptWallet.WalletKeysArg | Triple<string>,
   chain: ChainCode,
   index: number,
   format: CreateAddressFormat | undefined
 ): string {
   // Convert CreateAddressFormat to AddressFormat for wasm-utxo
   // 'base58' -> 'default', 'cashaddr' -> 'cashaddr'
   const wasmFormat = format === 'base58' ? 'default' : format;
-  const network = getNetworkFromCoinName(coinName);
-  return fixedScriptWallet.address(keychains, chain, index, network, wasmFormat);
+  return fixedScriptWallet.address(keychains, chain, index, coinName, wasmFormat);
 }
 
 /**
@@ -95,7 +98,7 @@ export function generateAddress(coinName: UtxoCoinName, params: GenerateFixedScr
     }
   }
 
-  const addressType = params.addressType || convertFlagsToAddressType();
+  const addressType = normalizeScriptType(params.addressType || convertFlagsToAddressType());
 
   if (addressType !== fixedScriptWallet.ChainCode.scriptType(derivationChain)) {
     throw new AddressTypeChainMismatchError(addressType, derivationChain);
@@ -110,6 +113,7 @@ export function generateAddress(coinName: UtxoCoinName, params: GenerateFixedScr
       case 'p2wsh':
         throw new P2wshUnsupportedError();
       case 'p2tr':
+      case 'p2trLegacy':
         throw new P2trUnsupportedError();
       case 'p2trMusig2':
         throw new P2trMusig2UnsupportedError();