feat(abstract-utxo): optimize test suite with min coin selection

Use a minimal subset of test coins (BTC, BCH, ZEC) that provides full
feature coverage while significantly reducing test runtime.

Refactor test utilities to support this optimization:
- Add `getMinUtxoCoins()` helper function
- Move shared code like `getScriptTypes()` and `TxFormat` to utilities
- Improve validation logic for different script types

Issue: BTC-2866

Co-authored-by: llm-git <llm-git@ttll.de>

Author: OttoAllmendinger

modules/abstract-utxo/test/unit/prebuildAndSign.ts

@@ -1,17 +1,25 @@
 import * as assert from 'assert';
 
 import * as utxolib from '@bitgo/utxo-lib';
+import { testutil } from '@bitgo/utxo-lib';
 import nock = require('nock');
 import { common, HalfSignedUtxoTransaction, Wallet } from '@bitgo/sdk-core';
 import { getSeed } from '@bitgo/sdk-test';
 
-import { AbstractUtxoCoin, getReplayProtectionAddresses } from '../../src';
-import { getMainnetCoinName } from '../../src/names';
+import { AbstractUtxoCoin } from '../../src';
 
-import { defaultBitGo, encryptKeychain, getDefaultWalletKeys, getUtxoWallet, keychainsBase58, utxoCoins } from './util';
+import {
+  defaultBitGo,
+  encryptKeychain,
+  getDefaultWalletKeys,
+  getMinUtxoCoins,
+  getUtxoWallet,
+  keychainsBase58,
+  getScriptTypes,
+  TxFormat,
+} from './util';
 
-const txFormats = ['legacy', 'psbt'] as const;
-export type TxFormat = (typeof txFormats)[number];
+type ScriptType = testutil.InputScriptType;
 
 type KeyDoc = {
   id: string;
@@ -24,9 +32,6 @@ type KeyDoc = {
 const walletPassphrase = 'gabagool';
 const webauthnWalletPassPhrase = 'just the gabagool';
 
-const scriptTypes = [...utxolib.bitgo.outputScripts.scriptTypes2Of3, 'taprootKeyPathSpend', 'p2shP2pk'] as const;
-export type ScriptType = (typeof scriptTypes)[number];
-
 type Input = {
   scriptType: ScriptType;
   value: bigint;
@@ -35,15 +40,16 @@ type Input = {
 function assertSignable(psbtHex: string, inputScripts: ScriptType[], network: utxolib.Network): void {
   const psbt = utxolib.bitgo.createPsbtFromHex(psbtHex, network);
   // Make sure that you can sign with bitgo key and extract the transaction
-  // No signatures should be present if it's a p2shP2pk input
-  if (!inputScripts.includes('p2shP2pk')) {
-    const key = inputScripts.includes('p2trMusig2') ? rootWalletKeys.backup : rootWalletKeys.bitgo;
-    psbt.signAllInputsHD(key, { deterministic: true });
-    psbt.validateSignaturesOfAllInputs();
-    psbt.finalizeAllInputs();
-    const tx = psbt.extractTransaction();
-    assert.ok(tx);
+  // Skip validation for p2shP2pk (single-sig replay protection) and taprootKeyPathSpend (requires musig2 nonce exchange)
+  if (inputScripts.includes('p2shP2pk') || inputScripts.includes('taprootKeyPathSpend')) {
+    return;
   }
+  const key = inputScripts.includes('p2trMusig2') ? rootWalletKeys.backup : rootWalletKeys.bitgo;
+  psbt.signAllInputsHD(key, { deterministic: true });
+  psbt.validateSignaturesOfAllInputs();
+  psbt.finalizeAllInputs();
+  const tx = psbt.extractTransaction();
+  assert.ok(tx);
 }
 
 // Build the key objects
@@ -295,27 +301,6 @@ function run(coin: AbstractUtxoCoin, inputScripts: ScriptType[], txFormat: TxFor
   });
 }
 
-utxoCoins
-  .filter((coin) => getMainnetCoinName(coin.name) !== 'bsv')
-  .forEach((coin) => {
-    scriptTypes
-      // Don't iterate over p2shP2pk - in no scenario would a wallet spend two p2shP2pk inputs as these
-      // are single signature inputs that are used for replay protection and are added to the transaction
-      // by our system from a separate wallet. We do run tests below where one of the inputs is a p2shP2pk and
-      // the other is an input spent by the user.
-      .filter((scriptType) => scriptType !== 'p2shP2pk')
-      .forEach((inputScript) => {
-        const inputScriptCleaned = (
-          inputScript === 'taprootKeyPathSpend' ? 'p2trMusig2' : inputScript
-        ) as utxolib.bitgo.outputScripts.ScriptType2Of3;
-
-        if (!coin.supportsAddressType(inputScriptCleaned)) {
-          return;
-        }
-
-        run(coin, [inputScript, inputScript], 'psbt');
-        if (getReplayProtectionAddresses(coin.name).length) {
-          run(coin, ['p2shP2pk', inputScript], 'psbt');
-        }
-      });
-  });
+getMinUtxoCoins().forEach((coin) => {
+  run(coin, getScriptTypes(coin, 'psbt'), 'psbt');
+});

modules/abstract-utxo/test/unit/transaction.ts

@@ -14,12 +14,11 @@ import {
   WalletSignTransactionOptions,
 } from '@bitgo/sdk-core';
 
-import { AbstractUtxoCoin, getReplayProtectionAddresses, generateAddress, getReplayProtectionPubkeys } from '../../src';
+import { AbstractUtxoCoin, generateAddress, getReplayProtectionPubkeys } from '../../src';
 import { SdkBackend } from '../../src/transaction/types';
 import type { Unspent, WalletUnspent } from '../../src/unspent';
 
 import {
-  utxoCoins,
   shouldEqualJSON,
   getFixture,
   getUtxoWallet,
@@ -32,6 +31,8 @@ import {
   getDefaultWalletKeys,
   getWalletKeys,
   defaultBitGo,
+  getMinUtxoCoins,
+  getScriptTypes,
 } from './util';
 
 function run<TNumber extends number | bigint = number>(
@@ -406,33 +407,14 @@ function run<TNumber extends number | bigint = number>(
   });
 }
 
-function getScriptTypes(coin: AbstractUtxoCoin, txFormat: 'legacy' | 'psbt') {
-  return (['p2shP2pk', 'p2sh', 'p2shP2wsh', 'p2wsh', 'p2tr', 'p2trMusig2', 'taprootKeyPathSpend'] as const).filter(
-    (t) => {
-      if (t === 'p2shP2pk') {
-        return getReplayProtectionAddresses(coin.name).length > 0;
-      }
-      if (txFormat === 'legacy') {
-        if (t === 'p2tr' || t === 'p2trMusig2' || t === 'taprootKeyPathSpend') {
-          return false;
-        }
-      }
-      if (t === 'taprootKeyPathSpend') {
-        return coin.supportsAddressType('p2trMusig2');
-      }
-      return coin.supportsAddressType(t);
-    }
-  );
-}
-
 function runTestForCoin(coin: AbstractUtxoCoin) {
   (['legacy', 'psbt'] as const).forEach((txFormat) => {
     run(coin, getScriptTypes(coin, txFormat), txFormat, { decodeWith: 'wasm-utxo' });
   });
 }
 
 describe('Transaction Suite', function () {
-  utxoCoins.forEach((coin) => {
+  getMinUtxoCoins().forEach((coin) => {
     describe(`${coin.getChain()}`, function () {
       runTestForCoin(coin);
     });

modules/abstract-utxo/test/unit/util/utxoCoins.ts

@@ -24,6 +24,7 @@ import {
   Tdoge,
   Zec,
   Tzec,
+  getReplayProtectionAddresses,
 } from '../../../src';
 
 export const defaultBitGo = TestBitGo.decorate(BitGoAPI, { env: 'mock' });
@@ -65,6 +66,21 @@ function getUtxoCoins(bitgo: BitGoAPI = defaultBitGo): AbstractUtxoCoin[] {
 
 export const utxoCoins = getUtxoCoins();
 
+/**
+ * Minimal subset of coins for comprehensive test coverage.
+ * - btc: Full feature set (segwit, taproot, musig2)
+ * - bch: replay protection addresses
+ * - zec: special transaction format (Overwinter/Sapling)
+ */
+export const minUtxoCoinNames = ['btc', 'bch', 'zec'] as const;
+
+/**
+ * Get minimal set of coins for testing. Covers ~99% of feature paths.
+ */
+export function getMinUtxoCoins(): AbstractUtxoCoin[] {
+  return minUtxoCoinNames.map(getUtxoCoin);
+}
+
 export function getUtxoCoin(name: string): AbstractUtxoCoin {
   for (const c of utxoCoins) {
     if (c.getChain() === name) {
@@ -82,3 +98,24 @@ export function getUtxoCoinForNetwork(n: utxolib.Network): AbstractUtxoCoin {
   }
   throw new Error(`no coin for network ${utxolib.getNetworkName(n)}`);
 }
+
+export type TxFormat = 'legacy' | 'psbt';
+
+export function getScriptTypes(coin: AbstractUtxoCoin, txFormat: TxFormat): utxolib.testutil.InputScriptType[] {
+  return (['p2shP2pk', 'p2sh', 'p2shP2wsh', 'p2wsh', 'p2tr', 'p2trMusig2', 'taprootKeyPathSpend'] as const).filter(
+    (t) => {
+      if (t === 'p2shP2pk') {
+        return getReplayProtectionAddresses(coin.name).length > 0;
+      }
+      if (txFormat === 'legacy') {
+        if (t === 'p2tr' || t === 'p2trMusig2' || t === 'taprootKeyPathSpend') {
+          return false;
+        }
+      }
+      if (t === 'taprootKeyPathSpend') {
+        return coin.supportsAddressType('p2trMusig2');
+      }
+      return coin.supportsAddressType(t);
+    }
+  );
+}