Fix resharing and webhooks tests and API

Summary:
Fixed two issues:

1) The webhooks removeWebhook API call returns the number removed, not the
walletId or other properties.

2) The API has been updated recently to support "resharing", which is when you
need to share the same wallet with someone again because they have lost or
reset their password. To do this, you must set "reshare=true" when sharing the
wallet with them. Older API calls that implicitly relied on resharing now must
be updated to set reshare=true, or they will fail. This commit fixes some tests
that are actually resharing, and thus need to set reshare=true. Also, a check
on the type of the reshare property is added to the shareWallet method.

Reviewers: benchan

Reviewed By: benchan

Subscribers: ben

Differential Revision: https://phabricator.bitgo.com/D801

Author: Ryan X. Charles

src/wallet.js

@@ -661,6 +661,10 @@ Wallet.prototype.shareWallet = function(params, callback) {
   params = params || {};
   common.validateParams(params, ['email', 'permissions'], ['walletPassphrase', 'message'], callback);
 
+  if (params.reshare !== undefined && typeof(params.reshare) != 'boolean') {
+    throw new Error('Expected reshare to be a boolean.');
+  }
+
   if (params.skipKeychain !== undefined && typeof(params.skipKeychain) != 'boolean') {
     throw new Error('Expected skipKeychain to be a boolean. ');
   }
@@ -706,6 +710,7 @@ Wallet.prototype.shareWallet = function(params, callback) {
     var options = {
       user: sharing.userId,
       permissions: params.permissions,
+      reshare: params.reshare,
       message: params.message
     };
     if (sharedKeychain) {

test/wallet.js

@@ -158,6 +158,7 @@ describe('Wallet', function() {
         return wallet1.shareWallet({
           email: TestBitGo.TEST_SHARED_KEY_USER,
           walletPassphrase: TestBitGo.TEST_WALLET1_PASSCODE,
+          reshare: true, // for tests, we have actually already shared the wallet, and thus must set reshare
           permissions: 'view'
         });
       })
@@ -184,6 +185,7 @@ describe('Wallet', function() {
         return wallet2.shareWallet({
           email: TestBitGo.TEST_SHARED_KEY_USER,
           walletPassphrase: TestBitGo.TEST_WALLET2_PASSCODE,
+          reshare: true, // for tests, we have actually already shared the wallet, and thus must set reshare
           permissions: 'view,spend'
         });
       })
@@ -329,6 +331,7 @@ describe('Wallet', function() {
         return wallet2.shareWallet({
           email: TestBitGo.TEST_SHARED_KEY_USER,
           skipKeychain: true,
+          reshare: true, // for tests, we have actually already shared the wallet, and thus must set reshare
           permissions: 'view,spend'
         });
       })

test/webhooks.js

@@ -148,12 +148,8 @@ describe('Webhooks', function() {
       var type = 'transaction';
       wallet.removeWebhook({url: url, type: type})
       .then(function (result) {
-        result.should.have.property('walletId');
-        result.should.have.property('url');
-        result.should.have.property('type');
-        result.walletId.should.eql(wallet.id());
-        result.url.should.eql(url);
-        result.type.should.eql(type);
+        result.should.have.property('removed');
+        result.removed.should.equal(1);
 
         return wallet.listWebhooks();
       })