refactor(wasm-utxo)!: extract ITransactionCommon interface

BREAKING CHANGE: version and lockTime are now methods instead of
getters. Update code from `tx.version` to `tx.version()` and
`tx.lockTime` to `tx.lockTime()`.

Extract shared transaction and PSBT properties into ITransactionCommon
interface to reduce duplication between ITransaction and IPsbt.
Convert version and lockTime from getters to methods for consistency
with other interface methods.

Issue: BTC-2976

Co-authored-by: llm-git <llm-git@ttll.de>

Author: OttoAllmendinger

packages/wasm-utxo/js/index.ts

@@ -116,5 +116,11 @@ declare module "./wasm/wasm_utxo.js" {
 export { WrapDescriptor as Descriptor } from "./wasm/wasm_utxo.js";
 export { WrapMiniscript as Miniscript } from "./wasm/wasm_utxo.js";
 export { Psbt } from "./descriptorWallet/Psbt.js";
-export { DashTransaction, Transaction, ZcashTransaction, type ITransaction } from "./transaction.js";
+export {
+  DashTransaction,
+  Transaction,
+  ZcashTransaction,
+  type ITransaction,
+  type ITransactionCommon,
+} from "./transaction.js";
 export { hasPsbtMagic, type IPsbt, type IPsbtWithAddress } from "./psbt.js";

packages/wasm-utxo/js/psbt.ts

@@ -1,15 +1,10 @@
 import type { PsbtInputData, PsbtOutputData, PsbtOutputDataWithAddress } from "./wasm/wasm_utxo.js";
 import type { BIP32 } from "./bip32.js";
+import type { ITransactionCommon } from "./transaction.js";
 
 /** Common interface for PSBT types */
-export interface IPsbt {
-  inputCount(): number;
-  outputCount(): number;
-  getInputs(): PsbtInputData[];
-  getOutputs(): PsbtOutputData[];
+export interface IPsbt extends ITransactionCommon<PsbtInputData, PsbtOutputData> {
   getGlobalXpubs(): BIP32[];
-  version(): number;
-  lockTime(): number;
   unsignedTxId(): string;
   addInputAtIndex(
     index: number,

packages/wasm-utxo/js/transaction.ts

@@ -8,18 +8,20 @@ import {
 } from "./wasm/wasm_utxo.js";
 import type { CoinName } from "./coinName.js";
 
-/**
- * Common interface for all transaction types
- */
-export interface ITransaction {
-  toBytes(): Uint8Array;
-  getId(): string;
+/** Common read-only interface shared by transactions and PSBTs */
+export interface ITransactionCommon<TInput, TOutput> {
   inputCount(): number;
   outputCount(): number;
-  get version(): number;
-  get lockTime(): number;
-  getInputs(): TxInputData[];
-  getOutputs(): TxOutputData[];
+  version(): number;
+  lockTime(): number;
+  getInputs(): TInput[];
+  getOutputs(): TOutput[];
+}
+
+/** Common interface for all transaction types */
+export interface ITransaction extends ITransactionCommon<TxInputData, TxOutputData> {
+  toBytes(): Uint8Array;
+  getId(): string;
   getOutputsWithAddress(coin: CoinName): TxOutputDataWithAddress[];
 }
 
@@ -105,11 +107,11 @@ export class Transaction implements ITransaction {
     return this._wasm.output_count();
   }
 
-  get version(): number {
+  version(): number {
     return this._wasm.version();
   }
 
-  get lockTime(): number {
+  lockTime(): number {
     return this._wasm.lock_time();
   }
 
@@ -172,11 +174,11 @@ export class ZcashTransaction implements ITransaction {
     return this._wasm.output_count();
   }
 
-  get version(): number {
+  version(): number {
     return this._wasm.version();
   }
 
-  get lockTime(): number {
+  lockTime(): number {
     return this._wasm.lock_time();
   }
 
@@ -239,11 +241,11 @@ export class DashTransaction implements ITransaction {
     return this._wasm.output_count();
   }
 
-  get version(): number {
+  version(): number {
     return this._wasm.version();
   }
 
-  get lockTime(): number {
+  lockTime(): number {
     return this._wasm.lock_time();
   }