Sonar fixes

Author: rammrain

src/main/java/ee/bitweb/core/api/ControllerAdvisor.java

@@ -343,6 +343,7 @@ private void log(ControllerAdvisorProperties.Level level, String message, Throwa
             case DEBUG -> log.debug(message);
             case TRACE -> log.trace(message);
             case OFF -> {
+                // nothing to do, logging has been turned off
             }
         }
     }

src/main/java/ee/bitweb/core/audit/AuditLogFilter.java

@@ -33,8 +33,8 @@ public void doFilter(
             ServletResponse response,
             FilterChain chain
     ) throws IOException, ServletException {
-        if (request instanceof HttpServletRequest) {
-            if (isBlacklisted((HttpServletRequest) request)) {
+        if (request instanceof HttpServletRequest httpRequest) {
+            if (isBlacklisted(httpRequest)) {
                 log.debug("Request is blacklisted for request logging, will skip further processing.");
                 chain.doFilter(request, response);
 

src/main/java/ee/bitweb/core/audit/mappers/RequestForwardingDataMapper.java

@@ -80,7 +80,7 @@ private String createHeaderValues(HttpServletRequest request, String key) {
         if (!headerValues.hasMoreElements()) return null;
 
         while (headerValues.hasMoreElements()) {
-            if (builder.length() != 0) {
+            if (!builder.isEmpty()) {
                 builder.append("|");
             }
             String headerValue = headerValues.nextElement();

src/main/java/ee/bitweb/core/audit/mappers/RequestHeadersMapper.java

@@ -51,7 +51,7 @@ private String createHeaderValues(HttpServletRequest request, String key) {
         if (!headerValues.hasMoreElements()) return null;
 
         while (headerValues.hasMoreElements()) {
-            if (builder.length() != 0) {
+            if (!builder.isEmpty()) {
                 builder.append("|");
             }
             String headerValue = headerValues.nextElement();

src/main/java/ee/bitweb/core/audit/writers/AuditLogLoggerWriterAdapter.java

@@ -48,6 +48,11 @@ public void write(Map<String, String> container) {
 
     private void log(Map<String, String> container) {
         MDC.setContextMap(container);
+
+        if (!log.isInfoEnabled()) {
+            return;
+        }
+
         log.info(
                 "Method({}),  URL({}) Status({}) ResponseSize({}) Duration({} ms)",
                 get(container, RequestMethodMapper.KEY),

src/main/java/ee/bitweb/core/trace/invoker/amqp/AmqpTraceAdvisor.java

@@ -23,9 +23,9 @@ public Object invoke(MethodInvocation invocation) throws Throwable {
         log.debug("Attempting to resolve trace id from Incoming message.");
 
         for (Object argument : invocation.getArguments()) {
-            if (argument instanceof Message) {
+            if (argument instanceof Message message) {
                 log.debug("Found Message object argument list, invoking trace resolution.");
-                resolver.resolve((Message) argument);
+                resolver.resolve(message);
             }
         }
         try {

src/main/java/ee/bitweb/core/trace/thread/MDCTaskDecorator.java

@@ -1,6 +1,5 @@
 package ee.bitweb.core;
 
-
 import tools.jackson.databind.json.JsonMapper;
 import ee.bitweb.core.trace.creator.TraceIdCreator;
 import org.springframework.boot.SpringApplication;
@@ -64,7 +63,7 @@ public String generate(String traceId) {
     public static class SecurityConfiguration {
 
         @Bean
-        protected SecurityFilterChain configure(HttpSecurity httpSecurity) throws Exception {
+        protected SecurityFilterChain configure(HttpSecurity httpSecurity) {
             // Configure security to allow any request other than actuator requests
 
             return httpSecurity

src/test/java/ee/bitweb/core/TestSpringApplication.java

@@ -37,7 +37,7 @@ class AmqpMessageListenerTests {
         private AmqpTestHelper amqpTestHelper;
 
         @AfterEach
-        public void cleanup() {
+        void cleanup() {
                 amqpTestHelper.clear(AmqpConfig.COMMAND_QUEUE_NAME);
                 amqpTestHelper.clear(AmqpConfig.COMMAND_QUEUE_SIMPLE_NAME);
                 amqpTestHelper.clear(AmqpConfig.COMMAND_DEAD_LETTER_EXCHANGE_NAME);

src/test/java/ee/bitweb/core/amqp/AmqpMessageListenerTests.java

@@ -6,8 +6,8 @@
 
 @Getter
 @AllArgsConstructor
-public class AmqpParsedMessage<Body> {
+public class AmqpParsedMessage<B> {
 
     private Message message;
-    private Body body;
+    private B body;
 }