Skip to content

Commit ad65843

Browse files
committed
Change: script: add TODO headers to places where new distribution info should be updated when it is added to the script.
1 parent 96af0aa commit ad65843

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

install_rack_free.sh

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ wantRackOnly=0
1111
# 1: Manjaro.
1212
# 2: Linux Mint and Ubuntu.
1313
# 3: Fedora Linux.
14-
# <--- Add new distros here! --->
14+
# TODO: <--- Add new distro numbers here! --->
1515
selectedDistro=0
1616
distroName=0
1717

18-
# Distro names for echo: update these as well when adding new distros.
18+
# TODO: Distro names for echo: update these when adding new distros!
1919
distroLabels=("Manjaro Linux" "Linux Mint" "Ubuntu" "Fedora Linux")
2020

2121
# These setup the checker and installer commands for different distros;
@@ -79,7 +79,7 @@ function installPrereqs() {
7979
echo Installing initial prerequisites...
8080

8181
case $selectedDistro in
82-
## We are not supposed to be here...
82+
# We are not supposed to be here...
8383
0)
8484
echo
8585
echo "Invalid distribution selection. Exiting now..."
@@ -88,7 +88,7 @@ function installPrereqs() {
8888
1) installManjaroPrereqs;;
8989
2) installUbuntuPrereqs;;
9090
3) installFedoraPrereqs;;
91-
# <--- Add new distros here! --->
91+
# TODO: <--- Add new distros here! --->
9292
esac
9393
echo
9494
}
@@ -161,9 +161,9 @@ function printHelp() {
161161
echo -e "\t-v <version> Try to install specific Rack Free version."
162162
echo -e "\t-j Skip JACK installation."
163163
echo -e "\t-d <distro> Select Linux distribution from the command line."
164-
echo
165-
# Update these when new distros are added:
164+
echo
166165
echo -e "\t Valid \"distro\" options are:"
166+
# TODO: Update these when new distros are added!
167167
echo -e "\t M Manjaro Linux\tT Linux Mint"
168168
echo -e "\t U Ubuntu \tF Fedora Linux"
169169
echo
@@ -183,8 +183,9 @@ function printErrorAndExit() {
183183
}
184184

185185
function chooseDistro() {
186-
# This prompt needs updating when adding new distributions!
186+
# TODO: This prompt needs updating when adding new distributions!
187187
PS3='Type the number of your distribution and press ENTER [1-5] '
188+
# TODO: Update this array when adding new distributions! Quit should ALWAYS be last!
188189
distros=("Manjaro Linux" "Linux Mint" "Ubuntu" "Fedora Linux" "Quit")
189190
select distro in "${distros[@]}"
190191
do
@@ -231,7 +232,7 @@ do
231232
case $opt in
232233
v) rackVersion=$OPTARG;;
233234
d)
234-
# New distros need to be added here.
235+
# TODO: Update this logic when new distros are added.
235236
case $OPTARG in
236237
M)
237238
selectedDistro=1

0 commit comments

Comments
 (0)