Refactor: script: partial rewrite to make it more package manager instead of distribution based.

Fix: script: don't try to clobber pipewire-jack in Arch distributions if it is already installed.
Fix: script: properly fail when parameters are needed and none are provided.
Fix: script: make ERROR headers congruent.
Add: script: command line option to update Rack Free to specified version.
Add: script: more known working distributions.
Change: script: distribution command line parameters.
Change: script: more status reports.

Author: Bloodbat

README.md

@@ -1,6 +1,6 @@
 # Rack Free Installer Script
 
-### Script version 3.2
+### Script version 4.0
 
 A script to easily install VCV Rack Free and its dependencies for a few different Linux distros.
 
@@ -26,37 +26,47 @@ Get the installer script; put it in your home directory, and run it from the ter
 
 The script will ask you for the distribution you are using interactively; just type the number (or the Quit option to abort) and press the ENTER key.
 
-The script is written to be compatible with the following distributions; but it may work for others using the same package manager:
+The script is written for and has been tested with the following distributions:
 
 | Distribution  | Package Manager |
 | ------------- | --------------- |
 | Manjaro Linux | pacman          |
-| Ubuntu        | apt             |
+| Arch Linux    | pacman          |
+| EndeavourOS   | pacman          |
 | Linux Mint    | apt             |
+| Ubuntu        | apt             |
+| Debian        | apt             |
+| Pop!_OS       | apt             |
 | Fedora Linux  | dnf             |
 
+The script may work for other distributions using the same package manager.
+
 Distributions can also be selected using the command line by passing it the -d option followed by the UPPERCASE letter set for a known distribution; for example to install Rack Free in Ubuntu directly, run:
 
 ```
-install_rack_free.sh -d U
+install_rack_free.sh -d D
 ```
 
 Known distributions and their set letters are the following:
 
-| Distribution  | Command line option |
-| ------------- | ------------------- |
-| Manjaro Linux | M                   |
-| Ubuntu        | U                   |
-| Linux Mint    | T                   |
-| Fedora Linux  | F                   |
+| Distribution      | Base         | Command line option |
+| ----------------- | ------------ | ------------------- |
+| **Manjaro Linux** | Arch Linux   | A                   |
+| **Arch Linux**    | Arch Linux   | A                   |
+| **EndeavourOS**   | Arch Linux   | A                   |
+| **Linux Mint**    | Debian       | D                   |
+| **Ubuntu**        | Debian       | D                   |
+| **Debian**        | Debian       | D                   |
+| **Pop!_OS**       | Debian       | D                   |
+| **Fedora Linux**  | Fedora Linux | F                   |
 
 The script includes a help screen; to display it, run:
 
 ```
 install_rack_free.sh -h
 ```
 
-Installation of JACK can be skipped so that the script is more useful to more distributions and to avoid overwriting existing installations, run:
+Installation of JACK can be skipped so the script is useful for more, untested, distributions and to avoid overwriting existing installations if they are not detected by it, run:
 
 ```
 install_rack_free.sh -j
@@ -68,19 +78,21 @@ Specific Rack Free versions can be installed using the -v option; for example to
 install_rack_free.sh -v 2.5.2
 ```
 
-If you want to update Rack Free or just want to download and decompress Rack Free ignoring the prerequisites, run:
+If you just to download and decompress the default Rack Free version set by the script, ignoring the prerequisites, run:
 
 ```
 install_rack_free.sh -r
 ```
 
-This option can be used to update or downgrade existing Rack Free installations to a different version; for example to downgrade Rack Free 2.6.3, the default installed by this script, to Rack Free 2.6.0, run:
+The script can also update or downgrade existing Rack Free installations to a different version; for example to update Rack Free 2.6.3, the default installed by this script, to Rack Free 2.6.5, run:
 
 ```
-install_rack_free.sh -r -v 2.6.0
+install_rack_free.sh -u 2.6.5
 ```
 
-Keep in mind command line options are *case sensitive* and that option order is not relevant.
+The `-v` and `-u` options are mutually exclusive: if both are used, an error will be printed and the script will exit.
+
+**Keep in mind!** Command line options are *case sensitive* and option order is not relevant.
 
 ---
 
@@ -102,7 +114,7 @@ The script requires:
 
 ## My favorite distro is not listed!
 
-You can try selecting an existing distribution that uses the same packaging system and manager your particular distro uses; for example, selecting Ubuntu might work with Debian; check the table above to find out which package manager the script acknowledges for each distribution.
+You can try selecting an existing distribution that uses the same packaging system and manager your particular distro uses; for example, selecting Arch Linux might work with Garuda Linux; check the table above to find out which package manager the script acknowledges for each distribution.
 
 If none of the options work for your chosen distribution, contributions for new distributions are welcome!
 
@@ -153,7 +165,7 @@ The default version is selected using the wisdom of the community in the forum a
 
 Versions passing both tests will be the default whenever the script is updated.
 
-That said... if you want a different version, just pass it using the "-v" parameter sans the quotes.
+That said... if you want a different version, just pass it using the `-v` parameter.
 
 For example, to install VCV Rack Free version 2.6.4, type:
 
@@ -163,7 +175,17 @@ install_rack_free.sh -v 2.6.4
 
 and press ENTER.
 
-The script *does not* check for version correctness before trying to download a VCV Rack Free distribution, so... make sure you type an available version.
+The script *does not* check for version correctness before trying to download a VCV Rack Free distribution: it will fail if the selected version is not found.
+
+## Can I use the script to update Rack Free to the latest version?
+
+Yes! Just pass it using the `-u` option.
+
+For example, to update Rack Free 2.6.3 to Rack Free 2.6.5, type:
+
+```
+install_rack_free.sh -u 2.6.4
+```
 
 ## My distro is too old! The script is incompatible!
 

install_rack_free.sh

@@ -1,22 +1,25 @@
 #!/usr/bin/env bash
 
 rackVersion=2.6.3
-scriptVersion=3.2
+scriptVersion=4.0
 SUDO=''
 wantJack=1
 wantRackOnly=0
+lastCheck=0
+wantVersion=0
 
 # Holds the selected distro:
-#  0: no distro... leads to error and exit.
-#  1: Manjaro.
-#  2: Linux Mint and Ubuntu.
-#  3: Fedora Linux.
+# 0: no distro... leads to error and exit.
+# 1: updating only... THIS MUST BE KEPT HERE!
+# 2: Arch based (Manjaro Linux, Arch Linux, EndeavourOS).
+# 3: Debian based (Linux Mint, Ubuntu, Debian, Pop!_OS).
+# 4: Fedora Linux based.
 # TODO: <--- Add new distro numbers here! --->
 selectedDistro=0
 distroName=0
 
 # TODO: Distro names for echo: update these when adding new distros!
-distroLabels=("Manjaro Linux" "Linux Mint" "Ubuntu" "Fedora Linux")
+distroLabels=("Arch Linux based distribution" "Debian based distribution" "Fedora Linux based distribution")
 
 # These setup the checker and installer commands for different distros;
 # they are filled when a distro is selected.
@@ -53,10 +56,20 @@ function installRack() {
   rm RackFree-${rackVersion}-lin-x64.zip
 }
 
-function checkAndInstall() {
+function checkPackage() {
+  echo
+  echo "Checking if $1 is installed..."
   ${checkCommand} "$1" &> /dev/null
+  lastCheck=$?
+  if [ $lastCheck == 0 ]; then
+    echo ""$1" is already installed."
+  fi
+}
 
-  if [ $? != 0 ]; then
+function checkAndInstall() {
+  checkPackage "$1"
+
+  if [ $lastCheck != 0 ]; then
     echo
     echo "Installing "$1"..."
     $SUDO ${installCommand} "$1"
@@ -85,15 +98,16 @@ function installPrereqs() {
       echo "Invalid distribution selection. Exiting now..."
       exit 1
       ;;
-    1) installManjaroPrereqs;;
-    2) installUbuntuPrereqs;;
-    3) installFedoraPrereqs;;
+    1) ;;
+    2) installArchPrereqs;;
+    3) installDebianPrereqs;;
+    4) installFedoraPrereqs;;
     # TODO: <--- Add new distros here! --->
   esac
   echo
 }
 
-function installManjaroPrereqs() {
+function installArchPrereqs() {
   checkCommand="pacman -Q"
   installCommand="pacman -S -q --noconfirm"
 
@@ -104,11 +118,15 @@ function installManjaroPrereqs() {
   checkAndInstall zenity
 
   if [ $wantJack != 0 ]; then
-    checkAndInstall jack2
+    # Don't try to clobber pipewire-jack...
+    checkPackage pipewire-jack
+    if [ $lastCheck != 0 ]; then
+      checkAndInstall jack2
+    fi
   fi
 }
 
-function installUbuntuPrereqs() {
+function installDebianPrereqs() {
   checkCommand="dpkg -s"
   installCommand="apt -y install"
 
@@ -118,10 +136,10 @@ function installUbuntuPrereqs() {
 
   checkAndInstall zenity
 
-  # Don't overwrite jack in certain Ubuntu versions.
-  ${checkCommand} libjack-jackd2-0 &> /dev/null
-  if [ $? != 0 ]; then
-    if [ $wantJack != 0 ]; then
+  if [ $wantJack != 0 ]; then
+    # Don't overwrite jack in certain Ubuntu versions.
+    checkPackage libjack-jackd2-0
+    if [ $lastCheck != 0 ]; then
       checkAndInstall libjack0
     fi
   fi
@@ -157,15 +175,17 @@ function printHeader() {
 
 function printHelp() {
   printHeader
-  echo "Usage: $0 [-v <version> -j -d <distro> -r | -h]"
+  echo "Usage: $0 [(-v <version> | -u <version>) -j -d <distro> -r | -h]"
   echo -e "\t-v <version> Try to install specific Rack Free version."
   echo -e "\t-j           Skip JACK installation."
+  echo -e "\t-u <version> Update or downgrade Rack Free to the specified version."
   echo -e "\t-d <distro>  Select Linux distribution from the command line."
-  echo  
+  echo
   echo -e "\t             Valid \"distro\" options are:"
   # TODO: Update these when new distros are added!
-  echo -e "\t             M Manjaro Linux\tT Linux Mint"
-  echo -e "\t             U Ubuntu       \tF Fedora Linux"
+  echo -e "\t             A Arch Linux based (Manjaro Linux, Arch Linux, EndeavourOS)"
+  echo -e "\t             D Debian based (Linux Mint, Ubuntu, Debian, Pop!_OS)"
+  echo -e "\t             F Fedora Linux based"
   echo
   echo -e "\t-r           Install or update / downgrade Rack Free only."
   echo -e "\t-h           Show this help screen."
@@ -176,45 +196,39 @@ function printHelp() {
 
 function printErrorAndExit() {
   echo
-  echo "Unable to install "$1"."
+  echo "ERROR: Unable to install "$1"."
   echo
   echo "Exiting now..."
   exit 1
 }
 
 function chooseDistro() {
   # TODO: This prompt needs updating when adding new distributions!
-  PS3='Type the number of your distribution and press ENTER [1-5] '
+  PS3='Type the number of your distribution and press ENTER [1-4] '
   # TODO: Update this array when adding new distributions! Quit should ALWAYS be last!
-  distros=("Manjaro Linux" "Linux Mint" "Ubuntu" "Fedora Linux" "Quit")
+  distros=("Arch Linux based (Manjaro Linux, Arch Linux, EndeavourOS)" "Debian based (Linux Mint, Ubuntu, Debian, Pop!_OS)" "Fedora Linux based (Fedora Linux)" "Quit")
   select distro in "${distros[@]}"
   do
     case $REPLY in
       1)
-        selectedDistro=1
+        selectedDistro=2
         distroName=0
         echo
         break
         ;;
       2)
-        selectedDistro=2
+        selectedDistro=3
         distroName=1
         echo
         break
         ;;
       3)
-        selectedDistro=2
+        selectedDistro=4
         distroName=2
         echo
         break
         ;;
       4)
-        selectedDistro=3
-        distroName=3
-        echo
-        break
-        ;;
-      5)
         echo
         echo "Aborted by user. Bye!"
         exit 0
@@ -227,27 +241,26 @@ function chooseDistro() {
 # End functions block.
 
 # <--- Begin actual script --->
-while getopts ':v:hjrd:' opt
+while getopts ':v:hjrd:u:' opt
 do
   case $opt in
-    v) rackVersion=$OPTARG;;
+    v)
+     rackVersion=$OPTARG
+     wantVersion=1
+     ;;
     d)
        # TODO: Update this logic when new distros are added.
        case $OPTARG in
-         M)
-           selectedDistro=1
+         A)
+           selectedDistro=2
            distroName=0
            ;;
-         U)
-           selectedDistro=2
+         D)
+           selectedDistro=3
            distroName=2
            ;;
-         T)
-           selectedDistro=2
-           distroName=1
-         ;;
          F)
-           selectedDistro=3
+           selectedDistro=4
            distroName=3
            ;;
          *)
@@ -259,6 +272,11 @@ do
     h) printHelp;;
     j) wantJack=0;;
     r) wantRackOnly=1;;
+    u)
+      selectedDistro=1
+      rackVersion=$OPTARG
+      wantRackOnly=1
+      ;;
     \?)
       echo "ERROR: Invalid option: \"$OPTARG\"."
       echo
@@ -267,6 +285,14 @@ do
       echo "Exiting now."
       exit 1
       ;;
+    :)
+      echo "ERROR: Option -$OPTARG requires an argument."
+      echo
+      echo "Type $0 -h for help."
+      echo
+      echo "Exiting now..."
+      exit 1
+      ;;
   esac
 done
 
@@ -276,8 +302,17 @@ if [ $selectedDistro == 0 ]; then
   chooseDistro
 fi
 
-echo "Trying to install VCV Rack Free ${rackVersion} in ${distroLabels[distroName]}..."
-echo
+if [ $selectedDistro != 1 ]; then
+  echo "Trying to install VCV Rack Free ${rackVersion} for ${distroLabels[distroName]}..."
+  echo
+else
+  if [ $wantVersion == 1 ]; then
+    echo "ERROR: -u and -v are mutually exclusive!"
+    echo "Exiting now..."
+    exit 1
+  fi
+  echo "Trying to update VCV Rack free to ${rackVersion}..."
+fi
 
 if [ $wantRackOnly == 0 ]; then
   installPrereqs