serial: update unit ID range to 0-31

Author: sophec

absscpi/client.py

@@ -288,7 +288,7 @@ def open_serial(self, port: str, device_id: int):
 
         Args:
             port: Serial port, such as "COM1" or "/dev/ttyS1."
-            device_id: Device's serial ID, 0-255, or 256+ to address all units
+            device_id: Device's serial ID, 0-31, or 32+ to address all units
                 on the bus.
 
         Raises:
@@ -319,7 +319,7 @@ def set_target_device_id(self, device_id: int):
         Only applies to RS-485 connections.
 
         Args:
-            device_id: Target device ID, 0-255, or 256+ to broadcast to all
+            device_id: Target device ID, 0-31, or 32+ to broadcast to all
                 units on the bus.
 
         Raises:
@@ -1517,22 +1517,17 @@ def serial_discovery(
         self,
         port: str,
         first_id: int = 0,
-        last_id: int = 255,
+        last_id: int = 31,
     ) -> list[AbsSerialDiscoveryResult]:
         """Use RS-485 to discover ABSes on the bus.
 
         This function requires that the ScpiClient *not* be connected over
         serial! This will interfere with opening the serial port.
 
-        Since this function operates by scanning all serial IDs in a range, it
-        can take upwards of 15 seconds to scan the full address space. It's
-        therefore recommended to limit the address range to the range you expect
-        devices to be in.
-
         Args:
             port: Serial port to use, such as COM1 or /dev/ttyS0.
-            first_id: First serial ID to check, 0-255.
-            last_id: Last serial ID to check (inclusive), 0-255. Must not be
+            first_id: First serial ID to check, 0-31.
+            last_id: Last serial ID to check (inclusive), 0-31. Must not be
                 less than first_id.
 
         Returns:
@@ -1541,7 +1536,7 @@ def serial_discovery(
         Raises:
             ScpiClientError: An error occurred during discovery.
         """
-        if last_id < 0 or last_id > 255 or first_id < 0 or first_id > 255:
+        if last_id < 0 or last_id > 31 or first_id < 0 or first_id > 31:
             raise ValueError("invalid ID")
         elif last_id < first_id:
             raise ValueError("last ID cannot be less than first ID")

examples/serial_id.py

@@ -13,9 +13,9 @@ def serial_ids_demo(port: str, ids: list[int]):
         ids: List of serial IDs to talk to.
     """
     with ScpiClient() as client:
-        # first, let's send a message to all units by addressing 256
-        # (any number greater than 255 will work)
-        client.open_serial(port, 256)
+        # first, let's send a message to all units by addressing 32
+        # (any number greater than 31 will work)
+        client.open_serial(port, 32)
 
         # set cell 1 to 1.5V on every device
         client.set_cell_voltage(0, 1.5)