From 66936a8bdba731d1e3462fcdd1b48dc624f4330d Mon Sep 17 00:00:00 2001 From: Abdul Rehman Talat Date: Tue, 25 Dec 2018 23:30:27 +0500 Subject: [PATCH 1/3] =?UTF-8?q?test(=F0=9F=93=A6=20BlueBaseModule):=20Adde?= =?UTF-8?q?d=20test=20to=20highlight=20the=20bug.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/utils/tests/BlueBaseModule.test.ts | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/utils/tests/BlueBaseModule.test.ts b/src/utils/tests/BlueBaseModule.test.ts index e9f8651c..b2432108 100644 --- a/src/utils/tests/BlueBaseModule.test.ts +++ b/src/utils/tests/BlueBaseModule.test.ts @@ -56,19 +56,18 @@ describe('Utils', () => { expect(obj.foo).toBe('bar'); }); - // it('should set loaded prop of only the loaded item', async () => { + it('should set loaded prop of only the loaded item', async () => { - // // FIXME: Big bug!!! - // const module = createBlueBaseModule({ foo: 'bar' }); - // const module1 = createBlueBaseModule({ foo: 'baz' }); - // expect(module.loaded).toBe(false); - // expect(module1.loaded).toBe(false); + const module = createBlueBaseModule({ foo: 'bar' }); + const module1 = createBlueBaseModule({ foo: 'baz' }); + expect(module.loaded).toBe(false); + expect(module1.loaded).toBe(false); - // const obj = await module; + const obj = await module; - // expect(obj.foo).toBe('bar'); - // expect(module.loaded).toBe(true); - // expect(module1.loaded).toBe(false); - // }); + expect(obj.foo).toBe('bar'); + expect(module.loaded).toBe(true); + expect(module1.loaded).toBe(false); + }); }); }); From c1e90ea15da5b0a1bf8e13da742e463372994a3d Mon Sep 17 00:00:00 2001 From: omarnaeem Date: Wed, 26 Dec 2018 14:27:29 +0500 Subject: [PATCH 2/3] fix(BlueBaseModule): test case passed by using promise.then rather than async await --- src/utils/tests/BlueBaseModule.test.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/utils/tests/BlueBaseModule.test.ts b/src/utils/tests/BlueBaseModule.test.ts index b2432108..520cde71 100644 --- a/src/utils/tests/BlueBaseModule.test.ts +++ b/src/utils/tests/BlueBaseModule.test.ts @@ -56,17 +56,17 @@ describe('Utils', () => { expect(obj.foo).toBe('bar'); }); - it('should set loaded prop of only the loaded item', async () => { + it('should set loaded prop of only the loaded item', () => { const module = createBlueBaseModule({ foo: 'bar' }); const module1 = createBlueBaseModule({ foo: 'baz' }); expect(module.loaded).toBe(false); expect(module1.loaded).toBe(false); - const obj = await module; - - expect(obj.foo).toBe('bar'); - expect(module.loaded).toBe(true); + module.then((obj) => { + expect(obj.foo).toBe('bar'); + expect(module.loaded).toBe(true); + }); expect(module1.loaded).toBe(false); }); }); From 648ae6e085c709388056b2b1643eb20e017812fd Mon Sep 17 00:00:00 2001 From: omarnaeem Date: Wed, 26 Dec 2018 14:45:32 +0500 Subject: [PATCH 3/3] test(BlueBaseModule): prettier fixed --- src/utils/tests/BlueBaseModule.test.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/utils/tests/BlueBaseModule.test.ts b/src/utils/tests/BlueBaseModule.test.ts index 520cde71..db595e81 100644 --- a/src/utils/tests/BlueBaseModule.test.ts +++ b/src/utils/tests/BlueBaseModule.test.ts @@ -57,13 +57,12 @@ describe('Utils', () => { }); it('should set loaded prop of only the loaded item', () => { - const module = createBlueBaseModule({ foo: 'bar' }); const module1 = createBlueBaseModule({ foo: 'baz' }); expect(module.loaded).toBe(false); expect(module1.loaded).toBe(false); - module.then((obj) => { + module.then(obj => { expect(obj.foo).toBe('bar'); expect(module.loaded).toBe(true); });