Permissions: Tweaks/fixed during review of revision-view-all changes

Author: ssddanbrown

app/Entities/Controllers/PageRevisionController.php

@@ -134,8 +134,8 @@ public function changes(string $bookSlug, string $pageSlug, int $revisionId)
      */
     public function restore(string $bookSlug, string $pageSlug, int $revisionId)
     {
-        $page = $this->pageQueries->findVisibleBySlugsOrFail($bookSlug, $pageSlug);
         $this->checkPermission(Permission::RevisionViewAll);
+        $page = $this->pageQueries->findVisibleBySlugsOrFail($bookSlug, $pageSlug);
         $this->checkOwnablePermission(Permission::PageUpdate, $page);
 
         $page = $this->pageRepo->restoreRevision($page, $revisionId);
@@ -150,8 +150,8 @@ public function restore(string $bookSlug, string $pageSlug, int $revisionId)
      */
     public function destroy(string $bookSlug, string $pageSlug, int $revId)
     {
-        $page = $this->pageQueries->findVisibleBySlugsOrFail($bookSlug, $pageSlug);
         $this->checkPermission(Permission::RevisionViewAll);
+        $page = $this->pageQueries->findVisibleBySlugsOrFail($bookSlug, $pageSlug);
         $this->checkOwnablePermission(Permission::PageDelete, $page);
 
         $revision = $page->revisions()->where('id', '=', $revId)->first();

database/migrations/2026_04_19_141616_add_revision_view_all_permission.php

@@ -24,7 +24,7 @@ public function up(): void
                 'page-view-all',
             ])->get();
 
-        if (!$pageViewPermissions->count() === 0) {
+        if ($pageViewPermissions->count() === 0) {
             return;
         }
 

resources/views/settings/roles/parts/revisions-permissions-row.blade.php

@@ -19,4 +19,4 @@
         <small class="hide-over-m bold">{{ trans('common.delete') }}<br></small>
         <small>{{ trans('settings.role_controlled_by_page_delete') }}</small>
     </div>
-</div>
+</div>