Skip to content

Commit 5a48cb0

Browse files
committed
Merge branch 'multiselect_bug' of git://github.com/codingblazer/BuildmLearn-Toolkit-Android into codingblazer-multiselect_bug
2 parents 6106cf0 + 7def88e commit 5a48cb0

4 files changed

Lines changed: 4 additions & 10 deletions

File tree

source-code/app/src/main/java/org/buildmlearn/toolkit/adapter/SavedApiAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public ArrayList<Integer> getSelectedPositions()
7979
{
8080
positions.add((Integer)key);
8181
}
82-
Collections.sort(positions);
82+
Collections.sort(positions,Collections.reverseOrder());
8383
return positions;
8484
}
8585

source-code/app/src/main/java/org/buildmlearn/toolkit/adapter/SavedProjectAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public ArrayList<Integer> getSelectedPositions()
7474
{
7575
positions.add((Integer)key);
7676
}
77-
Collections.sort(positions);
77+
Collections.sort(positions, Collections.reverseOrder());
7878
return positions;
7979
}
8080

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/LoadApkFragment.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,6 @@ public void onClick(View v) {
332332
Intent sendIntent = new Intent(Intent.ACTION_SEND_MULTIPLE);
333333
sendIntent.setType("application/zip");
334334
for(int selectedPosition : selectedPositions) {
335-
if(selectedPosition != selectedPositions.get(0))
336-
selectedPosition--;
337335
SavedApi apk = savedApis.get(selectedPosition);
338336
File file = new File(apk.getFile().getPath());
339337
Uri fileUri = Uri.fromFile(file);
@@ -429,13 +427,12 @@ private void deleteItems() {
429427
ArrayList<Integer> selectedPositions = mAdapter.getSelectedPositions();
430428
boolean deleted = false;
431429
for(int selectedPosition : selectedPositions) {
432-
if (selectedPosition != selectedPositions.get(0))
433-
selectedPosition--;
434430
SavedApi apk = savedApis.get(selectedPosition);
435431
File file = new File(apk.getFile().getPath());
436432
deleted = file.delete();
437433
if (deleted) {
438434
savedApis.remove(selectedPosition);
435+
mAdapter.removeSelectedPosition(selectedPosition);
439436
mAdapter.notifyDataSetChanged();
440437
setEmptyText();
441438
}

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/LoadProjectFragment.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -370,8 +370,6 @@ public void onClick(View v) {
370370
Intent sendIntent = new Intent(Intent.ACTION_SEND_MULTIPLE);
371371
sendIntent.setType("application/zip");
372372
for(int selectedPosition : selectedPositions) {
373-
if(selectedPosition != selectedPositions.get(0))
374-
selectedPosition--;
375373
SavedProject project = savedProjects.get(selectedPosition);
376374
File file = new File(project.getFile().getPath());
377375

@@ -469,11 +467,10 @@ private void deleteItems() {
469467
ArrayList<Integer> selectedPositions = mAdapter.getSelectedPositions();
470468
boolean deleted = false;
471469
for(int selectedPosition : selectedPositions) {
472-
if(selectedPosition!=selectedPositions.get(0))
473-
selectedPosition--;
474470
SavedProject project = savedProjects.get(selectedPosition);
475471
File file = new File(project.getFile().getPath());
476472
deleted = file.delete();
473+
477474
if (deleted) {
478475
savedProjects.remove(selectedPosition);
479476
mAdapter.removeSelectedPosition(selectedPosition);

0 commit comments

Comments
 (0)