Skip to content

Commit b437aa6

Browse files
authored
Merge pull request #300 from vishwesh3/bug-fixes
Fixed issue #226
2 parents 638d307 + fbf0d0f commit b437aa6

9 files changed

Lines changed: 32 additions & 21 deletions

File tree

source-code/app/src/main/java/org/buildmlearn/toolkit/activity/TemplateEditor.java

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
import android.Manifest;
44
import android.app.Dialog;
55
import android.app.ProgressDialog;
6+
import android.content.DialogInterface;
7+
import android.support.design.widget.Snackbar;
8+
import android.support.v7.app.AlertDialog;
69
import android.content.Context;
710
import android.content.DialogInterface;
811
import android.content.Intent;
@@ -583,25 +586,19 @@ public boolean onOptionsItemSelected(MenuItem item) {
583586

584587
switch (id) {
585588
case R.id.action_delete:
586-
587-
final AlertDialog dialog = new AlertDialog.Builder(this)
588-
.setTitle(R.string.dialog_delete_title)
589-
.setMessage(R.string.dialog_delete_msg)
590-
.setPositiveButton(R.string.dialog_yes, null)
591-
.setNegativeButton(R.string.dialog_no, null)
592-
.create();
593-
dialog.show();
594-
595-
dialog.getButton(DialogInterface.BUTTON_POSITIVE).setOnClickListener(new View.OnClickListener() {
596-
@Override
597-
public void onClick(View v) {
598-
dialog.dismiss();
599-
selectedTemplate.deleteItem(TemplateEditor.this, selectedPosition);
600-
selectedPosition = -1;
601-
restoreSelectedView();
602-
}
603-
});
604-
589+
final int restorePosition = selectedPosition;
590+
final Object object = selectedTemplate.deleteItem(TemplateEditor.this,selectedPosition);
591+
selectedPosition = -1;
592+
restoreSelectedView();
593+
Snackbar.make(findViewById(R.id.relative_layout),
594+
R.string.snackbar_deleted_message,Snackbar.LENGTH_LONG)
595+
.setAction(R.string.snackbar_undo, new View.OnClickListener() {
596+
@Override
597+
public void onClick(View v) {
598+
selectedTemplate.restoreItem(TemplateEditor.this,restorePosition,object);
599+
Snackbar.make(v,R.string.snackbar_restored_message,Snackbar.LENGTH_LONG).show();
600+
}
601+
}).show();
605602
break;
606603
case R.id.action_edit:
607604
selectedTemplate.editItem(this, selectedPosition);

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/ComprehensionTemplate.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,7 @@ public Object deleteItem(Activity activity, int position) {
528528
setEmptyView(activity);
529529
adapter.notifyDataSetChanged();
530530
}
531+
setEmptyView(activity);
531532
if (comprehensionMetaModel==null)
532533
{
533534
return comprehensionModel;
@@ -562,7 +563,7 @@ public void restoreItem(Activity activity, int position, Object object) {
562563
}
563564
}
564565
}
565-
566+
setEmptyView(activity);
566567
}
567568

568569
@Override

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/DictationTemplate.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ public Object deleteItem(Activity activity, int position) {
231231
dictData.remove(position);
232232
setEmptyView(activity);
233233
adapter.notifyDataSetChanged();
234+
setEmptyView(activity);
234235
return dictationModel;
235236
}
236237

@@ -243,6 +244,7 @@ public void restoreItem(Activity activity, int position, Object object) {
243244
{
244245
dictData.add(position,dictationModel);
245246
adapter.notifyDataSetChanged();
247+
setEmptyView(activity);
246248
}
247249
}
248250
}

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/FlashTemplate.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ public Object deleteItem(Activity activity, int position) {
266266
mData.remove(position);
267267
setEmptyView(activity);
268268
mAdapter.notifyDataSetChanged();
269-
269+
setEmptyView(activity);
270270
return flashCardModel;
271271
}
272272

@@ -279,6 +279,7 @@ public void restoreItem(Activity activity, int position, Object object) {
279279
{
280280
mData.add(position,flashCardModel);
281281
mAdapter.notifyDataSetChanged();
282+
setEmptyView(activity);
282283
}
283284
}
284285
}

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/InfoTemplate.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ public Object deleteItem(Activity activity, int position) {
195195
infoData.remove(position);
196196
setEmptyView(activity);
197197
adapter.notifyDataSetChanged();
198+
setEmptyView(activity);
198199
return infoModel;
199200
}
200201

@@ -207,6 +208,7 @@ public void restoreItem(Activity activity, int position, Object object) {
207208
{
208209
infoData.add(position,infoModel);
209210
adapter.notifyDataSetChanged();
211+
setEmptyView(activity);
210212
}
211213
}
212214
}

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/LearnSpellingTemplate.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ public Object deleteItem(Activity activity, int position) {
195195
mLearnSpellingData.remove(position);
196196
setEmptyView(activity);
197197
adapter.notifyDataSetChanged();
198+
setEmptyView(activity);
198199
return learnSpellingModel;
199200
}
200201

@@ -207,6 +208,7 @@ public void restoreItem(Activity activity, int position, Object object) {
207208
{
208209
mLearnSpellingData.add(position,learnSpellingModel);
209210
adapter.notifyDataSetChanged();
211+
setEmptyView(activity);
210212
}
211213
}
212214
}

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/MatchTemplate.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@ public Object deleteItem(Activity activity, int position) {
329329
setEmptyView(activity);
330330
adapter.notifyDataSetChanged();
331331
}
332+
setEmptyView(activity);
332333
if (matchMetaModel==null)
333334
{
334335
return matchModel;
@@ -358,6 +359,7 @@ public void restoreItem(Activity activity, int position, Object object) {
358359
}
359360
}
360361
}
362+
setEmptyView(activity);
361363
}
362364

363365
@Override

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/QuizTemplate.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@ public Object deleteItem(Activity activity, int position) {
342342
quizData.remove(position);
343343
setEmptyView(activity);
344344
mAdapter.notifyDataSetChanged();
345+
setEmptyView(activity);
345346
return quizModel;
346347
}
347348

@@ -352,6 +353,7 @@ public void restoreItem(Activity activity, int position, Object object) {
352353
if (quizModel != null) {
353354
quizData.add(position, quizModel);
354355
mAdapter.notifyDataSetChanged();
356+
setEmptyView(activity);
355357
}
356358
}
357359
}

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/VideoCollectionTemplate.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ public Object deleteItem(Activity activity, int position) {
324324
videoData.remove(position);
325325
setEmptyView(activity);
326326
adapter.notifyDataSetChanged();
327+
setEmptyView(activity);
327328
return videoModel;
328329
}
329330

@@ -334,6 +335,7 @@ public void restoreItem(Activity activity, int position, Object object) {
334335
if (videoModel != null) {
335336
videoData.add(position, videoModel);
336337
adapter.notifyDataSetChanged();
338+
setEmptyView(activity);
337339
}
338340
}
339341
}

0 commit comments

Comments
 (0)