Skip to content

Commit f63e103

Browse files
committed
git push origin bug-fixesMerge branch 'vishwesh3-bug-fixes' into bug-fixes
2 parents 7395c71 + d77b8af commit f63e103

6 files changed

Lines changed: 24 additions & 18 deletions

File tree

source-code/app/src/main/java/org/buildmlearn/toolkit/ToolkitApplication.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class ToolkitApplication extends Application {
1818

1919
private static String dir;
2020

21-
private boolean isExternalStorageAvailable = false;
21+
private static boolean isExternalStorageAvailable = false;
2222

2323
/**
2424
* @return Folder path
@@ -31,6 +31,10 @@ public static String getUnZipDir() {
3131
@Override
3232
public void onCreate() {
3333
super.onCreate();
34+
storagePathsValidate();
35+
}
36+
37+
public void storagePathsValidate() {
3438
if (checkExternalStorage()) {
3539
isExternalStorageAvailable = true;
3640
dir = Environment.getExternalStorageDirectory().getAbsolutePath();
@@ -50,8 +54,6 @@ public void onCreate() {
5054
f.mkdirs();
5155
}
5256
}
53-
54-
5557
}
5658

5759
/**

source-code/app/src/main/java/org/buildmlearn/toolkit/activity/TemplateEditor.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
package org.buildmlearn.toolkit.activity;
2+
23
import android.Manifest;
34
import android.app.ProgressDialog;
45
import android.content.Context;
@@ -55,7 +56,6 @@
5556
import java.io.IOException;
5657
import java.util.ArrayList;
5758

58-
5959
import javax.xml.parsers.DocumentBuilder;
6060
import javax.xml.parsers.DocumentBuilderFactory;
6161
import javax.xml.parsers.ParserConfigurationException;
@@ -143,6 +143,22 @@ public void onClick(View v) {
143143
}
144144
}
145145

146+
@Override
147+
public void onRequestPermissionsResult(int requestCode,
148+
String permissions[], int[] grantResults) {
149+
switch (requestCode) {
150+
case PERMISSION_REQUEST_WRITE_EXTERNAL_STORAGE_RESULT: {
151+
if (grantResults.length > 0
152+
&& grantResults[0] == PackageManager.PERMISSION_GRANTED) {
153+
ToolkitApplication mToolkitApplication = new ToolkitApplication();
154+
mToolkitApplication.storagePathsValidate();
155+
}
156+
return;
157+
}
158+
159+
}
160+
}
161+
146162
/**
147163
* {@inheritDoc}
148164
*/

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/LoadApkFragment.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,8 +368,7 @@ public void afterTextChanged(Editable s) {
368368
SavedApi tempApi;
369369
for (int i = 0; i < allsavedApis.size(); i++) {
370370
if (allsavedApis.get(i).getName().contains(text)) {
371-
tempApi = new SavedApi(allsavedApis.get(i).getFile(), allsavedApis.get(i).getName(), allsavedApis.get(i).getUnformattedDate());
372-
savedApis.add(tempApi);
371+
savedApis.add(allsavedApis.get(i));
373372
}
374373
}
375374
mAdapter.notifyDataSetChanged();

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/LoadProjectFragment.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -408,8 +408,7 @@ public void afterTextChanged(Editable s) {
408408
SavedProject tempProject;
409409
for (int i = 0; i < allsavedProjects.size(); i++) {
410410
if (allsavedProjects.get(i).getName().contains(text)) {
411-
tempProject = new SavedProject(allsavedProjects.get(i).getFile(), allsavedProjects.get(i).getName(), allsavedProjects.get(i).getUnformattedDate(), allsavedProjects.get(i).getType(), allsavedProjects.get(i).getFullPath());
412-
savedProjects.add(tempProject);
411+
savedProjects.add(allsavedProjects.get(i));
413412
}
414413
}
415414
mAdapter.notifyDataSetChanged();

source-code/app/src/main/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@
250250
<!-- Preference Data-->
251251

252252
<string name="project_settings">Project Settings</string>
253-
<string name="key_developer_mode">debug_key</string>
254253
<string name="developer_mode">Developer Mode</string>
255254
<string name="summary_developer_mode">Developer mode disables publishing of Apk to BuildmLearn Store.</string>
256255
<string name="title_user_name">Enter your name</string>

source-code/app/src/main/res/xml/fragment_settings.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,6 @@
22

33
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
44

5-
<PreferenceCategory android:title="@string/project_settings">
6-
7-
<CheckBoxPreference
8-
android:key="@string/key_developer_mode"
9-
android:summary="@string/summary_developer_mode"
10-
android:title="@string/developer_mode" />
11-
12-
</PreferenceCategory>
13-
145
<PreferenceCategory android:title="@string/app_settings">
156

167
<Preference

0 commit comments

Comments
 (0)