Merge pull request #23 from 201st-Luka/correcting_errors

Correcting errors

Author: ByteLuka

.editorconfig

@@ -1,10 +1,10 @@
 [![Discord][discord_shield]][discord_url] ![Last commit][last_commit_shield]
 
-# PyClasher
+![PyClasher](.github/PyClasher.png)
 
----
+# PyClasher
 
-pyclasher is the name of the asynchronous ClashOfClans API. It is
+PyClasher is the name of the asynchronous ClashOfClans API. It is
 an object-oriented wrapper client that provides easy access to the 
 requested data.
 
@@ -18,9 +18,16 @@ a python package and will be available for everyone.
 If you have any questions, feel free to join my discord server 
 to ask you question. 
 
+## Installation
+
+It is possible to install the package from GitHib releases. You can use the following command to add PyClasher to your library:
+```bash
+pip install git+https://github.com/201st-Luka/PyClasher.git@v0.0.1-alpha3
+```
+
 ---
 
-### Features
+## Features
  - Asynchronous and parallel requesting
  - Possibility to use multiple tokens and to login via email address 
 and password of the ClashOfClans developer portal
@@ -31,11 +38,34 @@ used tokens
 
 ---
 
-### Future
+## Contributing
+
+Feel free to contribute to the repository. 
+
+You can fork the repository and commit your changes in a pull request. Please consider to check out the 
+[Discord server][discord_url] if so.
+
+---
+
+## Future
 
 I'm planning to keep the API wrapper up to date and improve it as
 good as I can. 
 
+### Planned features
+
+- more bulk requests
+- pytests for every request
+- pytests for the models
+- possibility to download files (images, etc) from `api-assets.clashofclans.com`
+
+### Planned utils
+
+- documentation
+- real example ([HeadhunterBot][headhunterbot_url] is in development)
+
+---
+
 If you find a bug, an error or want custom functionality, please tell
 me via Discord or open an issue or start a discussion on the 
 GitHub-repository.
@@ -45,4 +75,5 @@ GitHub-repository.
 <!---links--->
 [discord_shield]: https://img.shields.io/badge/Discord-blue?logo=discord&logoColor=white
 [discord_url]: https://discord.gg/j2PAF9Wru8
-[last_commit_shield]: https://img.shields.io/github/last-commit/201st-Luka/HeadhunterBot
+[last_commit_shield]: https://img.shields.io/github/last-commit/201st-Luka/HeadhunterBot
+[headhunterbot_url]: https://github.com/201st-Luka/HeadhunterBot

.github/PyClasher.png

@@ -20,7 +20,8 @@ def tags(self):
 
     @classmethod
     async def _async_from_clan(cls, clan):
-        members = await ClanMembersRequest(clan.tag).request() if isinstance(clan, BaseClan) else await ClanMembersRequest(clan).request()
+        members = await (ClanMembersRequest(clan.tag).request() if isinstance(clan, BaseClan) else
+                         await ClanMembersRequest(clan).request())
         return cls.from_member_list(members)
 
     @classmethod

.github/workflows/pre-pullrequest.yml .github/workflows/pull_request.yml.github/workflows/pre-pullrequest.yml renamed to .github/workflows/pull_request.yml

@@ -1,4 +1,4 @@
-from typing import Iterable, Coroutine, Any
+from typing import Iterable, Coroutine, Any, Iterator
 
 from .BulkRequestModel import BulkRequestModel
 from ..models import BaseClan, ClanMemberList, ClanWarMemberList, ClanWarLeagueClanMemberList, ClanCapitalRaidSeasonMemberList
@@ -75,6 +75,9 @@ class PlayerBulkRequest(BulkRequestModel):
         """
         ...
 
+    def __iter__(self) -> Iterator[PlayerRequest]:
+        ...
+
     def __next__(self) -> PlayerRequest:
         """
         returns the next player of the bulk request if an iterator is used

.github/workflows/pre-commit.yml .github/workflows/push.yml.github/workflows/pre-commit.yml renamed to .github/workflows/push.yml

@@ -47,4 +47,5 @@ def __str__(self):
         return f"{self.__class__.__name__}({self._main_attribute})"
 
     def __repr__(self):
-        return f"{self.__class__.__name__}({', '.join(('='.join((key, str(value))) for key, value in self.__get_properties().items()))})"
+        return (f"{self.__class__.__name__}"
+                f"({', '.join(('='.join((key, str(value))) for key, value in self.__get_properties().items()))})")

README.md

@@ -1,4 +1,4 @@
-from typing import Any, Coroutine
+from typing import Any, Coroutine, Iterator
 
 
 class BulkRequestModel:
@@ -80,7 +80,7 @@ class BulkRequestModel:
     def __getitem__(self, item: int) -> _request_model:
         ...
 
-    def __iter__(self):
+    def __iter__(self) -> Iterator[_request_model]:
         self._iter = iter(self._requests)
         ...
 

pyclasher/bulk_requests/BulkPlayer.py

@@ -2,7 +2,7 @@
 base models for this API wrapper client
 """
 
-from typing import Any
+from typing import Any, Iterator
 
 from ..Exceptions import MISSING, Missing
 
@@ -126,8 +126,9 @@ class IterBaseModel:
     def __getitem__(self, item: int) -> _iter_rtype:
         ...
 
-    def __iter__(self) -> IterBaseModel:
+    def __iter__(self) -> Iterator[_iter_rtype]:
         self._iter = iter(self._data)
+        ...
 
     def __next__(self):
         ...