Skip to content

Commit 3c38e72

Browse files
committed
applying pre-commit hooks and linting for code quality
1 parent fa65669 commit 3c38e72

4 files changed

Lines changed: 52 additions & 59 deletions

File tree

CodeEntropy/entropy.py

Lines changed: 43 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ class EntropyManager:
1616
molecular dynamics trajectory.
1717
"""
1818

19-
def __init__(self, run_manager, args, universe, data_logger, level_manager, group_molecules):
19+
def __init__(
20+
self, run_manager, args, universe, data_logger, level_manager, group_molecules
21+
):
2022
"""
2123
Initializes the EntropyManager with required components.
2224
@@ -67,36 +69,31 @@ def execute(self):
6769

6870
self._handle_water_entropy(start, end, step)
6971
reduced_atom, number_molecules, levels, groups = self._initialize_molecules()
70-
number_groups = len(groups)
7172
number_frames = len(reduced_atom.trajectory)
7273

73-
force_matrices, torque_matrices = (
74-
self._level_manager.build_covariance_matrices(
75-
self,
76-
reduced_atom,
77-
levels,
78-
groups,
79-
start,
80-
end,
81-
step,
82-
number_frames,
83-
)
74+
force_matrices, torque_matrices = self._level_manager.build_covariance_matrices(
75+
self,
76+
reduced_atom,
77+
levels,
78+
groups,
79+
start,
80+
end,
81+
step,
82+
number_frames,
8483
)
8584

86-
states_ua, states_res = (
87-
self._level_manager.build_conformational_states(
88-
self,
89-
reduced_atom,
90-
number_molecules,
91-
levels,
92-
groups,
93-
start,
94-
end,
95-
step,
96-
number_frames,
97-
self._args.bin_width,
98-
ce,
99-
)
85+
states_ua, states_res = self._level_manager.build_conformational_states(
86+
self,
87+
reduced_atom,
88+
number_molecules,
89+
levels,
90+
groups,
91+
start,
92+
end,
93+
step,
94+
number_frames,
95+
self._args.bin_width,
96+
ce,
10097
)
10198

10299
self._compute_entropies(
@@ -379,15 +376,9 @@ def _process_united_atom_entropy(
379376
residue_id, residue.resname, level, "Conformational", S_conf_res
380377
)
381378

382-
self._data_logger.add_results_data(
383-
group_id, level, "Transvibrational", S_trans
384-
)
385-
self._data_logger.add_results_data(
386-
group_id, level, "Rovibrational", S_rot
387-
)
388-
self._data_logger.add_results_data(
389-
group_id, level, "Conformational", S_conf
390-
)
379+
self._data_logger.add_results_data(group_id, level, "Transvibrational", S_trans)
380+
self._data_logger.add_results_data(group_id, level, "Rovibrational", S_rot)
381+
self._data_logger.add_results_data(group_id, level, "Conformational", S_conf)
391382

392383
def _process_vibrational_entropy(
393384
self, group_id, number_frames, ve, level, force_matrix, torque_matrix, highest
@@ -418,12 +409,8 @@ def _process_vibrational_entropy(
418409
torque_matrix, "torque", self._args.temperature, highest
419410
)
420411

421-
self._data_logger.add_results_data(
422-
group_id, level, "Transvibrational", S_trans
423-
)
424-
self._data_logger.add_results_data(
425-
group_id, level, "Rovibrational", S_rot
426-
)
412+
self._data_logger.add_results_data(group_id, level, "Transvibrational", S_trans)
413+
self._data_logger.add_results_data(group_id, level, "Rovibrational", S_rot)
427414

428415
def _process_conformational_entropy(
429416
self, group_id, ce, level, states, number_frames
@@ -442,9 +429,7 @@ def _process_conformational_entropy(
442429
"""
443430
S_conf = ce.conformational_entropy_calculation(states[group_id], number_frames)
444431

445-
self._data_logger.add_results_data(
446-
group_id, level, "Conformational", S_conf
447-
)
432+
self._data_logger.add_results_data(group_id, level, "Conformational", S_conf)
448433

449434
def _finalize_molecule_results(self):
450435
"""
@@ -594,12 +579,16 @@ class VibrationalEntropy(EntropyManager):
594579
vibrational modes and thermodynamic properties.
595580
"""
596581

597-
def __init__(self, run_manager, args, universe, data_logger, level_manager, group_molecules):
582+
def __init__(
583+
self, run_manager, args, universe, data_logger, level_manager, group_molecules
584+
):
598585
"""
599586
Initializes the VibrationalEntropy manager with all required components and
600587
defines physical constants used in vibrational entropy calculations.
601588
"""
602-
super().__init__(run_manager, args, universe, data_logger, level_manager, group_molecules)
589+
super().__init__(
590+
run_manager, args, universe, data_logger, level_manager, group_molecules
591+
)
603592
self._PLANCK_CONST = 6.62607004081818e-34
604593

605594
def frequency_calculation(self, lambdas, temp):
@@ -718,12 +707,16 @@ class ConformationalEntropy(EntropyManager):
718707
analysis using statistical mechanics principles.
719708
"""
720709

721-
def __init__(self, run_manager, args, universe, data_logger, level_manager, group_molecules):
710+
def __init__(
711+
self, run_manager, args, universe, data_logger, level_manager, group_molecules
712+
):
722713
"""
723714
Initializes the ConformationalEntropy manager with all required components and
724715
sets the gas constant used in conformational entropy calculations.
725716
"""
726-
super().__init__(run_manager, args, universe, data_logger, level_manager, group_molecules)
717+
super().__init__(
718+
run_manager, args, universe, data_logger, level_manager, group_molecules
719+
)
727720

728721
def assign_conformation(
729722
self, data_container, dihedral, number_frames, bin_width, start, end, step
@@ -755,7 +748,7 @@ def assign_conformation(
755748

756749
# get the values of the angle for the dihedral
757750
# dihedral angle values have a range from -180 to 180
758-
for timestep in data_container.trajectory[start:end+1:step]:
751+
for timestep in data_container.trajectory[start : end + 1 : step]:
759752
timestep_index = timestep.frame - start
760753
value = dihedral.value()
761754
# we want postive values in range 0 to 360 to make the peak assignment

CodeEntropy/group_molecules.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import logging
2-
import MDAnalysis as mda
32

43
logger = logging.getLogger(__name__)
54

5+
66
class GroupMolecules:
77
"""
88
Groups molecules for averaging.
@@ -57,7 +57,7 @@ def _by_none(self, universe):
5757

5858
def _by_molecules(self, universe):
5959
"""
60-
Group molecules by chemical type.
60+
Group molecules by chemical type.
6161
Based on number of atoms and atom names.
6262
"""
6363

CodeEntropy/levels.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -941,10 +941,12 @@ def build_conformational_states(
941941
for res_id, residue in enumerate(mol.residues):
942942
key = (group_id, res_id)
943943

944-
res_container = entropy_manager._run_manager.new_U_select_atom(
945-
mol,
946-
f"index {residue.atoms.indices[0]}:"
947-
f"{residue.atoms.indices[-1]}",
944+
res_container = (
945+
entropy_manager._run_manager.new_U_select_atom(
946+
mol,
947+
f"index {residue.atoms.indices[0]}:"
948+
f"{residue.atoms.indices[-1]}",
949+
)
948950
)
949951
heavy_res = entropy_manager._run_manager.new_U_select_atom(
950952
res_container, "not name H*"
@@ -979,7 +981,6 @@ def build_conformational_states(
979981
)
980982

981983
states_res[group_id] += states
982-
983984

984985
logger.debug(f"states_ua {states_ua}")
985986
logger.debug(f"states_res {states_res}")

CodeEntropy/run.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
from CodeEntropy.config.data_logger import DataLogger
1111
from CodeEntropy.config.logging_config import LoggingConfig
1212
from CodeEntropy.entropy import EntropyManager
13-
from CodeEntropy.levels import LevelManager
1413
from CodeEntropy.group_molecules import GroupMolecules
14+
from CodeEntropy.levels import LevelManager
1515

1616
logger = logging.getLogger(__name__)
1717

@@ -152,7 +152,6 @@ def run_entropy_workflow(self):
152152
data_logger=self._data_logger,
153153
level_manager=level_manager,
154154
group_molecules=group_molecules,
155-
156155
)
157156

158157
entropy_manager.execute()

0 commit comments

Comments
 (0)