schema compile BUGFIX check prefixes even in relative schema-nodeids

Author: michalvasko

src/schema_compile_amend.c

@@ -182,7 +182,7 @@ lys_schema_node_get_module(const struct ly_ctx *ctx, const char *prefix_dict, co
     }
 
     /* prefix module not found */
-    LOGVAL(ctx, NULL, LYVE_REFERENCE, "Invalid absolute-schema-nodeid nametest - prefix \"%s\" not defined in module \"%s\".",
+    LOGVAL(ctx, NULL, LYVE_REFERENCE, "Invalid schema-nodeid nametest - prefix \"%s\" not defined in module \"%s\".",
             prefix_dict, LYSP_MODULE_NAME(pmod));
     return NULL;
 }
@@ -254,9 +254,7 @@ lys_nodeid_mod_check(struct lysc_ctx *ctx, const char *str, ly_bool abs, struct
     if (abs || nodeid) {
         /* compile into nodeid, only if needed */
         LY_CHECK_GOTO(ret = lys_precompile_nodeid(ctx->ctx, str, &ni), cleanup);
-    }
 
-    if (abs) {
         for (i = 0; i < ni->count; ++i) {
             mod = (struct lys_module *)lys_schema_node_get_module(ctx->ctx, ni->prefix[i], ctx->pmod);
             LY_CHECK_ERR_GOTO(!mod, ret = LY_EVALID, cleanup);

tests/utests/schema/test_tree_schema_compile.c

@@ -2872,6 +2872,22 @@ test_refine(void **state)
             "uses g:grp {refine c/ll {min-elements 1;}}}", LYS_IN_YANG, &mod));
     CHECK_LOG_CTX("Compilation of a deviated and/or refined node failed.", "/mm:{uses='g:grp'}/mm:c/ll", 0);
     CHECK_LOG_CTX("The default statement is present on leaf-list with a nonzero min-elements.", "/mm:{uses='g:grp'}/mm:c/ll", 0);
+
+    assert_int_equal(LY_EVALID, lys_parse_mem(UTEST_LYCTX, "module nn {namespace urn:nn; prefix nn;"
+            "grouping test-group {"
+            "  container cont {"
+            "    leaf my-leaf {type string;}"
+            "  }"
+            "}"
+            "container test-container {"
+            "  uses test-group {"
+            "    refine \"invalid:my-leaf\" {"
+            "      description \"test\";"
+            "    }"
+            "  }"
+            "}}", LYS_IN_YANG, &mod));
+    CHECK_LOG_CTX("Invalid schema-nodeid nametest - prefix \"invalid\" not defined in module \"nn\".",
+            "/nn:test-container/{uses='test-group'}/{refine='invalid:my-leaf'}", 0);
 }
 
 static void