Fix test suite imports and add CI lint + PyPI release workflow

- conftest.py: mock utilities.htmx and provide a real _FakeBaseTable
  (subclass of django_tables2.Table) so views.py imports cleanly and
  CustomObjectsTabTable can be subclassed in tests
- test_register_tabs.py: add TestCustomObjectsTabTable (6 tests) and
  TestSortHeader (4 tests); all 24 tests now pass
- ci.yml: add ruff lint job (check + format --check) before the test job
- release.yml: new workflow — builds sdist/wheel and publishes to PyPI
  via OIDC Trusted Publishing when a GitHub Release is published

Author: Kani999

.github/workflows/ci.yml

@@ -7,6 +7,18 @@ on:
     branches: [main, master]
 
 jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - run: pip install ruff
+      - run: ruff check netbox_custom_objects_tab/
+      - run: ruff format --check netbox_custom_objects_tab/
+
   test:
     name: Run tests
     runs-on: ubuntu-latest

.github/workflows/release.yml

@@ -0,0 +1,35 @@
+name: Publish to PyPI
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  build:
+    name: Build distribution
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - run: pip install build
+      - run: python -m build
+      - uses: actions/upload-artifact@v4
+        with:
+          name: dist
+          path: dist/
+
+  publish:
+    name: Publish to PyPI
+    needs: build
+    runs-on: ubuntu-latest
+    environment: pypi
+    permissions:
+      id-token: write
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: dist
+          path: dist/
+      - uses: pypa/gh-action-pypi-publish@release/v1

tests/conftest.py

@@ -9,6 +9,8 @@
 from types import ModuleType
 from unittest.mock import MagicMock
 
+import django_tables2 as _tables2
+
 
 def _mock(dotted_name, **attrs):
     """
@@ -62,6 +64,47 @@ class _CustomFieldTypeChoices:
 _mock('utilities')
 _mock('utilities.views', ViewTab=MagicMock(), register_model_view=MagicMock())
 _mock('utilities.paginator', EnhancedPaginator=MagicMock(), get_paginate_count=MagicMock())
+_mock('utilities.htmx', htmx_partial=MagicMock())
+
+
+class _FakeBaseTable(_tables2.Table):
+    exempt_columns = ()
+
+    class Meta:
+        attrs = {}
+
+    @property
+    def name(self):
+        return self.__class__.__name__
+
+    def _get_columns(self, visible=True):
+        return [
+            (name, col.verbose_name)
+            for name, col in self.columns.items()
+            if col.visible == visible and name not in self.exempt_columns
+        ]
+
+    @property
+    def available_columns(self):
+        return sorted(self._get_columns(visible=False))
+
+    @property
+    def selected_columns(self):
+        return self._get_columns(visible=True)
+
+    def _set_columns(self, selected_columns):
+        for name, column in self.columns.items():
+            if column.name not in [*selected_columns, *self.exempt_columns]:
+                self.columns.hide(column.name)
+            else:
+                self.columns.show(column.name)
+        self.sequence = [
+            *[c for c in selected_columns if c in self.columns.names()],
+            *[c for c in self.columns.names() if c not in selected_columns],
+        ]
+
+
+_mock('netbox.tables', BaseTable=_FakeBaseTable)
 
 # --- netbox_custom_objects.* ---
 _mock('netbox_custom_objects')

tests/test_register_tabs.py

@@ -201,3 +201,81 @@ def test_unknown_specific_model_logs_warning_no_exception(self, caplog):
                 views.register_tabs()  # must not raise
 
         assert any('nonexistent_app_xyz.somemodel' in r.message for r in caplog.records)
+
+
+# ---------------------------------------------------------------------------
+# CustomObjectsTabTable
+# ---------------------------------------------------------------------------
+
+class TestCustomObjectsTabTable:
+    """Column-preference machinery on the lightweight table class."""
+
+    @pytest.fixture(autouse=True)
+    def table_cls(self):
+        from netbox_custom_objects_tab.views import CustomObjectsTabTable
+        self.cls = CustomObjectsTabTable
+
+    def test_default_columns_contains_all_six(self):
+        assert set(self.cls.Meta.default_columns) == {
+            'type', 'object', 'value', 'field', 'tags', 'actions'
+        }
+
+    def test_actions_is_exempt(self):
+        assert 'actions' in self.cls.exempt_columns
+
+    def test_name_property(self):
+        t = self.cls([], empty_text='')
+        assert t.name == 'CustomObjectsTabTable'
+
+    def test_all_columns_visible_by_default(self):
+        t = self.cls([], empty_text='')
+        t._set_columns(list(self.cls.Meta.default_columns))
+        visible = {col for col, _ in t.selected_columns}
+        assert {'type', 'object', 'value', 'field', 'tags'}.issubset(visible)
+
+    def test_hidden_column_not_in_selected(self):
+        t = self.cls([], empty_text='')
+        cols_without_value = [c for c in self.cls.Meta.default_columns if c != 'value']
+        t._set_columns(cols_without_value)
+        visible = {col for col, _ in t.selected_columns}
+        assert 'value' not in visible
+
+    def test_exempt_column_always_visible(self):
+        t = self.cls([], empty_text='')
+        # Pass only non-exempt, non-actions columns
+        t._set_columns(['type'])
+        # 'actions' is exempt — must not appear in selected_columns
+        # (exempt columns are excluded from the modal, not from rendering)
+        selected_names = {col for col, _ in t.selected_columns}
+        assert 'actions' not in selected_names   # exempt cols excluded from selected_columns
+
+
+# ---------------------------------------------------------------------------
+# _sort_header
+# ---------------------------------------------------------------------------
+
+class TestSortHeader:
+    @pytest.fixture(autouse=True)
+    def get_fn(self):
+        from netbox_custom_objects_tab.views import _sort_header
+        self.fn = _sort_header
+
+    def test_inactive_column_points_to_asc(self):
+        result = self.fn('', 'type', 'object', 'asc')
+        assert 'sort=type' in result['url']
+        assert 'dir=asc' in result['url']
+        assert result['icon'] is None
+
+    def test_active_asc_column_icon_is_arrow_up(self):
+        result = self.fn('', 'type', 'type', 'asc')
+        assert result['icon'] == 'arrow-up'
+        assert 'dir=desc' in result['url']
+
+    def test_active_desc_column_icon_is_arrow_down(self):
+        result = self.fn('', 'type', 'type', 'desc')
+        assert result['icon'] == 'arrow-down'
+        assert 'dir=asc' in result['url']
+
+    def test_base_params_preserved(self):
+        result = self.fn('q=foo&tag=bar', 'type', '', 'asc')
+        assert result['url'].startswith('?q=foo&tag=bar&')