jk no webhook replies. remove close reason from embed title

Author: sarahsturgeon

web/src/index.ts

@@ -53,7 +53,6 @@ export class BaseSession extends Container<Env> {
   // In-memory only: on DO hibernation we lose geo/ISP fields in the end
   // embed, which is cosmetic — never a correctness concern.
   protected obsContext?: RequestContext;
-  private startMessageId?: string;
 
   private async fetchCapacitySnapshot(): Promise<CapacitySnapshot | undefined> {
     try {
@@ -108,7 +107,7 @@ export class BaseSession extends Container<Env> {
       this.obsContext = parseContext(request.headers.get(OBS_CONTEXT_HEADER));
       void (async () => {
         const capacity = await this.fetchCapacitySnapshot();
-        this.startMessageId = await notify.sessionStarted(this.env, {
+        await notify.sessionStarted(this.env, {
           sessionId,
           branch: this.branch,
           context: this.obsContext ?? { ip: "unknown" },
@@ -415,7 +414,6 @@ export class BaseSession extends Container<Env> {
         extensionGranted: this.extensionGranted,
         context: this.obsContext,
         capacity,
-        replyTo: this.startMessageId,
       });
     })();
   }

web/src/observability/embeds.ts

@@ -27,7 +27,6 @@ interface DiscordEmbed {
 
 export interface DiscordWebhookPayload {
   embeds: DiscordEmbed[];
-  message_reference?: { message_id: string };
 }
 
 const COLORS = {
@@ -197,7 +196,7 @@ export function buildSessionEndedEmbed(e: SessionEndedEvent): DiscordEmbed {
   );
 
   return {
-    title: `🏁 Session ended · ${reason.label}`,
+    title: "🏁 Session ended",
     url: sessionHistoryUrl(e.sessionId),
     description: truncate(lines.join("\n"), LIMIT_DESCRIPTION),
     color: reason.color,

web/src/observability/index.ts

@@ -23,10 +23,7 @@ export const notify = {
   sessionStarted: (env: Env, event: SessionStartedEvent) =>
     post(env, { embeds: [buildSessionStartedEmbed(event)] }),
   sessionEnded: (env: Env, event: SessionEndedEvent) =>
-    post(env, {
-      embeds: [buildSessionEndedEmbed(event)],
-      ...(event.replyTo ? { message_reference: { message_id: event.replyTo } } : {}),
-    }),
+    post(env, { embeds: [buildSessionEndedEmbed(event)] }),
   queueEntered: (env: Env, event: QueueEnteredEvent) =>
     post(env, { embeds: [buildQueueEnteredEmbed(event)] }),
   error: (env: Env, event: ErrorEvent) =>

web/src/observability/types.ts

@@ -46,7 +46,6 @@ export interface SessionEndedEvent {
   extensionGranted: boolean;
   context?: RequestContext;
   capacity?: CapacitySnapshot;
-  replyTo?: string;
 }
 
 export interface QueueEnteredEvent {

web/src/observability/webhook.ts

@@ -4,24 +4,23 @@ const WEBHOOK_TIMEOUT_MS = 3000;
 
 // Fire-and-forget. No-op when the secret is unset. Never throws —
 // observability must not be able to break the request path.
-// Returns the Discord message ID when available (for threading replies).
-export async function post(env: { DISCORD_WEBHOOK_URL?: string }, payload: DiscordWebhookPayload): Promise<string | undefined> {
+export async function post(env: { DISCORD_WEBHOOK_URL?: string }, payload: DiscordWebhookPayload): Promise<void> {
   const url = env.DISCORD_WEBHOOK_URL;
-  if (!url) return undefined;
+  if (!url) return;
 
   let body: string;
   try {
     body = JSON.stringify(payload);
   } catch (e) {
     console.error("[obs] webhook payload JSON.stringify failed:", e);
-    return undefined;
+    return;
   }
 
   const controller = new AbortController();
   const timeout = setTimeout(() => controller.abort(), WEBHOOK_TIMEOUT_MS);
 
   try {
-    const res = await fetch(`${url}?wait=true`, {
+    const res = await fetch(url, {
       method: "POST",
       headers: { "Content-Type": "application/json" },
       body,
@@ -32,10 +31,7 @@ export async function post(env: { DISCORD_WEBHOOK_URL?: string }, payload: Disco
       console.error(
         `[obs] webhook non-2xx: status=${res.status} statusText=${res.statusText} body=${resBody.slice(0, 300)}`,
       );
-      return undefined;
     }
-    const data = await res.json<{ id: string }>();
-    return data.id;
   } catch (e) {
     if (e instanceof Error && e.name === "AbortError") {
       console.error(`[obs] webhook timed out after ${WEBHOOK_TIMEOUT_MS}ms`);
@@ -44,7 +40,6 @@ export async function post(env: { DISCORD_WEBHOOK_URL?: string }, payload: Disco
       const msg = e instanceof Error ? e.message : String(e);
       console.error(`[obs] webhook post failed: ${name}: ${msg}`);
     }
-    return undefined;
   } finally {
     clearTimeout(timeout);
   }