refactor: remove deprecated save_error_snapshot_legacy function and its tests, exposing save_error_snapshot_enhanced in its place.

Author: NikkeTryHard

browser_utils/__init__.py

@@ -5,7 +5,7 @@
     capture_playwright_state,
     get_texas_timestamp,
     save_comprehensive_snapshot,
-    save_error_snapshot_legacy,
+    save_error_snapshot_enhanced,
 )
 from .initialization import (
     _close_page_logic,
@@ -63,7 +63,7 @@
     "PageController",
     # Debug utilities (comprehensive error snapshots)
     "save_comprehensive_snapshot",
-    "save_error_snapshot_legacy",
+    "save_error_snapshot_enhanced",
     "get_texas_timestamp",
     "capture_dom_structure",
     "capture_playwright_state",

browser_utils/debug_utils.py

@@ -694,20 +694,3 @@ async def save_error_snapshot_enhanced(
         locators=locators,
         error_exception=error_exception,
     )
-
-
-async def save_error_snapshot_legacy(error_name: str = "error") -> None:
-    """
-    Legacy error snapshot function for backward compatibility.
-
-    DEPRECATED: Use save_error_snapshot_enhanced() or save_comprehensive_snapshot() instead.
-
-    Args:
-        error_name: Error name with optional req_id suffix (e.g., "error_hbfu521")
-    """
-    # Delegate to enhanced function with minimal context
-    await save_error_snapshot_enhanced(
-        error_name=error_name,
-        error_stage="Legacy snapshot call",
-        additional_context={"legacy_call": True},
-    )

tests/browser_utils/test_debug_utils.py

@@ -24,7 +24,6 @@
     get_texas_timestamp,
     save_comprehensive_snapshot,
     save_error_snapshot_enhanced,
-    save_error_snapshot_legacy,
 )
 
 # === Smart Fixtures to Reduce Mocking ===
@@ -715,36 +714,3 @@ async def test_enhanced_snapshot_with_exception(
             # Verify exception was passed
             call_kwargs = mock_save.call_args[1]
             assert call_kwargs["error_exception"] == error_exc
-
-
-# === Section 7: Legacy Snapshot Tests ===
-
-
-class TestSaveErrorSnapshotLegacy:
-    """测试遗留错误快照函数"""
-
-    @pytest.mark.asyncio
-    async def test_legacy_snapshot_delegates_to_enhanced(self):
-        """测试遗留函数委托给增强函数"""
-        with patch(
-            "browser_utils.debug_utils.save_error_snapshot_enhanced"
-        ) as mock_enhanced:
-            await save_error_snapshot_legacy(error_name="legacy_error_req9999")
-
-            # Verify enhanced was called
-            mock_enhanced.assert_called_once()
-            call_kwargs = mock_enhanced.call_args[1]
-            assert call_kwargs["error_name"] == "legacy_error_req9999"
-            assert call_kwargs["error_stage"] == "Legacy snapshot call"
-            assert call_kwargs["additional_context"]["legacy_call"] is True
-
-    @pytest.mark.asyncio
-    async def test_legacy_snapshot_default_error_name(self):
-        """测试默认错误名称"""
-        with patch(
-            "browser_utils.debug_utils.save_error_snapshot_enhanced"
-        ) as mock_enhanced:
-            await save_error_snapshot_legacy()
-
-            call_kwargs = mock_enhanced.call_args[1]
-            assert call_kwargs["error_name"] == "error"