add unittests for utils.UnifiedConfiguration

Author: ishanrai05

tests/test_utils.py

@@ -1,12 +1,15 @@
 import sys
 
 import unittest
-from mock import MagicMock
+import mock
+from mock import MagicMock, patch, mock_open
+import json
 
 
 class TestDeepUpdate(unittest.TestCase):
 
     def setUp(self):
+
         self.u = {
             "first": {"a": "A"},
             "second": "B"
@@ -26,6 +29,36 @@ def test_deep_update(self):
         self.assertDictEqual(self.d, self.deep_update(self.d, self.u))
 
 
+class TestUnifiedConfiguration(unittest.TestCase):
+
+    def setUp(self):
+        self.test_json = json.dumps({
+            "email": {
+                "value": ["test@cern.ch", "test@testmail.com"],
+                "description": "The list of people that get the emails notifications"
+            }
+        })
+
+    def test_get_json(self):
+
+        from WmAgentScripts.utils import unifiedConfiguration, open_json_file
+        mock_open_json = mock_open(read_data=self.test_json)
+        with patch('__builtin__.open', mock_open_json):
+            result = open_json_file('filename')
+            uc = unifiedConfiguration(configFile='fake_file_path')
+            self.assertEqual(
+                uc.get("email"), ["test@cern.ch", "test@testmail.com"])
+
+        with self.assertRaises(SystemExit):
+            self.assertEqual(
+                uc.get("cernmails"), [
+                    "test@cern.ch", "test@testmail.com"])
+
+    def test_get_mongodb(self):
+        
+        # TODO: mock db and write tests
+        pass
+
 
 if __name__ == '__main__':
     unittest.main()

utils.py

@@ -36,6 +36,9 @@ def mongo_client():
     return pymongo.MongoClient('mongodb://%s/?ssl=true' % mongo_db_url,
                                ssl_cert_reqs=ssl.CERT_NONE)
 
+def open_json_file(filename):
+    with open(filename) as f:
+        return json.loads(f.read())
 
 class unifiedConfiguration:
     def __init__(self, configFile='unifiedConfiguration.json'):
@@ -45,7 +48,7 @@ def __init__(self, configFile='unifiedConfiguration.json'):
             self.configs = self.configFile
         else:
             try:
-                self.configs = json.loads(open(self.configFile).read())
+                self.configs = open_json_file(self.configFile)
             except Exception as ex:
                 print("Could not read configuration file: %s\nException: %s" %
                       (self.configFile, str(ex)))