Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Commit 5cca7f2

Browse files
authored
Merge pull request #547 from todor-ivanov/bug_Communicate_ParentageResolved
Adding a check for ParentageResolved before announcement
2 parents 25bff9f + 18c2f8c commit 5cca7f2

2 files changed

Lines changed: 13 additions & 0 deletions

File tree

Unified/closor.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ def close(self):
374374

375375
jump_the_line = self.jump_the_line
376376
batch_goodness = self.batch_goodness
377+
check_parentage_to_announce = UC.get('check_parentage_to_announce')
377378
check_fullcopy_to_announce = UC.get('check_fullcopy_to_announce')
378379

379380
## what is the expected #lumis
@@ -585,6 +586,14 @@ def close(self):
585586
print wfo.name,"no stats for announcing",out
586587
results.append('No Stats')
587588

589+
# adding check for PrentageResolved flag from ReqMgr:
590+
if wfi.request['RequestType'] == 'StepChain' and check_parentage_to_announce:
591+
if wfi.request['ParentageResolved']:
592+
results.append(True)
593+
else:
594+
wfi.sendLog('closor',"Delayed announcement of %s due to unresolved Parentage dependencies" % wfi.request['RequestName'])
595+
results.append('No ParentageResolved')
596+
588597
if all(map(lambda result : result in ['None',None,True],results)):
589598
if not jump_the_line:
590599
## only announce if all previous are fine

unifiedConfiguration.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,10 @@
242242
"value" : false,
243243
"description": "Whether to check for a full copy being present prior to announcing a dataset"
244244
},
245+
"check_parentage_to_announce": {
246+
"value" : true,
247+
"description": "Whether to check if all blocks are having their parentage dependencies resolved before announcing a dataset"
248+
},
245249
"stagor_sends_back": {
246250
"value" : true,
247251
"description": "Whether the stagor module can send workflow back to considered"

0 commit comments

Comments
 (0)