Fixing transaction error handling

Author: thiagoromanos

aries_cloudagent/anoncreds/default/did_besu/registry.py

@@ -8,6 +8,7 @@
 
 from base58 import alphabet
 from web3 import Web3
+from web3.exceptions import ContractCustomError
 from web3.middleware import geth_poa_middleware
 from web3.types import TxReceipt
 
@@ -255,6 +256,10 @@ async def send_transaction_tx(self, call_function) -> TxReceipt:
         # Wait for transaction receipt
         tx_receipt = self.web3.eth.wait_for_transaction_receipt(send_tx)
 
+        if tx_receipt["status"] == 0:
+            LOGGER.debug("Receipt of the reverted transaction: %s", tx_receipt)
+            raise AnonCredsRegistrationError(f"Transaction reverted: %s", send_tx)
+        
         return tx_receipt
 
     async def register_revocation(
@@ -621,7 +626,10 @@ async def register_revocation_registry_definition(
             # receipt = contract.functions.createSchema(indy_schema).transact({"from": self.ACCOUNT})
             LOGGER.debug("Receipt: %s", tx_receipt)
             # Was it realy created?
-            result = contract.functions.resolveRevocation(rev_reg_def_id).call()
+            try:
+                contract.functions.resolveRevocation(rev_reg_def_id).call()
+            except ContractCustomError as e:
+                raise AnonCredsRegistrationError("Error searching for newly created revocation") from e
 
             seq_no = self.REVOCATION_ADDRESS
         except LedgerError as err:

aries_cloudagent/ledger/besu_vdr.py

@@ -144,7 +144,7 @@ async def fetch_schema_by_id(self, schema_id: str) -> dict:
                 )
 
         except ContractCustomError as ex:
-            LOGGER.error(f"Could not retrieve schema {schema_id} {ex.message}")
+            LOGGER.debug(f"Could not retrieve schema {schema_id} {ex.message}")
         return schema
 
     async def fetch_schema_by_seq_no(self, seq_no: int) -> dict:
@@ -367,7 +367,7 @@ async def send_credential_definition_anoncreds(
         tx_receipt = self._send_signed_transaction(call_function, False)
         LOGGER.debug("Receipt: %s", tx_receipt)
 
-        result = self.fetch_credential_definition(cred_def_id)
+        result = await self.fetch_credential_definition(cred_def_id)
         if not result:
             raise LedgerError("Failed to register credef")
 

aries_cloudagent/messaging/valid.py

@@ -489,12 +489,12 @@ class IndyRevRegId(Regexp):
         rf"([{B58}]{{21,22}}):3:"
         rf"CL:(([1-9][0-9]*)|([{B58}]{{21,22}}:2:.+:[0-9.]+))(:.+)?:"
         rf"CL_ACCUM:(.+$)|^((did:indy2)?:.+:[{B58}]{{21,22}})"  # issuer DID
-            f"/anoncreds/v0/REV_REG_DEF/"  # cred def id marker
+            f"\/anoncreds\/v0\/REV_REG_DEF\/"  # cred def id marker
             rf"((did:indy2)?:.+:[{B58}]{{21,22}})"  # issuer DID
-            f"/anoncreds/v0/CLAIM_DEF/"  # cred def id marker
+            f"\/anoncreds\/v0\/CLAIM_DEF\/"  # cred def id marker
             # f":CL"  # sig alg
-            rf"((did:indy2)?:.+:[{B58}]{{21,22}}/anoncreds/v0/SCHEMA/.+/[0-9.]+)"  # schema txn / id
-            f"/(.+)?(:|/)CL_ACCUM(:|/).+$"
+            rf"((did:indy2)?:.+:[{B58}]{{21,22}}\/anoncreds\/v0\/SCHEMA\/.+\/[0-9.]+)"  # schema txn / id
+            f"\/(.+)?(:|\/)CL_ACCUM(:|\/).+$"
     )
 
     def __init__(self):