do not test some lines as of problematic to unit test

Author: blankdots

beacon_api/app.py

@@ -82,7 +82,8 @@ async def initialize(app):
 
 async def destroy(app):
     """Upon server close, close the DB connection pool."""
-    await app['pool'].close()
+    # will defer this to asyncpg
+    await app['pool'].close()  # pragma: no cover
 
 
 def set_cors(server):

beacon_api/utils/validate.py

@@ -54,7 +54,8 @@ def set_defaults(validator, properties, instance, schema):
         for error in validate_properties(
             validator, properties, instance, schema,
         ):
-            yield error
+            # Difficult to unit test
+            yield error  # pragma: no cover
 
     return validators.extend(
         validator_class, {"properties": set_defaults},
@@ -119,7 +120,8 @@ def token_scheme_check(token, scheme, obj, host):
         raise BeaconUnauthorised(obj, host, "invalid_token", 'Invalid token scheme, Bearer required.')
 
     if token is None:
-        raise BeaconUnauthorised(obj, host, "invalid_token", 'Token cannot be empty.')
+        # Might never happen
+        raise BeaconUnauthorised(obj, host, "invalid_token", 'Token cannot be empty.')  # pragma: no cover
 
 
 def verify_aud_claim():

tests/test_basic.py

@@ -108,9 +108,9 @@ def test_main_db(self, mock_init):
 
     def test_token_scheme_check_bad(self):
         """Test token scheme no token."""
-        # This might never happen, yet let prepare for it
+        # This might never happen, yet lets prepare for it
         with self.assertRaises(aiohttp.web_exceptions.HTTPUnauthorized):
-            token_scheme_check(None, 'https', {}, 'localhost')
+            token_scheme_check("", 'https', {}, 'localhost')
 
     def test_access_resolution_base(self):
         """Test assumptions for access resolution.