Skip to content

Commit 338eb6f

Browse files
committed
Fix issue with keyfile and signing. Also correct namespace to match project.
1 parent 5615870 commit 338eb6f

9 files changed

Lines changed: 60 additions & 10 deletions

Directory.Build.targets

Lines changed: 48 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,51 @@
11
<Project>
2+
<PropertyGroup>
3+
<AssemblyOriginatorKeyFile Condition="'$(AssemblyOriginatorKeyFile)'=='' AND EXISTS('$(MSBuildThisFileDirectory)build/cloud3d-codesign.snk')">$(MSBuildThisFileDirectory)build/cloud3d-codesign.snk</AssemblyOriginatorKeyFile>
4+
<AssemblyOriginatorKeyFile Condition="'$(AssemblyOriginatorKeyFile)'==''">$(MSBuildThisFileDirectory)build/Test.snk</AssemblyOriginatorKeyFile>
5+
<SignAssembly Condition="EXISTS('$(AssemblyOriginatorKeyFile)')">true</SignAssembly>
6+
</PropertyGroup>
7+
8+
<PropertyGroup>
9+
<GenerateNuspecDependsOn>SetAuthors;SetPackageTags;SetPackageDescription;$(GenerateNuspecDependsOn)</GenerateNuspecDependsOn>
10+
</PropertyGroup>
11+
12+
<Target Name="SetAuthors">
13+
<RemoveDuplicates
14+
Inputs="@(Author)">
15+
<Output
16+
TaskParameter="Filtered"
17+
ItemName="_Author"/>
18+
</RemoveDuplicates>
19+
<PropertyGroup>
20+
<Authors Condition="'@(_Author)'!=''">@(_Author, ',')</Authors>
21+
</PropertyGroup>
22+
</Target>
23+
24+
<Target Name="SetPackageTags">
25+
<RemoveDuplicates
26+
Inputs="@(PackageTag)">
27+
<Output
28+
TaskParameter="Filtered"
29+
ItemName="_PackageTag"/>
30+
</RemoveDuplicates>
31+
<PropertyGroup>
32+
<PackageTags Condition="'$(PackageTags)'==''">@(_PackageTag, ' ')</PackageTags>
33+
</PropertyGroup>
34+
</Target>
35+
36+
<Target Name="SetPackageDescription" DependsOnTargets="GetBuildVersion">
37+
<PropertyGroup>
38+
<PackageDescription>
39+
Assembly Version: $(AssemblyVersion)
40+
File Version: $(AssemblyFileVersion)
41+
Informational Version: $(AssemblyInformationalVersion)
42+
Build Configuration: $(Configuration)
43+
$(AssemblyDescription)
44+
</PackageDescription>
45+
</PropertyGroup>
46+
<Message Text="Package Description: $(PackageDescription)" Importance="high" />
47+
</Target>
48+
249
<Target Name="PackIfChanged">
350
<ItemGroup>
451
<_Temporary Remove="@_Temporary)" />
@@ -30,7 +77,7 @@
3077
<_Temporary Remove="@_Temporary)" />
3178
</ItemGroup>
3279
<Message Importance="high" Text="CommitIDFound: $(CommitIDFound)" />
33-
80+
3481
<!-- Pack libraries -->
3582
<MSBuild Projects="$(MSBuildProjectFile)" Targets="Pack" Condition="'$(IsPackable)'=='true' AND '$(CommitIDFound)'=='true'" />
3683
<!-- Build sample and test projects to ensure they can build correctly -->

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ A set of Logging related packages, most that are based on `Microsoft.Extensions.
44

55
## C3D.Extensions.Logging.Xunit
66

7+
[![NuGet package](https://img.shields.io/nuget/v/C3D.Extensions.Logging.Xunit.svg)](https://nuget.org/packages/C3D.Extensions.Logging.Xunit)
8+
[![NuGet downloads](https://img.shields.io/nuget/dt/C3D.Extensions.Logging.Xunit.svg)](https://nuget.org/packages/C3D.Extensions.Logging.Xunit)
9+
710
An implementation of `Microsoft.Extensions.Logging` Loggers wrapping the `xunit` 'output' types `ITestOutputHelper` and `IMessageSink`.
811
This allows you to take the logged output from things like hosting or SUT classes that take an `ILogger` and show it in the test output.
912

src/C3D/Extensions/Logging/Xunit/C3D.Extensions.Logging.Xunit.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<Nullable>enable</Nullable>
66
<LangVersion>10.0</LangVersion>
77
<ImplicitUsings>enable</ImplicitUsings>
8-
<RootNamespace>C3D.Core.Xunit.Logging</RootNamespace>
8+
<RootNamespace>C3D.Extensions.Xunit.Logging</RootNamespace>
99

1010
<AssemblyTitle>$(AssemblyTitle) Logging</AssemblyTitle>
1111
</PropertyGroup>

src/C3D/Extensions/Logging/Xunit/Loggers/MessageSinkLogger.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
using Xunit.Abstractions;
33
using Xunit.Sdk;
44

5-
namespace C3D.Core.Xunit.Logging.Loggers;
5+
namespace C3D.Extensions.Xunit.Logging.Loggers;
66

77
public class MessageSinkLogger : XunitLoggerBase
88
{

src/C3D/Extensions/Logging/Xunit/Loggers/TextOutputLogger.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
using Microsoft.Extensions.Logging;
22
using Xunit.Abstractions;
33

4-
namespace C3D.Core.Xunit.Logging.Loggers;
4+
namespace C3D.Extensions.Xunit.Logging.Loggers;
55

66
public class TextOutputLogger : XunitLoggerBase
77
{

src/C3D/Extensions/Logging/Xunit/Loggers/XunitLoggerBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
using C3D.Core.Xunit.Logging.Loggers;
1+
using C3D.Extensions.Xunit.Logging.Loggers;
22
using Microsoft.Extensions.Logging;
33
using System.Text;
44

5-
namespace C3D.Core.Xunit.Logging.Loggers;
5+
namespace C3D.Extensions.Xunit.Logging.Loggers;
66

77
public abstract class XunitLoggerBase : ILogger
88
{

src/C3D/Extensions/Logging/Xunit/XunitLoggerOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
using Microsoft.Extensions.Logging;
22

3-
namespace C3D.Core.Xunit.Logging;
3+
namespace C3D.Extensions.Xunit.Logging;
44

55
public enum XunitLoggerTimeStamp
66
{

src/C3D/Extensions/Logging/Xunit/XunitLoggerProvider.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
using C3D.Core.Xunit.Logging.Loggers;
1+
using C3D.Extensions.Xunit.Logging.Loggers;
22
using Microsoft.Extensions.Logging;
33
using Microsoft.Extensions.Logging.Abstractions;
44
using Microsoft.Extensions.Options;
55
using System.Collections.Concurrent;
66
using System.Diagnostics.CodeAnalysis;
77
using Xunit.Abstractions;
88

9-
namespace C3D.Core.Xunit.Logging;
9+
namespace C3D.Extensions.Xunit.Logging;
1010

1111
[ProviderAlias("Xunit")]
1212
public sealed class XunitLoggerProvider : ILoggerProvider

src/Directory.Build.Props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
<PackageOutputPath Condition="'$(PackageOutputPath)'==''">$(MSBuildThisFileDirectory)..\packages\</PackageOutputPath>
99
<EnableDefaultNoneItems>false</EnableDefaultNoneItems>
1010
<NoWarn>$(NoWarn);NU5128;SA0001</NoWarn>
11+
<AssemblyTitle>C3D Extensions Logging</AssemblyTitle>
1112
</PropertyGroup>
1213

1314
<ItemGroup>
14-
<PackageTag Include="C3D" />
1515
<PackageTag Include="CZEM" />
1616
<PackageTag Include="Logging" />
1717
</ItemGroup>

0 commit comments

Comments
 (0)