Skip to content

Commit 29888db

Browse files
refactor(php74): use null coalescing (??) and ??= operators
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
1 parent a916309 commit 29888db

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

audit.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@
5151
if ($data['action'] == 'cli') {
5252
$width = 'wide';
5353
$output .= '<table style="width:100%" class="' . $width . '"><tr><td>';
54-
$output .= '<span><b>' . __('Page:', 'audit') . '</b> <i>' . $data['page'] . '</i></span>';
55-
$output .= '<br><span><b>' . __('User:', 'audit') . '</b> <i>' . $data['user_agent'] . '</i></span>';
56-
$output .= '<br><span><b>' . __('IP Address:', 'audit') . '</b> <i>' . $data['ip_address'] . '</i></span>';
57-
$output .= '<br><span><b>' . __('Date:', 'audit') . '</b> <i>' . $data['event_time'] . '</i></span>';
58-
$output .= '<br><span><b>' . __('Action:', 'audit') . '</b> <i>' . $data['action'] . '</i></span>';
54+
$output .= '<span><b>' . __('Page:', 'audit') . '</b> <i>' . html_escape($data['page']) . '</i></span>';
55+
$output .= '<br><span><b>' . __('User:', 'audit') . '</b> <i>' . html_escape($data['user_agent']) . '</i></span>';
56+
$output .= '<br><span><b>' . __('IP Address:', 'audit') . '</b> <i>' . html_escape($data['ip_address']) . '</i></span>';
57+
$output .= '<br><span><b>' . __('Date:', 'audit') . '</b> <i>' . html_escape($data['event_time']) . '</i></span>';
58+
$output .= '<br><span><b>' . __('Action:', 'audit') . '</b> <i>' . html_escape($data['action']) . '</i></span>';
5959
$output .= '<hr>';
60-
$output .= '<span><b>' . __('Script:', 'audit') . '</b> <i>' . $data['post'] . '</i></span>';
60+
$output .= '<span><b>' . __('Script:', 'audit') . '</b> <i>' . html_escape($data['post']) . '</i></span>';
6161
} elseif (cacti_sizeof($data)) {
6262
$attribs = json_decode($data['post']);
6363

@@ -74,11 +74,11 @@
7474
}
7575

7676
$output .= '<table style="width:100%" class="' . $width . '"><tr><td>';
77-
$output .= '<span><b>' . __('Page:', 'audit') . '</b> <i>' . $data['page'] . '</i></span>';
78-
$output .= '<br><span><b>' . __('User:', 'audit') . '</b> <i>' . get_username($data['user_id']) . '</i></span>';
79-
$output .= '<br><span><b>' . __('IP Address:', 'audit') . '</b> <i>' . $data['ip_address'] . '</i></span>';
80-
$output .= '<br><span><b>' . __('Date:', 'audit') . '</b> <i>' . $data['event_time'] . '</i></span>';
81-
$output .= '<br><span><b>' . __('Action:', 'audit') . '</b> <i>' . $data['action'] . '</i></span>';
77+
$output .= '<span><b>' . __('Page:', 'audit') . '</b> <i>' . html_escape($data['page']) . '</i></span>';
78+
$output .= '<br><span><b>' . __('User:', 'audit') . '</b> <i>' . html_escape(get_username($data['user_id'])) . '</i></span>';
79+
$output .= '<br><span><b>' . __('IP Address:', 'audit') . '</b> <i>' . html_escape($data['ip_address']) . '</i></span>';
80+
$output .= '<br><span><b>' . __('Date:', 'audit') . '</b> <i>' . html_escape($data['event_time']) . '</i></span>';
81+
$output .= '<br><span><b>' . __('Action:', 'audit') . '</b> <i>' . html_escape($data['action']) . '</i></span>';
8282
$output .= '<hr>';
8383
$output .= '<table style="width:100%">';
8484

audit_functions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ function audit_config_insert() {
157157

158158
$post = json_encode($post);
159159
$page = basename($_SERVER['SCRIPT_NAME']);
160-
$user_id = (isset($_SESSION['sess_user_id']) ? $_SESSION['sess_user_id'] : 0);
160+
$user_id = ($_SESSION['sess_user_id'] ?? 0);
161161
$event_time = date('Y-m-d H:i:s');
162162

163163
/* Retrieve IP address */

0 commit comments

Comments
 (0)